From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 7F8761B19A; Thu, 14 Sep 2017 10:30:23 +0200 (CEST)
In-Reply-To: <20170914082651.26232-2-akhil.goyal@nxp.com>
References: <20170914082651.26232-2-akhil.goyal@nxp.com>
To: test-report@dpdk.org
Cc: Akhil Goyal <akhil.goyal@nxp.com>
Message-Id: <20170914083023.7F8761B19A@dpdk.org>
Date: Thu, 14 Sep 2017 10:30:23 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw28711 [PATCH 01/11]
	lib/rte_security: add security library
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Sep 2017 08:30:23 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28711

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#169: FILE: lib/librte_security/rte_security.c:67:
+#define RTE_SEC_VALID_ID_OR_ERR_RET(id, retval) do { \
+	if (!rte_security_is_valid_id(id)) { \
+		RTE_PMD_DEBUG_TRACE("Invalid sec_id=%d
", id); \
+		return retval; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#176: FILE: lib/librte_security/rte_security.c:74:
+#define RTE_SEC_VALID_ID_OR_RET(id) do { \
+	if (!rte_security_is_valid_id(id)) { \
+		RTE_PMD_DEBUG_TRACE("Invalid sec_id=%d
", id); \
+		return; \
+	} \
+} while (0)

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#485: FILE: lib/librte_security/rte_security.h:125:
+	/** Extended Sequence Numbers (ESN)
+	  *

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#492: FILE: lib/librte_security/rte_security.h:132:
+	/** UDP encapsulation
+	  *

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#500: FILE: lib/librte_security/rte_security.h:140:
+	/** Copy DSCP bits
+	  *

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#510: FILE: lib/librte_security/rte_security.h:150:
+	/** Copy IPv6 Flow Label
+	  *

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#518: FILE: lib/librte_security/rte_security.h:158:
+	/** Copy IPv4 Don't Fragment bit
+	  *

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#526: FILE: lib/librte_security/rte_security.h:166:
+	/** Decrement inner packet Time To Live (TTL) field
+	  *

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#535: FILE: lib/librte_security/rte_security.h:175:
+	/** HW constructs/removes trailer of packets
+	  *

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#591: FILE: lib/librte_security/rte_security.h:231:
+	 * during transmission */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#594: FILE: lib/librte_security/rte_security.h:234:
+	 * transmission */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#597: FILE: lib/librte_security/rte_security.h:237:
+	 * on a lookaside accelerator */

total: 0 errors, 12 warnings, 993 lines checked