From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Akhil Goyal <akhil.goyal@nxp.com>
Subject: [dpdk-test-report] |WARNING| pw28719 [PATCH 09/11] net/ixgbe: enable inline ipsec
Date: Thu, 14 Sep 2017 10:30:31 +0200 (CEST) [thread overview]
Message-ID: <20170914083031.ED8501AEE8@dpdk.org> (raw)
In-Reply-To: <20170914082651.26232-10-akhil.goyal@nxp.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28719
_coding style issues_
WARNING:LONG_LINE: line over 90 characters
#120: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:3678:
+ dev_info->tx_offload_capa |= DEV_TX_OFFLOAD_SECURITY | DEV_TX_OFFLOAD_SEC_NEED_MDATA;
CHECK:MACRO_ARG_REUSE: Macro argument reuse '__reg' - possible side-effects?
#251: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:47:
+#define IXGBE_WAIT_RW(__reg, __rw) \
+{ \
+ int cnt = 100; \
+ IXGBE_WRITE_REG(hw, (__reg), reg); \
+ while (((IXGBE_READ_REG(hw, (__reg))) & (__rw)) && (cnt--)) \
+ rte_delay_us(1); \
+}
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#263: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:59:
+#define CMP_IP(a, b) (\
+ rte_cpu_to_be_32((a).ipv6[0]) == (b).ipv6[0] && \
+ rte_cpu_to_be_32((a).ipv6[1]) == (b).ipv6[1] && \
+ rte_cpu_to_be_32((a).ipv6[2]) == (b).ipv6[2] && \
+ rte_cpu_to_be_32((a).ipv6[3]) == (b).ipv6[3])
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#263: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:59:
+#define CMP_IP(a, b) (\
+ rte_cpu_to_be_32((a).ipv6[0]) == (b).ipv6[0] && \
+ rte_cpu_to_be_32((a).ipv6[1]) == (b).ipv6[1] && \
+ rte_cpu_to_be_32((a).ipv6[2]) == (b).ipv6[2] && \
+ rte_cpu_to_be_32((a).ipv6[3]) == (b).ipv6[3])
CHECK:CAMELCASE: Avoid CamelCase: <IPv4>
#406: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:202:
+ if (priv->rx_ip_tbl[ip_index].ip.type == IPv4) {
CHECK:CAMELCASE: Avoid CamelCase: <IPv6>
#506: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:302:
+ if (ic_session->dst_ip.type == IPv6)
WARNING:TYPO_SPELLING: 'lenght' may be misspelled - perhaps 'length'?
#1320: FILE: drivers/net/ixgbe/ixgbe_rxtx.h:189:
+ uint64_t sec_pad_len:4; /**< padding lenght */
total: 0 errors, 2 warnings, 5 checks, 1283 lines checked
parent reply other threads:[~2017-09-14 8:30 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20170914082651.26232-10-akhil.goyal@nxp.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170914083031.ED8501AEE8@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=akhil.goyal@nxp.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).