From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id ED8501AEE8; Thu, 14 Sep 2017 10:30:31 +0200 (CEST)
In-Reply-To: <20170914082651.26232-10-akhil.goyal@nxp.com>
References: <20170914082651.26232-10-akhil.goyal@nxp.com>
To: test-report@dpdk.org
Cc: Akhil Goyal <akhil.goyal@nxp.com>
Message-Id: <20170914083031.ED8501AEE8@dpdk.org>
Date: Thu, 14 Sep 2017 10:30:31 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw28719 [PATCH 09/11] net/ixgbe:
	enable inline ipsec
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Sep 2017 08:30:32 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28719

_coding style issues_


WARNING:LONG_LINE: line over 90 characters
#120: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:3678:
+	dev_info->tx_offload_capa |= DEV_TX_OFFLOAD_SECURITY | DEV_TX_OFFLOAD_SEC_NEED_MDATA;

CHECK:MACRO_ARG_REUSE: Macro argument reuse '__reg' - possible side-effects?
#251: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:47:
+#define IXGBE_WAIT_RW(__reg, __rw)					\
+{									\
+	int cnt = 100;							\
+	IXGBE_WRITE_REG(hw, (__reg), reg);				\
+	while (((IXGBE_READ_REG(hw, (__reg))) & (__rw)) && (cnt--))	\
+		rte_delay_us(1);					\
+}

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#263: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:59:
+#define CMP_IP(a, b) (\
+	rte_cpu_to_be_32((a).ipv6[0]) == (b).ipv6[0] && \
+	rte_cpu_to_be_32((a).ipv6[1]) == (b).ipv6[1] && \
+	rte_cpu_to_be_32((a).ipv6[2]) == (b).ipv6[2] && \
+	rte_cpu_to_be_32((a).ipv6[3]) == (b).ipv6[3])

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#263: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:59:
+#define CMP_IP(a, b) (\
+	rte_cpu_to_be_32((a).ipv6[0]) == (b).ipv6[0] && \
+	rte_cpu_to_be_32((a).ipv6[1]) == (b).ipv6[1] && \
+	rte_cpu_to_be_32((a).ipv6[2]) == (b).ipv6[2] && \
+	rte_cpu_to_be_32((a).ipv6[3]) == (b).ipv6[3])

CHECK:CAMELCASE: Avoid CamelCase: <IPv4>
#406: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:202:
+		if (priv->rx_ip_tbl[ip_index].ip.type == IPv4) {

CHECK:CAMELCASE: Avoid CamelCase: <IPv6>
#506: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:302:
+		if (ic_session->dst_ip.type == IPv6)

WARNING:TYPO_SPELLING: 'lenght' may be misspelled - perhaps 'length'?
#1320: FILE: drivers/net/ixgbe/ixgbe_rxtx.h:189:
+		uint64_t sec_pad_len:4;	/**< padding lenght */

total: 0 errors, 2 warnings, 5 checks, 1283 lines checked