From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 4EC151B19F; Thu, 14 Sep 2017 10:57:33 +0200 (CEST) In-Reply-To: <1505324838-25734-2-git-send-email-ravi1.kumar@amd.com> References: <1505324838-25734-2-git-send-email-ravi1.kumar@amd.com> To: test-report@dpdk.org Cc: Ravi Kumar Message-Id: <20170914085733.4EC151B19F@dpdk.org> Date: Thu, 14 Sep 2017 10:57:33 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw28722 [PATCH 2/4] net/axgbe : Add PMD support for AMD XGBE Ethernet X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Sep 2017 08:57:33 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/28722 _coding style issues_ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #309: FILE: drivers/net/axgbe/axgbe_common.h:72: + * ^Inotice, this list of conditions and the following disclaimer.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #311: FILE: drivers/net/axgbe/axgbe_common.h:74: + * ^Inotice, this list of conditions and the following disclaimer in the$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #312: FILE: drivers/net/axgbe/axgbe_common.h:75: + * ^Idocumentation and/or other materials provided with the distribution.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #314: FILE: drivers/net/axgbe/axgbe_common.h:77: + * ^Inames of its contributors may be used to endorse or promote products$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #315: FILE: drivers/net/axgbe/axgbe_common.h:78: + * ^Iderived from this software without specific prior written permission.$ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'arr' - possible side-effects? #402: FILE: drivers/net/axgbe/axgbe_common.h:165: +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0])) WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop #1679: FILE: drivers/net/axgbe/axgbe_common.h:1442: +#define AXGBE_REG_WRITE(val, reg) do { \ + (*((volatile uint32_t *) (reg))) = val; \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_var' - possible side-effects? #1746: FILE: drivers/net/axgbe/axgbe_common.h:1509: +#define SET_BITS(_var, _index, _width, _val) \ +do { \ + (_var) &= ~(((0x1 << (_width)) - 1) << (_index)); \ + (_var) |= (((_val) & ((0x1 << (_width)) - 1)) << (_index)); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_index' - possible side-effects? #1746: FILE: drivers/net/axgbe/axgbe_common.h:1509: +#define SET_BITS(_var, _index, _width, _val) \ +do { \ + (_var) &= ~(((0x1 << (_width)) - 1) << (_index)); \ + (_var) |= (((_val) & ((0x1 << (_width)) - 1)) << (_index)); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_width' - possible side-effects? #1746: FILE: drivers/net/axgbe/axgbe_common.h:1509: +#define SET_BITS(_var, _index, _width, _val) \ +do { \ + (_var) &= ~(((0x1 << (_width)) - 1) << (_index)); \ + (_var) |= (((_val) & ((0x1 << (_width)) - 1)) << (_index)); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_var' - possible side-effects? #1755: FILE: drivers/net/axgbe/axgbe_common.h:1518: +#define SET_BITS_LE(_var, _index, _width, _val) \ +do { \ + (_var) &= rte_cpu_to_le_32(~(((0x1 << (_width)) - 1) << (_index)));\ + (_var) |= rte_cpu_to_le_32((((_val) & \ + ((0x1 << (_width)) - 1)) << (_index))); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_index' - possible side-effects? #1755: FILE: drivers/net/axgbe/axgbe_common.h:1518: +#define SET_BITS_LE(_var, _index, _width, _val) \ +do { \ + (_var) &= rte_cpu_to_le_32(~(((0x1 << (_width)) - 1) << (_index)));\ + (_var) |= rte_cpu_to_le_32((((_val) & \ + ((0x1 << (_width)) - 1)) << (_index))); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_width' - possible side-effects? #1755: FILE: drivers/net/axgbe/axgbe_common.h:1518: +#define SET_BITS_LE(_var, _index, _width, _val) \ +do { \ + (_var) &= rte_cpu_to_le_32(~(((0x1 << (_width)) - 1) << (_index)));\ + (_var) |= rte_cpu_to_le_32((((_val) & \ + ((0x1 << (_width)) - 1)) << (_index))); \ +} while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_reg' may be better as '(_reg)' to avoid precedence issues #1797: FILE: drivers/net/axgbe/axgbe_common.h:1560: +#define AXGMAC_IOREAD(_pdata, _reg) \ + ioread32((_pdata)->xgmac_regs + _reg) CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_reg' may be better as '(_reg)' to avoid precedence issues #1805: FILE: drivers/net/axgbe/axgbe_common.h:1568: +#define AXGMAC_IOWRITE(_pdata, _reg, _val) \ + iowrite32((_val), (_pdata)->xgmac_regs + _reg) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects? #1808: FILE: drivers/net/axgbe/axgbe_common.h:1571: +#define AXGMAC_IOWRITE_BITS(_pdata, _reg, _field, _val) \ +do { \ + u32 reg_val = AXGMAC_IOREAD((_pdata), _reg); \ + SET_BITS(reg_val, \ + _reg##_##_field##_INDEX, \ + _reg##_##_field##_WIDTH, (_val)); \ + AXGMAC_IOWRITE((_pdata), _reg, reg_val); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects? #1808: FILE: drivers/net/axgbe/axgbe_common.h:1571: +#define AXGMAC_IOWRITE_BITS(_pdata, _reg, _field, _val) \ +do { \ + u32 reg_val = AXGMAC_IOREAD((_pdata), _reg); \ + SET_BITS(reg_val, \ + _reg##_##_field##_INDEX, \ + _reg##_##_field##_WIDTH, (_val)); \ + AXGMAC_IOWRITE((_pdata), _reg, reg_val); \ +} while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_reg' may be better as '(_reg)' to avoid precedence issues #1821: FILE: drivers/net/axgbe/axgbe_common.h:1584: +#define AXGMAC_MTL_IOREAD(_pdata, _n, _reg) \ + ioread32((_pdata)->xgmac_regs + \ + MTL_Q_BASE + ((_n) * MTL_Q_INC) + _reg) CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_reg' may be better as '(_reg)' to avoid precedence issues #1830: FILE: drivers/net/axgbe/axgbe_common.h:1593: +#define AXGMAC_MTL_IOWRITE(_pdata, _n, _reg, _val) \ + iowrite32((_val), (_pdata)->xgmac_regs + \ + MTL_Q_BASE + ((_n) * MTL_Q_INC) + _reg) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects? #1834: FILE: drivers/net/axgbe/axgbe_common.h:1597: +#define AXGMAC_MTL_IOWRITE_BITS(_pdata, _n, _reg, _field, _val) \ +do { \ + u32 reg_val = AXGMAC_MTL_IOREAD((_pdata), (_n), _reg); \ + SET_BITS(reg_val, \ + _reg##_##_field##_INDEX, \ + _reg##_##_field##_WIDTH, (_val)); \ + AXGMAC_MTL_IOWRITE((_pdata), (_n), _reg, reg_val); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_n' - possible side-effects? #1834: FILE: drivers/net/axgbe/axgbe_common.h:1597: +#define AXGMAC_MTL_IOWRITE_BITS(_pdata, _n, _reg, _field, _val) \ +do { \ + u32 reg_val = AXGMAC_MTL_IOREAD((_pdata), (_n), _reg); \ + SET_BITS(reg_val, \ + _reg##_##_field##_INDEX, \ + _reg##_##_field##_WIDTH, (_val)); \ + AXGMAC_MTL_IOWRITE((_pdata), (_n), _reg, reg_val); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects? #1834: FILE: drivers/net/axgbe/axgbe_common.h:1597: +#define AXGMAC_MTL_IOWRITE_BITS(_pdata, _n, _reg, _field, _val) \ +do { \ + u32 reg_val = AXGMAC_MTL_IOREAD((_pdata), (_n), _reg); \ + SET_BITS(reg_val, \ + _reg##_##_field##_INDEX, \ + _reg##_##_field##_WIDTH, (_val)); \ + AXGMAC_MTL_IOWRITE((_pdata), (_n), _reg, reg_val); \ +} while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_reg' may be better as '(_reg)' to avoid precedence issues #1847: FILE: drivers/net/axgbe/axgbe_common.h:1610: +#define AXGMAC_DMA_IOREAD(_channel, _reg) \ + ioread32((_channel)->dma_regs + _reg) CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_reg' may be better as '(_reg)' to avoid precedence issues #1855: FILE: drivers/net/axgbe/axgbe_common.h:1618: +#define AXGMAC_DMA_IOWRITE(_channel, _reg, _val) \ + iowrite32((_val), (_channel)->dma_regs + _reg) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_channel' - possible side-effects? #1858: FILE: drivers/net/axgbe/axgbe_common.h:1621: +#define AXGMAC_DMA_IOWRITE_BITS(_channel, _reg, _field, _val) \ +do { \ + u32 reg_val = AXGMAC_DMA_IOREAD((_channel), _reg); \ + SET_BITS(reg_val, \ + _reg##_##_field##_INDEX, \ + _reg##_##_field##_WIDTH, (_val)); \ + AXGMAC_DMA_IOWRITE((_channel), _reg, reg_val); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects? #1858: FILE: drivers/net/axgbe/axgbe_common.h:1621: +#define AXGMAC_DMA_IOWRITE_BITS(_channel, _reg, _field, _val) \ +do { \ + u32 reg_val = AXGMAC_DMA_IOREAD((_channel), _reg); \ + SET_BITS(reg_val, \ + _reg##_##_field##_INDEX, \ + _reg##_##_field##_WIDTH, (_val)); \ + AXGMAC_DMA_IOWRITE((_channel), _reg, reg_val); \ +} while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_reg' may be better as '(_reg)' to avoid precedence issues #1905: FILE: drivers/net/axgbe/axgbe_common.h:1668: +#define XSIR0_IOREAD(_pdata, _reg) \ + ioread16((_pdata)->sir0_regs + _reg) CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_reg' may be better as '(_reg)' to avoid precedence issues #1913: FILE: drivers/net/axgbe/axgbe_common.h:1676: +#define XSIR0_IOWRITE(_pdata, _reg, _val) \ + iowrite16((_val), (_pdata)->sir0_regs + _reg) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects? #1916: FILE: drivers/net/axgbe/axgbe_common.h:1679: +#define XSIR0_IOWRITE_BITS(_pdata, _reg, _field, _val) \ +do { \ + u16 reg_val = XSIR0_IOREAD((_pdata), _reg); \ + SET_BITS(reg_val, \ + _reg##_##_field##_INDEX, \ + _reg##_##_field##_WIDTH, (_val)); \ + XSIR0_IOWRITE((_pdata), _reg, reg_val); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects? #1916: FILE: drivers/net/axgbe/axgbe_common.h:1679: +#define XSIR0_IOWRITE_BITS(_pdata, _reg, _field, _val) \ +do { \ + u16 reg_val = XSIR0_IOREAD((_pdata), _reg); \ + SET_BITS(reg_val, \ + _reg##_##_field##_INDEX, \ + _reg##_##_field##_WIDTH, (_val)); \ + XSIR0_IOWRITE((_pdata), _reg, reg_val); \ +} while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_reg' may be better as '(_reg)' to avoid precedence issues #1925: FILE: drivers/net/axgbe/axgbe_common.h:1688: +#define XSIR1_IOREAD(_pdata, _reg) \ + ioread16((_pdata)->sir1_regs + _reg) CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_reg' may be better as '(_reg)' to avoid precedence issues #1933: FILE: drivers/net/axgbe/axgbe_common.h:1696: +#define XSIR1_IOWRITE(_pdata, _reg, _val) \ + iowrite16((_val), (_pdata)->sir1_regs + _reg) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects? #1936: FILE: drivers/net/axgbe/axgbe_common.h:1699: +#define XSIR1_IOWRITE_BITS(_pdata, _reg, _field, _val) \ +do { \ + u16 reg_val = XSIR1_IOREAD((_pdata), _reg); \ + SET_BITS(reg_val, \ + _reg##_##_field##_INDEX, \ + _reg##_##_field##_WIDTH, (_val)); \ + XSIR1_IOWRITE((_pdata), _reg, reg_val); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects? #1936: FILE: drivers/net/axgbe/axgbe_common.h:1699: +#define XSIR1_IOWRITE_BITS(_pdata, _reg, _field, _val) \ +do { \ + u16 reg_val = XSIR1_IOREAD((_pdata), _reg); \ + SET_BITS(reg_val, \ + _reg##_##_field##_INDEX, \ + _reg##_##_field##_WIDTH, (_val)); \ + XSIR1_IOWRITE((_pdata), _reg, reg_val); \ +} while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_reg' may be better as '(_reg)' to avoid precedence issues #1948: FILE: drivers/net/axgbe/axgbe_common.h:1711: +#define XRXTX_IOREAD(_pdata, _reg) \ + ioread16((_pdata)->rxtx_regs + _reg) CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_reg' may be better as '(_reg)' to avoid precedence issues #1956: FILE: drivers/net/axgbe/axgbe_common.h:1719: +#define XRXTX_IOWRITE(_pdata, _reg, _val) \ + iowrite16((_val), (_pdata)->rxtx_regs + _reg) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects? #1959: FILE: drivers/net/axgbe/axgbe_common.h:1722: +#define XRXTX_IOWRITE_BITS(_pdata, _reg, _field, _val) \ +do { \ + u16 reg_val = XRXTX_IOREAD((_pdata), _reg); \ + SET_BITS(reg_val, \ + _reg##_##_field##_INDEX, \ + _reg##_##_field##_WIDTH, (_val)); \ + XRXTX_IOWRITE((_pdata), _reg, reg_val); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects? #1959: FILE: drivers/net/axgbe/axgbe_common.h:1722: +#define XRXTX_IOWRITE_BITS(_pdata, _reg, _field, _val) \ +do { \ + u16 reg_val = XRXTX_IOREAD((_pdata), _reg); \ + SET_BITS(reg_val, \ + _reg##_##_field##_INDEX, \ + _reg##_##_field##_WIDTH, (_val)); \ + XRXTX_IOWRITE((_pdata), _reg, reg_val); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects? #1992: FILE: drivers/net/axgbe/axgbe_common.h:1755: +#define XP_IOWRITE_BITS(_pdata, _reg, _field, _val) \ +do { \ + u32 reg_val = XP_IOREAD((_pdata), (_reg)); \ + SET_BITS(reg_val, \ + _reg##_##_field##_INDEX, \ + _reg##_##_field##_WIDTH, (_val)); \ + XP_IOWRITE((_pdata), (_reg), reg_val); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects? #1992: FILE: drivers/net/axgbe/axgbe_common.h:1755: +#define XP_IOWRITE_BITS(_pdata, _reg, _field, _val) \ +do { \ + u32 reg_val = XP_IOREAD((_pdata), (_reg)); \ + SET_BITS(reg_val, \ + _reg##_##_field##_INDEX, \ + _reg##_##_field##_WIDTH, (_val)); \ + XP_IOWRITE((_pdata), (_reg), reg_val); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects? #2025: FILE: drivers/net/axgbe/axgbe_common.h:1788: +#define XI2C_IOWRITE_BITS(_pdata, _reg, _field, _val) \ +do { \ + u32 reg_val = XI2C_IOREAD((_pdata), (_reg)); \ + SET_BITS(reg_val, \ + _reg##_##_field##_INDEX, \ + _reg##_##_field##_WIDTH, (_val)); \ + XI2C_IOWRITE((_pdata), (_reg), reg_val); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects? #2025: FILE: drivers/net/axgbe/axgbe_common.h:1788: +#define XI2C_IOWRITE_BITS(_pdata, _reg, _field, _val) \ +do { \ + u32 reg_val = XI2C_IOREAD((_pdata), (_reg)); \ + SET_BITS(reg_val, \ + _reg##_##_field##_INDEX, \ + _reg##_##_field##_WIDTH, (_val)); \ + XI2C_IOWRITE((_pdata), (_reg), reg_val); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects? #2039: FILE: drivers/net/axgbe/axgbe_common.h:1802: +#define XMDIO_READ(_pdata, _mmd, _reg) \ + ((_pdata)->hw_if.read_mmd_regs((_pdata), 0, \ + MII_ADDR_C45 | (_mmd << 16) | ((_reg) & 0xffff))) CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_mmd' may be better as '(_mmd)' to avoid precedence issues #2039: FILE: drivers/net/axgbe/axgbe_common.h:1802: +#define XMDIO_READ(_pdata, _mmd, _reg) \ + ((_pdata)->hw_if.read_mmd_regs((_pdata), 0, \ + MII_ADDR_C45 | (_mmd << 16) | ((_reg) & 0xffff))) CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_mask' may be better as '(_mask)' to avoid precedence issues #2043: FILE: drivers/net/axgbe/axgbe_common.h:1806: +#define XMDIO_READ_BITS(_pdata, _mmd, _reg, _mask) \ + (XMDIO_READ((_pdata), _mmd, _reg) & _mask) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects? #2046: FILE: drivers/net/axgbe/axgbe_common.h:1809: +#define XMDIO_WRITE(_pdata, _mmd, _reg, _val) \ + ((_pdata)->hw_if.write_mmd_regs((_pdata), 0, \ + MII_ADDR_C45 | (_mmd << 16) | ((_reg) & 0xffff), (_val))) CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_mmd' may be better as '(_mmd)' to avoid precedence issues #2046: FILE: drivers/net/axgbe/axgbe_common.h:1809: +#define XMDIO_WRITE(_pdata, _mmd, _reg, _val) \ + ((_pdata)->hw_if.write_mmd_regs((_pdata), 0, \ + MII_ADDR_C45 | (_mmd << 16) | ((_reg) & 0xffff), (_val))) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_pdata' - possible side-effects? #2050: FILE: drivers/net/axgbe/axgbe_common.h:1813: +#define XMDIO_WRITE_BITS(_pdata, _mmd, _reg, _mask, _val) \ +do { \ + u32 mmd_val = XMDIO_READ((_pdata), _mmd, _reg); \ + mmd_val &= ~_mask; \ + mmd_val |= (_val); \ + XMDIO_WRITE((_pdata), _mmd, _reg, mmd_val); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_mmd' - possible side-effects? #2050: FILE: drivers/net/axgbe/axgbe_common.h:1813: +#define XMDIO_WRITE_BITS(_pdata, _mmd, _reg, _mask, _val) \ +do { \ + u32 mmd_val = XMDIO_READ((_pdata), _mmd, _reg); \ + mmd_val &= ~_mask; \ + mmd_val |= (_val); \ + XMDIO_WRITE((_pdata), _mmd, _reg, mmd_val); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_reg' - possible side-effects? #2050: FILE: drivers/net/axgbe/axgbe_common.h:1813: +#define XMDIO_WRITE_BITS(_pdata, _mmd, _reg, _mask, _val) \ +do { \ + u32 mmd_val = XMDIO_READ((_pdata), _mmd, _reg); \ + mmd_val &= ~_mask; \ + mmd_val |= (_val); \ + XMDIO_WRITE((_pdata), _mmd, _reg, mmd_val); \ +} while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_mask' may be better as '(_mask)' to avoid precedence issues #2050: FILE: drivers/net/axgbe/axgbe_common.h:1813: +#define XMDIO_WRITE_BITS(_pdata, _mmd, _reg, _mask, _val) \ +do { \ + u32 mmd_val = XMDIO_READ((_pdata), _mmd, _reg); \ + mmd_val &= ~_mask; \ + mmd_val |= (_val); \ + XMDIO_WRITE((_pdata), _mmd, _reg, mmd_val); \ +} while (0) WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2182: FILE: drivers/net/axgbe/axgbe_dev.c:72: + * ^Inotice, this list of conditions and the following disclaimer.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2184: FILE: drivers/net/axgbe/axgbe_dev.c:74: + * ^Inotice, this list of conditions and the following disclaimer in the$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2185: FILE: drivers/net/axgbe/axgbe_dev.c:75: + * ^Idocumentation and/or other materials provided with the distribution.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2187: FILE: drivers/net/axgbe/axgbe_dev.c:77: + * ^Inames of its contributors may be used to endorse or promote products$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2188: FILE: drivers/net/axgbe/axgbe_dev.c:78: + * ^Iderived from this software without specific prior written permission.$ CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #3003: FILE: drivers/net/axgbe/axgbe_dev.c:893: + + } WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #3026: FILE: drivers/net/axgbe/axgbe_dev.c:916: + (unsigned)rxq->queue_id, j); WARNING:SPACE_BEFORE_TAB: please, no space before tabs #3410: FILE: drivers/net/axgbe/axgbe_ethdev.c:72: + * ^Inotice, this list of conditions and the following disclaimer.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #3412: FILE: drivers/net/axgbe/axgbe_ethdev.c:74: + * ^Inotice, this list of conditions and the following disclaimer in the$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #3413: FILE: drivers/net/axgbe/axgbe_ethdev.c:75: + * ^Idocumentation and/or other materials provided with the distribution.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #3415: FILE: drivers/net/axgbe/axgbe_ethdev.c:77: + * ^Inames of its contributors may be used to endorse or promote products$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #3416: FILE: drivers/net/axgbe/axgbe_ethdev.c:78: + * ^Iderived from this software without specific prior written permission.$ WARNING:LONG_LINE: line over 90 characters #3587: FILE: drivers/net/axgbe/axgbe_ethdev.c:249: + dma_ch_isr = AXGMAC_DMA_IOREAD((struct axgbe_rx_queue *)pdata->rx_queues[0], WARNING:SPACE_BEFORE_TAB: please, no space before tabs #4300: FILE: drivers/net/axgbe/axgbe_ethdev.h:72: + * ^Inotice, this list of conditions and the following disclaimer.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #4302: FILE: drivers/net/axgbe/axgbe_ethdev.h:74: + * ^Inotice, this list of conditions and the following disclaimer in the$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #4303: FILE: drivers/net/axgbe/axgbe_ethdev.h:75: + * ^Idocumentation and/or other materials provided with the distribution.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #4305: FILE: drivers/net/axgbe/axgbe_ethdev.h:77: + * ^Inames of its contributors may be used to endorse or promote products$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #4306: FILE: drivers/net/axgbe/axgbe_ethdev.h:78: + * ^Iderived from this software without specific prior written permission.$ CHECK:MACRO_ARG_REUSE: Macro argument reuse '_x' - possible side-effects? #4431: FILE: drivers/net/axgbe/axgbe_ethdev.h:203: +#define AXGMAC_FLOW_CONTROL_VALUE(_x) \ + (((_x) < 1024) ? 0 : ((_x) / AXGMAC_FLOW_CONTROL_UNIT) - 2) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_ring' - possible side-effects? #4474: FILE: drivers/net/axgbe/axgbe_ethdev.h:246: +#define AXGBE_GET_DESC_DATA(_ring, _idx) \ + ((_ring)->rdata + \ + ((_idx) & ((_ring)->rdesc_count - 1))) WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct axgbe_port *' should also have an identifier name #4712: FILE: drivers/net/axgbe/axgbe_ethdev.h:484: + unsigned int (*an_advertising)(struct axgbe_port *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct axgbe_hw_if *' should also have an identifier name #4954: FILE: drivers/net/axgbe/axgbe_ethdev.h:726: +void axgbe_init_function_ptrs_dev(struct axgbe_hw_if *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct axgbe_phy_if *' should also have an identifier name #4955: FILE: drivers/net/axgbe/axgbe_ethdev.h:727: +void axgbe_init_function_ptrs_phy(struct axgbe_phy_if *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct axgbe_phy_if *' should also have an identifier name #4956: FILE: drivers/net/axgbe/axgbe_ethdev.h:728: +void axgbe_init_function_ptrs_phy_v2(struct axgbe_phy_if *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct axgbe_i2c_if *' should also have an identifier name #4957: FILE: drivers/net/axgbe/axgbe_ethdev.h:729: +void axgbe_init_function_ptrs_i2c(struct axgbe_i2c_if *); WARNING:SPACE_BEFORE_TAB: please, no space before tabs #5037: FILE: drivers/net/axgbe/axgbe_i2c.c:72: + * ^Inotice, this list of conditions and the following disclaimer.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #5039: FILE: drivers/net/axgbe/axgbe_i2c.c:74: + * ^Inotice, this list of conditions and the following disclaimer in the$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #5040: FILE: drivers/net/axgbe/axgbe_i2c.c:75: + * ^Idocumentation and/or other materials provided with the distribution.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #5042: FILE: drivers/net/axgbe/axgbe_i2c.c:77: + * ^Inames of its contributors may be used to endorse or promote products$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #5043: FILE: drivers/net/axgbe/axgbe_i2c.c:78: + * ^Iderived from this software without specific prior written permission.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #5495: FILE: drivers/net/axgbe/axgbe_logs.h:72: + * ^Inotice, this list of conditions and the following disclaimer.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #5497: FILE: drivers/net/axgbe/axgbe_logs.h:74: + * ^Inotice, this list of conditions and the following disclaimer in the$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #5498: FILE: drivers/net/axgbe/axgbe_logs.h:75: + * ^Idocumentation and/or other materials provided with the distribution.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #5500: FILE: drivers/net/axgbe/axgbe_logs.h:77: + * ^Inames of its contributors may be used to endorse or promote products$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #5501: FILE: drivers/net/axgbe/axgbe_logs.h:78: + * ^Iderived from this software without specific prior written permission.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #5645: FILE: drivers/net/axgbe/axgbe_mdio.c:72: + * ^Inotice, this list of conditions and the following disclaimer.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #5647: FILE: drivers/net/axgbe/axgbe_mdio.c:74: + * ^Inotice, this list of conditions and the following disclaimer in the$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #5648: FILE: drivers/net/axgbe/axgbe_mdio.c:75: + * ^Idocumentation and/or other materials provided with the distribution.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #5650: FILE: drivers/net/axgbe/axgbe_mdio.c:77: + * ^Inames of its contributors may be used to endorse or promote products$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #5651: FILE: drivers/net/axgbe/axgbe_mdio.c:78: + * ^Iderived from this software without specific prior written permission.$ CHECK:CAMELCASE: Avoid CamelCase: #6163: FILE: drivers/net/axgbe/axgbe_mdio.c:590: + if (!(pdata->phy.advertising & ADVERTISED_1000baseKX_Full) && CHECK:CAMELCASE: Avoid CamelCase: #6164: FILE: drivers/net/axgbe/axgbe_mdio.c:591: + !(pdata->phy.advertising & ADVERTISED_2500baseX_Full)) CHECK:CAMELCASE: Avoid CamelCase: #6172: FILE: drivers/net/axgbe/axgbe_mdio.c:599: + if (!(pdata->phy.advertising & ADVERTISED_10000baseKR_Full)) CHECK:CAMELCASE: Avoid CamelCase: #6310: FILE: drivers/net/axgbe/axgbe_mdio.c:737: + if (advertising & ADVERTISED_10000baseR_FEC) CHECK:CAMELCASE: Avoid CamelCase: #6334: FILE: drivers/net/axgbe/axgbe_mdio.c:761: + if (advertising & ADVERTISED_Pause) CHECK:CAMELCASE: Avoid CamelCase: #6339: FILE: drivers/net/axgbe/axgbe_mdio.c:766: + if (advertising & ADVERTISED_Asym_Pause) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #6374: FILE: drivers/net/axgbe/axgbe_mdio.c:801: + if (pdata->tx_pause != (unsigned)pdata->phy.tx_pause) { WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #6379: FILE: drivers/net/axgbe/axgbe_mdio.c:806: + if (pdata->rx_pause != (unsigned)pdata->phy.rx_pause) { CHECK:CAMELCASE: Avoid CamelCase: #6678: FILE: drivers/net/axgbe/axgbe_mdio.c:1105: + else if (pdata->phy.advertising & ADVERTISED_10000baseT_Full) CHECK:CAMELCASE: Avoid CamelCase: #6684: FILE: drivers/net/axgbe/axgbe_mdio.c:1111: + else if (pdata->phy.advertising & ADVERTISED_1000baseT_Full) CHECK:CAMELCASE: Avoid CamelCase: #6686: FILE: drivers/net/axgbe/axgbe_mdio.c:1113: + else if (pdata->phy.advertising & ADVERTISED_100baseT_Full) CHECK:CAMELCASE: Avoid CamelCase: #6712: FILE: drivers/net/axgbe/axgbe_mdio.c:1139: + if (pdata->phy.advertising & ADVERTISED_Autoneg) { WARNING:SPACE_BEFORE_TAB: please, no space before tabs #6829: FILE: drivers/net/axgbe/axgbe_phy.h:72: + * ^Inotice, this list of conditions and the following disclaimer.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #6831: FILE: drivers/net/axgbe/axgbe_phy.h:74: + * ^Inotice, this list of conditions and the following disclaimer in the$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #6832: FILE: drivers/net/axgbe/axgbe_phy.h:75: + * ^Idocumentation and/or other materials provided with the distribution.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #6834: FILE: drivers/net/axgbe/axgbe_phy.h:77: + * ^Inames of its contributors may be used to endorse or promote products$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #6835: FILE: drivers/net/axgbe/axgbe_phy.h:78: + * ^Iderived from this software without specific prior written permission.$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #6895: FILE: drivers/net/axgbe/axgbe_phy.h:138: +/* Or MII_ADDR_C45 into regnum for read/write on mii_bus to enable the 21 bit + IEEE 802.3ae clause 45 addressing mode used by 10GIGE phy chips. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #6895: FILE: drivers/net/axgbe/axgbe_phy.h:138: + IEEE 802.3ae clause 45 addressing mode used by 10GIGE phy chips. */ CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #6896: FILE: drivers/net/axgbe/axgbe_phy.h:139: +#define MII_ADDR_C45 (1<<30) ^ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #6946: FILE: drivers/net/axgbe/axgbe_phy.h:189: + * Physical Medium Dependent */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #6984: FILE: drivers/net/axgbe/axgbe_phy.h:227: + * Lanes B-D are numbered 134-136. */ CHECK:CAMELCASE: Avoid CamelCase: #7021: FILE: drivers/net/axgbe/axgbe_phy.h:264: +#define SUPPORTED_Autoneg (1 << 6) CHECK:CAMELCASE: Avoid CamelCase: #7028: FILE: drivers/net/axgbe/axgbe_phy.h:271: +#define SUPPORTED_Pause (1 << 13) CHECK:CAMELCASE: Avoid CamelCase: #7029: FILE: drivers/net/axgbe/axgbe_phy.h:272: +#define SUPPORTED_Asym_Pause (1 << 14) CHECK:CAMELCASE: Avoid CamelCase: #7031: FILE: drivers/net/axgbe/axgbe_phy.h:274: +#define SUPPORTED_Backplane (1 << 16) CHECK:CAMELCASE: Avoid CamelCase: #7036: FILE: drivers/net/axgbe/axgbe_phy.h:279: +#define SUPPORTED_10000baseR_FEC (1 << 20) CHECK:CAMELCASE: Avoid CamelCase: #7048: FILE: drivers/net/axgbe/axgbe_phy.h:291: +#define ADVERTISED_Backplane (1 << 16) CHECK:CAMELCASE: Avoid CamelCase: #7050: FILE: drivers/net/axgbe/axgbe_phy.h:293: +#define SUPPORTED_1000baseKX_Full (1 << 17) CHECK:CAMELCASE: Avoid CamelCase: #7051: FILE: drivers/net/axgbe/axgbe_phy.h:294: +#define SUPPORTED_10000baseKR_Full (1 << 19) CHECK:CAMELCASE: Avoid CamelCase: #7052: FILE: drivers/net/axgbe/axgbe_phy.h:295: +#define SUPPORTED_2500baseX_Full (1 << 15) CHECK:CAMELCASE: Avoid CamelCase: #7053: FILE: drivers/net/axgbe/axgbe_phy.h:296: +#define SUPPORTED_100baseT_Full (1 << 2) CHECK:CAMELCASE: Avoid CamelCase: #7054: FILE: drivers/net/axgbe/axgbe_phy.h:297: +#define SUPPORTED_1000baseT_Full (1 << 5) CHECK:CAMELCASE: Avoid CamelCase: #7055: FILE: drivers/net/axgbe/axgbe_phy.h:298: +#define SUPPORTED_10000baseT_Full (1 << 12) WARNING:SPACE_BEFORE_TAB: please, no space before tabs #7145: FILE: drivers/net/axgbe/axgbe_phy_impl.c:72: + * ^Inotice, this list of conditions and the following disclaimer.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #7147: FILE: drivers/net/axgbe/axgbe_phy_impl.c:74: + * ^Inotice, this list of conditions and the following disclaimer in the$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #7148: FILE: drivers/net/axgbe/axgbe_phy_impl.c:75: + * ^Idocumentation and/or other materials provided with the distribution.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #7150: FILE: drivers/net/axgbe/axgbe_phy_impl.c:77: + * ^Inames of its contributors may be used to endorse or promote products$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #7151: FILE: drivers/net/axgbe/axgbe_phy_impl.c:78: + * ^Iderived from this software without specific prior written permission.$ CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #8371: FILE: drivers/net/axgbe/axgbe_phy_impl.c:1298: + +} WARNING:SPACE_BEFORE_TAB: please, no space before tabs #9346: FILE: drivers/net/axgbe/axgbe_rxtx.c:72: + * ^Inotice, this list of conditions and the following disclaimer.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #9348: FILE: drivers/net/axgbe/axgbe_rxtx.c:74: + * ^Inotice, this list of conditions and the following disclaimer in the$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #9349: FILE: drivers/net/axgbe/axgbe_rxtx.c:75: + * ^Idocumentation and/or other materials provided with the distribution.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #9351: FILE: drivers/net/axgbe/axgbe_rxtx.c:77: + * ^Inames of its contributors may be used to endorse or promote products$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #9352: FILE: drivers/net/axgbe/axgbe_rxtx.c:78: + * ^Iderived from this software without specific prior written permission.$ CHECK:SPACING: No space is necessary after a cast #9495: FILE: drivers/net/axgbe/axgbe_rxtx.c:221: + rxq->desc = (volatile union axgbe_rx_desc *) dma->addr; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #9623: FILE: drivers/net/axgbe/axgbe_rxtx.c:349: + "queue_id=%u ", (unsigned)rxq->port_id, WARNING:MISSING_SPACE: break quoted strings at a space character #9623: FILE: drivers/net/axgbe/axgbe_rxtx.c:349: + PMD_DRV_LOG(ERR, "RX mbuf alloc failed port_id=%u" + "queue_id=%u ", (unsigned)rxq->port_id, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #9624: FILE: drivers/net/axgbe/axgbe_rxtx.c:350: + (unsigned)rxq->queue_id); WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #9645: FILE: drivers/net/axgbe/axgbe_rxtx.c:371: + * if partial packet error free the buffer */ CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #9670: FILE: drivers/net/axgbe/axgbe_rxtx.c:396: + mbuf->pkt_len = mbuf->data_len = pkt_len; CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #9722: FILE: drivers/net/axgbe/axgbe_rxtx.c:448: +{ + WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #9942: FILE: drivers/net/axgbe/axgbe_rxtx.c:668: + * mbuf is linear */ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #10134: FILE: drivers/net/axgbe/axgbe_rxtx.h:72: + * ^Inotice, this list of conditions and the following disclaimer.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #10136: FILE: drivers/net/axgbe/axgbe_rxtx.h:74: + * ^Inotice, this list of conditions and the following disclaimer in the$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #10137: FILE: drivers/net/axgbe/axgbe_rxtx.h:75: + * ^Idocumentation and/or other materials provided with the distribution.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #10139: FILE: drivers/net/axgbe/axgbe_rxtx.h:77: + * ^Inames of its contributors may be used to endorse or promote products$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #10140: FILE: drivers/net/axgbe/axgbe_rxtx.h:78: + * ^Iderived from this software without specific prior written permission.$ WARNING:TYPO_SPELLING: 'supress' may be misspelled - perhaps 'suppress'? #10192: FILE: drivers/net/axgbe/axgbe_rxtx.h:130: +/* to supress gcc warnings related to descriptor casting*/ CHECK:MACRO_ARG_REUSE: Macro argument reuse '_queue' - possible side-effects? #10214: FILE: drivers/net/axgbe/axgbe_rxtx.h:152: +#define AXGBE_GET_DESC_PT(_queue, _idx) \ + (((_queue)->desc) + \ + ((_idx) & ((_queue)->nb_desc - 1))) WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #10289: FILE: drivers/net/axgbe/axgbe_rxtx.h:227: + /* Start freeing TX buffers if there are less free descriptors than + this value */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #10289: FILE: drivers/net/axgbe/axgbe_rxtx.h:227: + this value */ WARNING:TYPO_SPELLING: 'trasmission' may be misspelled - perhaps 'transmission'? #10312: FILE: drivers/net/axgbe/axgbe_rxtx.h:250: + after trasmission conform*/ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #10312: FILE: drivers/net/axgbe/axgbe_rxtx.h:250: + /* Reference to hold Tx mbufs mapped to Tx descriptors freed + after trasmission conform*/ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #10312: FILE: drivers/net/axgbe/axgbe_rxtx.h:250: + after trasmission conform*/ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #10439: FILE: drivers/net/axgbe/axgbe_rxtx_vec.c:72: + * ^Inotice, this list of conditions and the following disclaimer.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #10441: FILE: drivers/net/axgbe/axgbe_rxtx_vec.c:74: + * ^Inotice, this list of conditions and the following disclaimer in the$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #10442: FILE: drivers/net/axgbe/axgbe_rxtx_vec.c:75: + * ^Idocumentation and/or other materials provided with the distribution.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #10444: FILE: drivers/net/axgbe/axgbe_rxtx_vec.c:77: + * ^Inames of its contributors may be used to endorse or promote products$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #10445: FILE: drivers/net/axgbe/axgbe_rxtx_vec.c:78: + * ^Iderived from this software without specific prior written permission.$ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #10529: FILE: drivers/net/axgbe/axgbe_rxtx_vec.c:162: + * all 128 bits are populated */ CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #10554: FILE: drivers/net/axgbe/axgbe_rxtx_vec.c:187: + nb_commit = nb_pkts = RTE_MIN(txq->nb_desc_free, nb_pkts); total: 0 errors, 86 warnings, 77 checks, 10454 lines checked