From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
Subject: [dpdk-test-report] |WARNING| pw28829 [PATCH v2 11/14] pci: avoid inlining functions
Date: Mon, 18 Sep 2017 11:34:02 +0200 (CEST) [thread overview]
Message-ID: <20170918093402.D34921B1A4@dpdk.org> (raw)
In-Reply-To: <9a81e98be6044d4f1da6d8e38b17bea221d0aed5.1505726803.git.gaetan.rivet@6wind.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28829
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#142: FILE: lib/librte_pci/rte_pci.c:57:
+#define GET_PCIADDR_FIELD(in, fd, lim, dlm) \
+do { \
+ unsigned long val; \
+ char *end; \
+ errno = 0; \
+ val = strtoul((in), &end, 16); \
+ if (errno != 0 || end[0] != (dlm) || val > (lim)) \
+ return -EINVAL; \
+ (fd) = (typeof (fd))val; \
+ (in) = end + 1; \
+} while(0)
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#150: FILE: lib/librte_pci/rte_pci.c:65:
+ (fd) = (typeof (fd))val; \
ERROR:SPACING: space required before the open parenthesis '('
#152: FILE: lib/librte_pci/rte_pci.c:67:
+} while(0)
total: 1 errors, 2 warnings, 183 lines checked
parent reply other threads:[~2017-09-18 9:34 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <9a81e98be6044d4f1da6d8e38b17bea221d0aed5.1505726803.git.gaetan.rivet@6wind.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918093402.D34921B1A4@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).