* [dpdk-test-report] |WARNING| pw28830 [PATCH v2 05/14] pci: introduce PCI lib and bus
[not found] <618e47fbcfbc9ead4c009f0456faab563f22a426.1505726803.git.gaetan.rivet@6wind.com>
@ 2017-09-18 9:34 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-09-18 9:34 UTC (permalink / raw)
To: test-report; +Cc: Gaetan Rivet
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28830
_coding style issues_
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#325: FILE: drivers/bus/pci/bsd/rte_pci.c:88:
+extern struct rte_pci_bus rte_pci_bus;
WARNING:LONG_LINE: line over 90 characters
#393: FILE: drivers/bus/pci/bsd/rte_pci.c:156:
+ "skipping
", loc->domain, loc->bus, loc->devid, loc->function);
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#484: FILE: drivers/bus/pci/bsd/rte_pci.c:247:
+ unsigned i, max;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#487: FILE: drivers/bus/pci/bsd/rte_pci.c:250:
+ if (dev == NULL) {
+ return -1;
+ }
WARNING:LONG_LINE: line over 90 characters
#548: FILE: drivers/bus/pci/bsd/rte_pci.c:311:
+ dev->mem_resource[i].addr = (void *)(bar.pbi_base & ~((uint64_t)0xf));
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#558: FILE: drivers/bus/pci/bsd/rte_pci.c:321:
+ }
+ else {
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#597: FILE: drivers/bus/pci/bsd/rte_pci.c:360:
+ unsigned dev_count = 0;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#618: FILE: drivers/bus/pci/bsd/rte_pci.c:381:
+ unsigned i;
ERROR:SPACING: space required before the open parenthesis '('
#630: FILE: drivers/bus/pci/bsd/rte_pci.c:393:
+ } while(conf_io.status == PCI_GETCONF_MORE_DEVS);
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1027: FILE: drivers/bus/pci/include/rte_bus_pci.h:114:
+#define RTE_PCI_DEVICE(vend, dev) \
+ RTE_CLASS_ANY_ID, \
+ (vend), \
+ (dev), \
+ PCI_ANY_ID, \
+ PCI_ANY_ID
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#1407: FILE: drivers/bus/pci/linux/rte_pci.c:58:
+extern struct rte_pci_bus rte_pci_bus;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1498: FILE: drivers/bus/pci/linux/rte_pci.c:149:
+ unsigned i = 0;
ERROR:SPACING: spaces required around that '<' (ctx:VxV)
#1560: FILE: drivers/bus/pci/linux/rte_pci.c:211:
+ for (i = 0; i<PCI_MAX_RESOURCE; i++) {
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#1774: FILE: drivers/bus/pci/linux/rte_pci.c:425:
+ splitaddr.function = strchr(splitaddr.devid,'.');
^
WARNING:NAKED_SSCANF: unchecked sscanf return value
#1929: FILE: drivers/bus/pci/linux/rte_pci.c:580:
+ sscanf(ptr, "%04hx-%04hx", &start, &end);
ERROR:CODE_INDENT: code indent should use tabs where possible
#2161: FILE: drivers/bus/pci/linux/rte_pci_init.h:84:
+^I^I struct rte_pci_ioport *p);$
ERROR:GLOBAL_INITIALISERS: do not initialise globals to NULL
#2237: FILE: drivers/bus/pci/linux/rte_pci_uio.c:57:
+void *pci_map_addr = NULL;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2285: FILE: drivers/bus/pci/linux/rte_pci_uio.c:105:
+pci_mknod_uio_dev(const char *sysfs_uio_path, unsigned uio_num)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2290: FILE: drivers/bus/pci/linux/rte_pci_uio.c:110:
+ unsigned major, minor;
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#2294: FILE: drivers/bus/pci/linux/rte_pci_uio.c:114:
+ * of the uio device and read its content */
WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'.
#2316: FILE: drivers/bus/pci/linux/rte_pci_uio.c:136:
+ ret = mknod(filename, S_IFCHR | S_IRUSR | S_IWUSR, dev);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#2343: FILE: drivers/bus/pci/linux/rte_pci_uio.c:163:
+ * or uio:uioX */
WARNING:LONG_LINE: line over 90 characters
#2437: FILE: drivers/bus/pci/linux/rte_pci_uio.c:257:
+ "skipping
", loc->domain, loc->bus, loc->devid, loc->function);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#2577: FILE: drivers/bus/pci/linux/rte_pci_uio.c:397:
+ * uin16_t */
WARNING:LONG_LINE: line over 90 characters
#2883: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:130:
+ VFIO_GET_REGION_ADDR(VFIO_PCI_CONFIG_REGION_INDEX) +
WARNING:LONG_LINE: line over 90 characters
#2900: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:147:
+ VFIO_GET_REGION_ADDR(VFIO_PCI_CONFIG_REGION_INDEX) +
WARNING:LONG_LINE: line over 90 characters
#2909: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:156:
+ VFIO_GET_REGION_ADDR(VFIO_PCI_CONFIG_REGION_INDEX) +
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#3010: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:257:
+ * specified interrupt type, otherwise continue */
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#3016: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:263:
+ return -1;
+ } else
WARNING:LONG_LINE: line over 90 characters
#3069: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:316:
+ struct mapped_pci_res_list *vfio_res_list = RTE_TAILQ_CAST(rte_vfio_tailq.head, mapped_pci_res_list);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3083: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:330:
+ if ((ret = vfio_setup_device(pci_get_sysfs_path(), pci_addr,
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#3088: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:335:
+ * easily mmap it when using VFIO) */
WARNING:LONG_LINE: line over 90 characters
#3145: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:392:
+ "error %i (%s)
", pci_addr, errno, strerror(errno));
WARNING:LONG_LINE: line over 90 characters
#3271: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:518:
+ RTE_LOG(ERR, EAL, " %s error setting up interrupts!
", pci_addr);
WARNING:LONG_LINE: line over 90 characters
#3279: FILE: drivers/bus/pci/linux/rte_pci_vfio.c:526:
+ RTE_LOG(ERR, EAL, " %s cannot set up bus mastering!
", pci_addr);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#4127: FILE: drivers/bus/pci/rte_pci_common.c:58:
+extern struct rte_pci_bus rte_pci_bus;
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#9813: FILE: lib/librte_pci/include/rte_pci.h:130:
+#define GET_PCIADDR_FIELD(in, fd, lim, dlm) \
+do { \
+ unsigned long val; \
+ char *end; \
+ errno = 0; \
+ val = strtoul((in), &end, 16); \
+ if (errno != 0 || end[0] != (dlm) || val > (lim)) \
+ return -EINVAL; \
+ (fd) = (typeof (fd))val; \
+ (in) = end + 1; \
+} while(0)
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#9821: FILE: lib/librte_pci/include/rte_pci.h:138:
+ (fd) = (typeof (fd))val; \
ERROR:SPACING: space required before the open parenthesis '('
#9823: FILE: lib/librte_pci/include/rte_pci.h:140:
+} while(0)
total: 9 errors, 30 warnings, 5225 lines checked
^ permalink raw reply [flat|nested] only message in thread