From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Rasesh Mody <rasesh.mody@cavium.com>
Subject: [dpdk-test-report] |WARNING| pw28904 [PATCH 29/53] net/qede/base: fix macros to check chip revision/metal
Date: Tue, 19 Sep 2017 03:38:14 +0200 (CEST) [thread overview]
Message-ID: <20170919013814.EA60D592B@dpdk.org> (raw)
In-Reply-To: <1505784633-1171-30-git-send-email-rasesh.mody@cavium.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28904
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_dev' - possible side-effects?
#73: FILE: drivers/net/qede/base/ecore.h:693:
+#define CHIP_REV_IS_EMUL(_p_dev) \
+ (CHIP_REV_IS_EMUL_A0(_p_dev) || CHIP_REV_IS_EMUL_B0(_p_dev))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_dev' - possible side-effects?
#77: FILE: drivers/net/qede/base/ecore.h:697:
+#define CHIP_REV_IS_FPGA(_p_dev) \
+ (CHIP_REV_IS_FPGA_A0(_p_dev) || CHIP_REV_IS_FPGA_B0(_p_dev))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_dev' - possible side-effects?
#79: FILE: drivers/net/qede/base/ecore.h:699:
+#define CHIP_REV_IS_SLOW(_p_dev) \
+ (CHIP_REV_IS_EMUL(_p_dev) || CHIP_REV_IS_FPGA(_p_dev))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_dev' - possible side-effects?
#81: FILE: drivers/net/qede/base/ecore.h:701:
+#define CHIP_REV_IS_A0(_p_dev) \
+ (CHIP_REV_IS_EMUL_A0(_p_dev) || CHIP_REV_IS_FPGA_A0(_p_dev) || \
+ (!(_p_dev)->chip_rev && !(_p_dev)->chip_metal))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_dev' - possible side-effects?
#84: FILE: drivers/net/qede/base/ecore.h:704:
+#define CHIP_REV_IS_B0(_p_dev) \
+ (CHIP_REV_IS_EMUL_B0(_p_dev) || CHIP_REV_IS_FPGA_B0(_p_dev) || \
+ ((_p_dev)->chip_rev == 1 && !(_p_dev)->chip_metal))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_dev' - possible side-effects?
#91: FILE: drivers/net/qede/base/ecore.h:709:
+#define CHIP_REV_IS_A0(_p_dev) \
+ (!(_p_dev)->chip_rev && !(_p_dev)->chip_metal)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_dev' - possible side-effects?
#93: FILE: drivers/net/qede/base/ecore.h:711:
+#define CHIP_REV_IS_B0(_p_dev) \
+ ((_p_dev)->chip_rev == 1 && !(_p_dev)->chip_metal)
total: 0 errors, 0 warnings, 7 checks, 147 lines checked
parent reply other threads:[~2017-09-19 1:38 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1505784633-1171-30-git-send-email-rasesh.mody@cavium.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919013814.EA60D592B@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=rasesh.mody@cavium.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).