From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id EA60D592B; Tue, 19 Sep 2017 03:38:14 +0200 (CEST)
In-Reply-To: <1505784633-1171-30-git-send-email-rasesh.mody@cavium.com>
References: <1505784633-1171-30-git-send-email-rasesh.mody@cavium.com>
To: test-report@dpdk.org
Cc: Rasesh Mody <rasesh.mody@cavium.com>
Message-Id: <20170919013814.EA60D592B@dpdk.org>
Date: Tue, 19 Sep 2017 03:38:14 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw28904 [PATCH 29/53] net/qede/base:
	fix macros to check chip revision/metal
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Sep 2017 01:38:15 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28904

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_dev' - possible side-effects?
#73: FILE: drivers/net/qede/base/ecore.h:693:
+#define CHIP_REV_IS_EMUL(_p_dev) \
+	(CHIP_REV_IS_EMUL_A0(_p_dev) || CHIP_REV_IS_EMUL_B0(_p_dev))

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_dev' - possible side-effects?
#77: FILE: drivers/net/qede/base/ecore.h:697:
+#define CHIP_REV_IS_FPGA(_p_dev) \
+	(CHIP_REV_IS_FPGA_A0(_p_dev) || CHIP_REV_IS_FPGA_B0(_p_dev))

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_dev' - possible side-effects?
#79: FILE: drivers/net/qede/base/ecore.h:699:
+#define CHIP_REV_IS_SLOW(_p_dev) \
+	(CHIP_REV_IS_EMUL(_p_dev) || CHIP_REV_IS_FPGA(_p_dev))

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_dev' - possible side-effects?
#81: FILE: drivers/net/qede/base/ecore.h:701:
+#define CHIP_REV_IS_A0(_p_dev) \
+	(CHIP_REV_IS_EMUL_A0(_p_dev) || CHIP_REV_IS_FPGA_A0(_p_dev) || \
+	 (!(_p_dev)->chip_rev && !(_p_dev)->chip_metal))

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_dev' - possible side-effects?
#84: FILE: drivers/net/qede/base/ecore.h:704:
+#define CHIP_REV_IS_B0(_p_dev) \
+	(CHIP_REV_IS_EMUL_B0(_p_dev) || CHIP_REV_IS_FPGA_B0(_p_dev) || \
+	 ((_p_dev)->chip_rev == 1 && !(_p_dev)->chip_metal))

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_dev' - possible side-effects?
#91: FILE: drivers/net/qede/base/ecore.h:709:
+#define CHIP_REV_IS_A0(_p_dev) \
+	(!(_p_dev)->chip_rev && !(_p_dev)->chip_metal)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_dev' - possible side-effects?
#93: FILE: drivers/net/qede/base/ecore.h:711:
+#define CHIP_REV_IS_B0(_p_dev) \
+	((_p_dev)->chip_rev == 1 && !(_p_dev)->chip_metal)

total: 0 errors, 0 warnings, 7 checks, 147 lines checked