From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "liucheng \(J\)" <liucheng11@huawei.com>
Subject: [dpdk-test-report] |WARNING| pw29041 [PATCH] librte_eal:add heap lock in malloc_heap_get_stats
Date: Thu, 21 Sep 2017 10:24:08 +0200 (CEST) [thread overview]
Message-ID: <20170921082408.AAFA01B18C@dpdk.org> (raw)
In-Reply-To: <8B0A0B0226AB0F47A8D0EBBBBA1F005102BC7F7D@DGGEML502-MBX.china.huawei.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29041
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#13:
There is no lock in function malloc_heap_get_stats. When we call this function, the elem may free by other thread.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#38: FILE: lib/librte_eal/common/malloc_heap.c:191:
+ rte_spinlock_lock(&heap->lock);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#46: FILE: lib/librte_eal/common/malloc_heap.c:204:
+ rte_spinlock_unlock(&heap->lock);$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 1 errors, 3 warnings, 21 lines checked
parent reply other threads:[~2017-09-21 8:24 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <8B0A0B0226AB0F47A8D0EBBBBA1F005102BC7F7D@DGGEML502-MBX.china.huawei.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921082408.AAFA01B18C@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=liucheng11@huawei.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).