From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 551AD1B194; Fri, 22 Sep 2017 17:15:41 +0200 (CEST)
In-Reply-To: <1506093431-57588-2-git-send-email-erik.g.carrillo@intel.com>
References: <1506093431-57588-2-git-send-email-erik.g.carrillo@intel.com>
To: test-report@dpdk.org
Cc: Erik Carrillo <erik.g.carrillo@intel.com>
Message-Id: <20170922151541.551AD1B194@dpdk.org>
Date: Fri, 22 Sep 2017 17:15:41 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw29114 [PATCH RFC v2 1/1] eventtimer:
	introduce event timer adapter
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Sep 2017 15:15:41 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29114

_coding style issues_


WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#67: FILE: drivers/event/sw/sw_evdev.c:52:
+extern const struct rte_event_timer_adapter_ops sw_event_adapter_timer_ops;

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#309: FILE: lib/librte_eventdev/rte_event_timer_adapter.c:58:
+#define ADAPTER_VALID_GET_OR_ERR_RET(id, adapter, retval) do {           \
+	if (id >= RTE_EVENT_TIMER_ADAPTER_NUM_MAX || !adapter_valid(id)) \
+		return retval;                                           \
+	adapter = &rte_event_timer_adapters[id];			 \
+} while (0)

total: 0 errors, 2 warnings, 1160 lines checked