From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jan Scheurich <jan.scheurich@ericsson.com>
Subject: [dpdk-test-report] |WARNING| pw29130 [PATCH] vhost: Expose virtio interrupt requirement on rte_vhos API
Date: Sat, 23 Sep 2017 21:16:09 +0200 (CEST) [thread overview]
Message-ID: <20170923191609.514D51B19D@dpdk.org> (raw)
In-Reply-To: <CFF8EF42F1132E4CBE2BF0AB6C21C58D78817630@ESESSMB107.ericsson.se>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29130
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#14:
Performance tests with the OVS DPDK datapath have shown that the tx throughput over a vhostuser port into a VM with an interrupt-based virtio driver is limited by the overhead incurred by virtio interrupts. The OVS PMD spends up to 30% of its cycles in system calls kicking the eventfd. Also the core running the vCPU is heavily loaded with generating the virtio interrupts in KVM on the host and handling these interrupts in the virtio-net driver in the guest. This limits the throughput to about 500-700 Kpps with a single vCPU.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#63: FILE: lib/librte_vhost/vhost.c:509:
+ struct virtio_net *dev;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#64: FILE: lib/librte_vhost/vhost.c:510:
+ struct vhost_virtqueue *vq;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#66: FILE: lib/librte_vhost/vhost.c:512:
+ dev = get_device(vid);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#67: FILE: lib/librte_vhost/vhost.c:513:
+ if (dev == NULL)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#68: FILE: lib/librte_vhost/vhost.c:514:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#68: FILE: lib/librte_vhost/vhost.c:514:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#70: FILE: lib/librte_vhost/vhost.c:516:
+ vq = dev->virtqueue[qid];$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#71: FILE: lib/librte_vhost/vhost.c:517:
+ if (vq == NULL)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#72: FILE: lib/librte_vhost/vhost.c:518:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#72: FILE: lib/librte_vhost/vhost.c:518:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#74: FILE: lib/librte_vhost/vhost.c:520:
+ if (unlikely(vq->enabled == 0 || vq->avail == NULL))$
ERROR:CODE_INDENT: code indent should use tabs where possible
#75: FILE: lib/librte_vhost/vhost.c:521:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#75: FILE: lib/librte_vhost/vhost.c:521:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#77: FILE: lib/librte_vhost/vhost.c:523:
+ return !(vq->avail->flags & VRING_AVAIL_F_NO_INTERRUPT);$
total: 3 errors, 12 warnings, 40 lines checked
parent reply other threads:[~2017-09-23 19:16 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CFF8EF42F1132E4CBE2BF0AB6C21C58D78817630@ESESSMB107.ericsson.se>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170923191609.514D51B19D@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jan.scheurich@ericsson.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).