From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jan Scheurich <jan.scheurich@ericsson.com>
Subject: [dpdk-test-report] |WARNING| pw29131 [PATCH v2] vhost: Expose virtio interrupt need on rte_vhost API
Date: Sat, 23 Sep 2017 22:24:34 +0200 (CEST) [thread overview]
Message-ID: <20170923202434.5CE681AEF6@dpdk.org> (raw)
In-Reply-To: <CFF8EF42F1132E4CBE2BF0AB6C21C58D7881780F@ESESSMB107.ericsson.se>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29131
_coding style issues_
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#85: FILE: lib/librte_vhost/vhost.c:509:
+ struct virtio_net *dev;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#86: FILE: lib/librte_vhost/vhost.c:510:
+ struct vhost_virtqueue *vq;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#88: FILE: lib/librte_vhost/vhost.c:512:
+ dev = get_device(vid);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#89: FILE: lib/librte_vhost/vhost.c:513:
+ if (dev == NULL)$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#89: FILE: lib/librte_vhost/vhost.c:513:
+ if (dev == NULL)
+ return 0;
ERROR:CODE_INDENT: code indent should use tabs where possible
#90: FILE: lib/librte_vhost/vhost.c:514:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#90: FILE: lib/librte_vhost/vhost.c:514:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#92: FILE: lib/librte_vhost/vhost.c:516:
+ vq = dev->virtqueue[qid];$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#93: FILE: lib/librte_vhost/vhost.c:517:
+ if (vq == NULL)$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#93: FILE: lib/librte_vhost/vhost.c:517:
+ if (vq == NULL)
+ return 0;
ERROR:CODE_INDENT: code indent should use tabs where possible
#94: FILE: lib/librte_vhost/vhost.c:518:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#94: FILE: lib/librte_vhost/vhost.c:518:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#96: FILE: lib/librte_vhost/vhost.c:520:
+ if (unlikely(vq->enabled == 0 || vq->avail == NULL))$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#96: FILE: lib/librte_vhost/vhost.c:520:
+ if (unlikely(vq->enabled == 0 || vq->avail == NULL))
+ return 0;
ERROR:CODE_INDENT: code indent should use tabs where possible
#97: FILE: lib/librte_vhost/vhost.c:521:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#97: FILE: lib/librte_vhost/vhost.c:521:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#99: FILE: lib/librte_vhost/vhost.c:523:
+ return !(vq->avail->flags & VRING_AVAIL_F_NO_INTERRUPT);$
total: 3 errors, 14 warnings, 40 lines checked
parent reply other threads:[~2017-09-23 20:24 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CFF8EF42F1132E4CBE2BF0AB6C21C58D7881780F@ESESSMB107.ericsson.se>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170923202434.5CE681AEF6@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jan.scheurich@ericsson.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).