From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 705401AEF6; Sat, 23 Sep 2017 23:59:44 +0200 (CEST)
In-Reply-To: <1506203877-2090-1-git-send-email-ophirmu@mellanox.com>
References: <1506203877-2090-1-git-send-email-ophirmu@mellanox.com>
To: test-report@dpdk.org
Cc: Ophir Munk <ophirmu@mellanox.com>
Message-Id: <20170923215944.705401AEF6@dpdk.org>
Date: Sat, 23 Sep 2017 23:59:44 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw29133 [PATCH] net/failsafe: fix
	calling device during RMV events
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Sep 2017 21:59:44 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29133

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#232: FILE: drivers/net/failsafe/failsafe_private.h:235:
+#define FOREACH_SUBDEV_ACTIVE_SAFE(s, i, dev)				\
+	for (i = fs_find_next((dev), 0, DEV_ACTIVE, 1);			\
+	     i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]);	\
+	     i = fs_find_next((dev), i + 1, DEV_ACTIVE, 1))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#232: FILE: drivers/net/failsafe/failsafe_private.h:235:
+#define FOREACH_SUBDEV_ACTIVE_SAFE(s, i, dev)				\
+	for (i = fs_find_next((dev), 0, DEV_ACTIVE, 1);			\
+	     i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]);	\
+	     i = fs_find_next((dev), i + 1, DEV_ACTIVE, 1))

total: 0 errors, 0 warnings, 2 checks, 175 lines checked