automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
Subject: [dpdk-test-report] |WARNING| pw29179 [PATCH v3 10/13] pci: avoid inlining functions
Date: Mon, 25 Sep 2017 17:26:27 +0200 (CEST)	[thread overview]
Message-ID: <20170925152627.722B01B1EF@dpdk.org> (raw)
In-Reply-To: <94513cd757c4a691d6378b366b83485ea46a57e7.1506352672.git.gaetan.rivet@6wind.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29179

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#142: FILE: lib/librte_pci/rte_pci.c:57:
+#define GET_PCIADDR_FIELD(in, fd, lim, dlm)                     \
+do {                                                            \
+	unsigned long val;                                      \
+	char *end;                                              \
+	errno = 0;                                              \
+	val = strtoul((in), &end, 16);                          \
+	if (errno != 0 || end[0] != (dlm) || val > (lim))       \
+		return -EINVAL;                                 \
+	(fd) = (typeof (fd))val;                                \
+	(in) = end + 1;                                         \
+} while(0)

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#150: FILE: lib/librte_pci/rte_pci.c:65:
+	(fd) = (typeof (fd))val;                                \

ERROR:SPACING: space required before the open parenthesis '('
#152: FILE: lib/librte_pci/rte_pci.c:67:
+} while(0)

total: 1 errors, 2 warnings, 183 lines checked

           reply	other threads:[~2017-09-25 15:26 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <94513cd757c4a691d6378b366b83485ea46a57e7.1506352672.git.gaetan.rivet@6wind.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170925152627.722B01B1EF@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=gaetan.rivet@6wind.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).