automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Tomasz Duszynski <tdu@semihalf.com>
Subject: [dpdk-test-report] |WARNING| pw29192 [PATCH 2/8] net/mrvl: add mrvl net pmd driver
Date: Tue, 26 Sep 2017 11:41:28 +0200 (CEST)	[thread overview]
Message-ID: <20170926094128.379F01B202@dpdk.org> (raw)
In-Reply-To: <1506418805-12117-3-git-send-email-tdu@semihalf.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29192

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < ETHER_MIN_MTU'
#509: FILE: drivers/net/mrvl/mrvl_ethdev.c:329:
+	if ((mtu < ETHER_MIN_MTU) || (mru > MRVL_PKT_SIZE_MAX))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mru > MRVL_PKT_SIZE_MAX'
#509: FILE: drivers/net/mrvl/mrvl_ethdev.c:329:
+	if ((mtu < ETHER_MIN_MTU) || (mru > MRVL_PKT_SIZE_MAX))

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'priv->ppio_params.inqs_params.tcs_params[i].inqs_params'
#788: FILE: drivers/net/mrvl/mrvl_ethdev.c:608:
+			rte_free(priv->ppio_params.inqs_params.
+				tcs_params[i].inqs_params);

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'priv->ppio_params.inqs_params.tcs_params[i].inqs_params'
#790: FILE: drivers/net/mrvl/mrvl_ethdev.c:610:
+			priv->ppio_params.inqs_params.
+				tcs_params[i].inqs_params = NULL;

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'priv->ppio_params.inqs_params.tcs_params[tc].inqs_params[inq].size'
#1238: FILE: drivers/net/mrvl/mrvl_ethdev.c:1058:
+	qinfo->nb_desc = priv->ppio_params.inqs_params.
+			 tcs_params[tc].inqs_params[inq].size;

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'priv->ppio_params.inqs_params.tcs_params[priv->rxq_map[rxq->queue_id].tc'
#1408: FILE: drivers/net/mrvl/mrvl_ethdev.c:1228:
+	priv->ppio_params.inqs_params.
+		tcs_params[priv->rxq_map[rxq->queue_id].tc].

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'q->priv->ppio_params.inqs_params.tcs_params[q->priv->rxq_map[q->queue_id].tc'
#1440: FILE: drivers/net/mrvl/mrvl_ethdev.c:1260:
+	num = q->priv->ppio_params.inqs_params.
+			tcs_params[q->priv->rxq_map[q->queue_id].tc].

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'num <= q->priv->bpool_min_size'
#1798: FILE: drivers/net/mrvl/mrvl_ethdev.c:1618:
+		if (unlikely((num <= q->priv->bpool_min_size) ||
+			 (!rx_done && (num < q->priv->bpool_init_size)))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'num < q->priv->bpool_init_size'
#1798: FILE: drivers/net/mrvl/mrvl_ethdev.c:1618:
+		if (unlikely((num <= q->priv->bpool_min_size) ||
+			 (!rx_done && (num < q->priv->bpool_init_size)))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ol_flags == PKT_TX_TCP_CKSUM'
#1875: FILE: drivers/net/mrvl/mrvl_ethdev.c:1695:
+	if ((packet_type & RTE_PTYPE_L4_TCP) &&
+	    (ol_flags == PKT_TX_TCP_CKSUM)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'sq->num_to_release < MRVL_PP2_BUF_RELEASE_BURST_SIZE'
#1918: FILE: drivers/net/mrvl/mrvl_ethdev.c:1738:
+	if (likely(!force &&
+		   (sq->num_to_release < MRVL_PP2_BUF_RELEASE_BURST_SIZE)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ret < 0'
#2370: FILE: drivers/net/mrvl/mrvl_ethdev.c:2190:
+	if ((ret < 0) && (ret != -EEXIST))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'errno != 0'
#2685: FILE: drivers/net/mrvl/mrvl_qos.c:101:
+	if ((errno != 0) || (RTE_PTR_DIFF(endptr, string) != len))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'beg < 0'
#2807: FILE: drivers/net/mrvl/mrvl_qos.c:223:
+			if ((beg < 0) || (beg > UCHAR_MAX) ||
+				(end < 0) || (end > UCHAR_MAX) || (end < beg))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'beg > UCHAR_MAX'
#2807: FILE: drivers/net/mrvl/mrvl_qos.c:223:
+			if ((beg < 0) || (beg > UCHAR_MAX) ||
+				(end < 0) || (end > UCHAR_MAX) || (end < beg))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'end < 0'
#2807: FILE: drivers/net/mrvl/mrvl_qos.c:223:
+			if ((beg < 0) || (beg > UCHAR_MAX) ||
+				(end < 0) || (end > UCHAR_MAX) || (end < beg))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'end > UCHAR_MAX'
#2807: FILE: drivers/net/mrvl/mrvl_qos.c:223:
+			if ((beg < 0) || (beg > UCHAR_MAX) ||
+				(end < 0) || (end > UCHAR_MAX) || (end < beg))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'end < beg'
#2807: FILE: drivers/net/mrvl/mrvl_qos.c:223:
+			if ((beg < 0) || (beg > UCHAR_MAX) ||
+				(end < 0) || (end > UCHAR_MAX) || (end < beg))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'val > USHRT_MAX'
#2969: FILE: drivers/net/mrvl/mrvl_qos.c:385:
+			if ((get_val_securely(entry, &val) < 0) ||
+				(val > USHRT_MAX))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mrvl_qos_cfg == NULL'
#3078: FILE: drivers/net/mrvl/mrvl_qos.c:494:
+	if ((mrvl_qos_cfg == NULL) ||
+		(mrvl_qos_cfg->port[portid].use_global_defaults)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mrvl_qos_cfg->port[portid].use_global_defaults'
#3078: FILE: drivers/net/mrvl/mrvl_qos.c:494:
+	if ((mrvl_qos_cfg == NULL) ||
+		(mrvl_qos_cfg->port[portid].use_global_defaults)) {

total: 0 errors, 5 warnings, 3231 lines checked

           reply	other threads:[~2017-09-26  9:41 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1506418805-12117-3-git-send-email-tdu@semihalf.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170926094128.379F01B202@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=tdu@semihalf.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).