From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 379F01B202; Tue, 26 Sep 2017 11:41:28 +0200 (CEST) In-Reply-To: <1506418805-12117-3-git-send-email-tdu@semihalf.com> References: <1506418805-12117-3-git-send-email-tdu@semihalf.com> To: test-report@dpdk.org Cc: Tomasz Duszynski Message-Id: <20170926094128.379F01B202@dpdk.org> Date: Tue, 26 Sep 2017 11:41:28 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw29192 [PATCH 2/8] net/mrvl: add mrvl net pmd driver X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Sep 2017 09:41:28 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/29192 _coding style issues_ CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < ETHER_MIN_MTU' #509: FILE: drivers/net/mrvl/mrvl_ethdev.c:329: + if ((mtu < ETHER_MIN_MTU) || (mru > MRVL_PKT_SIZE_MAX)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mru > MRVL_PKT_SIZE_MAX' #509: FILE: drivers/net/mrvl/mrvl_ethdev.c:329: + if ((mtu < ETHER_MIN_MTU) || (mru > MRVL_PKT_SIZE_MAX)) WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'priv->ppio_params.inqs_params.tcs_params[i].inqs_params' #788: FILE: drivers/net/mrvl/mrvl_ethdev.c:608: + rte_free(priv->ppio_params.inqs_params. + tcs_params[i].inqs_params); WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'priv->ppio_params.inqs_params.tcs_params[i].inqs_params' #790: FILE: drivers/net/mrvl/mrvl_ethdev.c:610: + priv->ppio_params.inqs_params. + tcs_params[i].inqs_params = NULL; WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'priv->ppio_params.inqs_params.tcs_params[tc].inqs_params[inq].size' #1238: FILE: drivers/net/mrvl/mrvl_ethdev.c:1058: + qinfo->nb_desc = priv->ppio_params.inqs_params. + tcs_params[tc].inqs_params[inq].size; WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'priv->ppio_params.inqs_params.tcs_params[priv->rxq_map[rxq->queue_id].tc' #1408: FILE: drivers/net/mrvl/mrvl_ethdev.c:1228: + priv->ppio_params.inqs_params. + tcs_params[priv->rxq_map[rxq->queue_id].tc]. WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'q->priv->ppio_params.inqs_params.tcs_params[q->priv->rxq_map[q->queue_id].tc' #1440: FILE: drivers/net/mrvl/mrvl_ethdev.c:1260: + num = q->priv->ppio_params.inqs_params. + tcs_params[q->priv->rxq_map[q->queue_id].tc]. CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'num <= q->priv->bpool_min_size' #1798: FILE: drivers/net/mrvl/mrvl_ethdev.c:1618: + if (unlikely((num <= q->priv->bpool_min_size) || + (!rx_done && (num < q->priv->bpool_init_size)))) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'num < q->priv->bpool_init_size' #1798: FILE: drivers/net/mrvl/mrvl_ethdev.c:1618: + if (unlikely((num <= q->priv->bpool_min_size) || + (!rx_done && (num < q->priv->bpool_init_size)))) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ol_flags == PKT_TX_TCP_CKSUM' #1875: FILE: drivers/net/mrvl/mrvl_ethdev.c:1695: + if ((packet_type & RTE_PTYPE_L4_TCP) && + (ol_flags == PKT_TX_TCP_CKSUM)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'sq->num_to_release < MRVL_PP2_BUF_RELEASE_BURST_SIZE' #1918: FILE: drivers/net/mrvl/mrvl_ethdev.c:1738: + if (likely(!force && + (sq->num_to_release < MRVL_PP2_BUF_RELEASE_BURST_SIZE))) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ret < 0' #2370: FILE: drivers/net/mrvl/mrvl_ethdev.c:2190: + if ((ret < 0) && (ret != -EEXIST)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'errno != 0' #2685: FILE: drivers/net/mrvl/mrvl_qos.c:101: + if ((errno != 0) || (RTE_PTR_DIFF(endptr, string) != len)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'beg < 0' #2807: FILE: drivers/net/mrvl/mrvl_qos.c:223: + if ((beg < 0) || (beg > UCHAR_MAX) || + (end < 0) || (end > UCHAR_MAX) || (end < beg)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'beg > UCHAR_MAX' #2807: FILE: drivers/net/mrvl/mrvl_qos.c:223: + if ((beg < 0) || (beg > UCHAR_MAX) || + (end < 0) || (end > UCHAR_MAX) || (end < beg)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'end < 0' #2807: FILE: drivers/net/mrvl/mrvl_qos.c:223: + if ((beg < 0) || (beg > UCHAR_MAX) || + (end < 0) || (end > UCHAR_MAX) || (end < beg)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'end > UCHAR_MAX' #2807: FILE: drivers/net/mrvl/mrvl_qos.c:223: + if ((beg < 0) || (beg > UCHAR_MAX) || + (end < 0) || (end > UCHAR_MAX) || (end < beg)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'end < beg' #2807: FILE: drivers/net/mrvl/mrvl_qos.c:223: + if ((beg < 0) || (beg > UCHAR_MAX) || + (end < 0) || (end > UCHAR_MAX) || (end < beg)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'val > USHRT_MAX' #2969: FILE: drivers/net/mrvl/mrvl_qos.c:385: + if ((get_val_securely(entry, &val) < 0) || + (val > USHRT_MAX)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mrvl_qos_cfg == NULL' #3078: FILE: drivers/net/mrvl/mrvl_qos.c:494: + if ((mrvl_qos_cfg == NULL) || + (mrvl_qos_cfg->port[portid].use_global_defaults)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mrvl_qos_cfg->port[portid].use_global_defaults' #3078: FILE: drivers/net/mrvl/mrvl_qos.c:494: + if ((mrvl_qos_cfg == NULL) || + (mrvl_qos_cfg->port[portid].use_global_defaults)) { total: 0 errors, 5 warnings, 3231 lines checked