From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 141791B1BA; Thu, 28 Sep 2017 16:20:53 +0200 (CEST)
In-Reply-To: <20170928141329.73874-19-ajit.khaparde@broadcom.com>
References: <20170928141329.73874-19-ajit.khaparde@broadcom.com>
To: test-report@dpdk.org
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
Message-Id: <20170928142053.141791B1BA@dpdk.org>
Date: Thu, 28 Sep 2017 16:20:53 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw29364 [PATCH v3 18/24] net/bnxt: add
	support for flow filter ops
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Sep 2017 14:20:53 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29364

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#150: FILE: drivers/net/bnxt/bnxt_ethdev.c:1662:
+	if (efilter->ether_type != ETHER_TYPE_IPv4 &&

CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv6>
#151: FILE: drivers/net/bnxt/bnxt_ethdev.c:1663:
+		efilter->ether_type != ETHER_TYPE_IPv6) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mfilter->flags ==
 			      HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP'
#170: FILE: drivers/net/bnxt/bnxt_ethdev.c:1682:
+			if ((!memcmp(efilter->mac_addr.addr_bytes,
+				     mfilter->l2_addr, ETHER_ADDR_LEN) &&
+			     (mfilter->flags ==
+			      HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP) &&
+			     (mfilter->ethertype == efilter->ether_type))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mfilter->ethertype == efilter->ether_type'
#170: FILE: drivers/net/bnxt/bnxt_ethdev.c:1682:
+			if ((!memcmp(efilter->mac_addr.addr_bytes,
+				     mfilter->l2_addr, ETHER_ADDR_LEN) &&
+			     (mfilter->flags ==
+			      HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP) &&
+			     (mfilter->ethertype == efilter->ether_type))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mfilter->ethertype == efilter->ether_type'
#181: FILE: drivers/net/bnxt/bnxt_ethdev.c:1693:
+			if ((!memcmp(efilter->mac_addr.addr_bytes,
+				     mfilter->l2_addr, ETHER_ADDR_LEN) &&
+			     (mfilter->ethertype == efilter->ether_type) &&
+			     (mfilter->flags ==
+			      HWRM_CFA_L2_FILTER_CFG_INPUT_FLAGS_PATH_RX))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mfilter->flags ==
 			      HWRM_CFA_L2_FILTER_CFG_INPUT_FLAGS_PATH_RX'
#181: FILE: drivers/net/bnxt/bnxt_ethdev.c:1693:
+			if ((!memcmp(efilter->mac_addr.addr_bytes,
+				     mfilter->l2_addr, ETHER_ADDR_LEN) &&
+			     (mfilter->ethertype == efilter->ether_type) &&
+			     (mfilter->flags ==
+			      HWRM_CFA_L2_FILTER_CFG_INPUT_FLAGS_PATH_RX))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_spec->flags != 0x8'
#808: FILE: drivers/net/bnxt/bnxt_filter.c:613:
+			if (vxlan_spec->rsvd1 || vxlan_spec->rsvd0[0] ||
+			    vxlan_spec->rsvd0[1] || vxlan_spec->rsvd0[2] ||
+			    (vxlan_spec->flags != 0x8)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nvgre_spec->c_k_s_rsvd0_ver != 0x2000'
#857: FILE: drivers/net/bnxt/bnxt_filter.c:662:
+			if ((nvgre_spec->c_k_s_rsvd0_ver != 0x2000) ||
+			    (nvgre_spec->protocol != 0x6558)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nvgre_spec->protocol != 0x6558'
#857: FILE: drivers/net/bnxt/bnxt_filter.c:662:
+			if ((nvgre_spec->c_k_s_rsvd0_ver != 0x2000) ||
+			    (nvgre_spec->protocol != 0x6558)) {

total: 0 errors, 0 warnings, 9 checks, 1698 lines checked