From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: [dpdk-test-report] |WARNING| pw29388 [PATCH v4 18/24] net/bnxt: add support for flow filter ops
Date: Thu, 28 Sep 2017 23:45:04 +0200 (CEST) [thread overview]
Message-ID: <20170928214504.CF6E12BF2@dpdk.org> (raw)
In-Reply-To: <20170928214345.87655-19-ajit.khaparde@broadcom.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29388
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#151: FILE: drivers/net/bnxt/bnxt_ethdev.c:1662:
+ if (efilter->ether_type != ETHER_TYPE_IPv4 &&
CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv6>
#152: FILE: drivers/net/bnxt/bnxt_ethdev.c:1663:
+ efilter->ether_type != ETHER_TYPE_IPv6) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mfilter->flags ==
HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP'
#171: FILE: drivers/net/bnxt/bnxt_ethdev.c:1682:
+ if ((!memcmp(efilter->mac_addr.addr_bytes,
+ mfilter->l2_addr, ETHER_ADDR_LEN) &&
+ (mfilter->flags ==
+ HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP) &&
+ (mfilter->ethertype == efilter->ether_type))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mfilter->ethertype == efilter->ether_type'
#171: FILE: drivers/net/bnxt/bnxt_ethdev.c:1682:
+ if ((!memcmp(efilter->mac_addr.addr_bytes,
+ mfilter->l2_addr, ETHER_ADDR_LEN) &&
+ (mfilter->flags ==
+ HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP) &&
+ (mfilter->ethertype == efilter->ether_type))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mfilter->ethertype == efilter->ether_type'
#182: FILE: drivers/net/bnxt/bnxt_ethdev.c:1693:
+ if ((!memcmp(efilter->mac_addr.addr_bytes,
+ mfilter->l2_addr, ETHER_ADDR_LEN) &&
+ (mfilter->ethertype == efilter->ether_type) &&
+ (mfilter->flags ==
+ HWRM_CFA_L2_FILTER_CFG_INPUT_FLAGS_PATH_RX))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mfilter->flags ==
HWRM_CFA_L2_FILTER_CFG_INPUT_FLAGS_PATH_RX'
#182: FILE: drivers/net/bnxt/bnxt_ethdev.c:1693:
+ if ((!memcmp(efilter->mac_addr.addr_bytes,
+ mfilter->l2_addr, ETHER_ADDR_LEN) &&
+ (mfilter->ethertype == efilter->ether_type) &&
+ (mfilter->flags ==
+ HWRM_CFA_L2_FILTER_CFG_INPUT_FLAGS_PATH_RX))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_spec->flags != 0x8'
#809: FILE: drivers/net/bnxt/bnxt_filter.c:613:
+ if (vxlan_spec->rsvd1 || vxlan_spec->rsvd0[0] ||
+ vxlan_spec->rsvd0[1] || vxlan_spec->rsvd0[2] ||
+ (vxlan_spec->flags != 0x8)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nvgre_spec->c_k_s_rsvd0_ver != 0x2000'
#858: FILE: drivers/net/bnxt/bnxt_filter.c:662:
+ if ((nvgre_spec->c_k_s_rsvd0_ver != 0x2000) ||
+ (nvgre_spec->protocol != 0x6558)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nvgre_spec->protocol != 0x6558'
#858: FILE: drivers/net/bnxt/bnxt_filter.c:662:
+ if ((nvgre_spec->c_k_s_rsvd0_ver != 0x2000) ||
+ (nvgre_spec->protocol != 0x6558)) {
total: 0 errors, 0 warnings, 9 checks, 1699 lines checked
parent reply other threads:[~2017-09-28 21:45 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20170928214345.87655-19-ajit.khaparde@broadcom.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170928214504.CF6E12BF2@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=ajit.khaparde@broadcom.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).