From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 674511B1BA; Fri, 29 Sep 2017 15:53:58 +0200 (CEST) In-Reply-To: <20170929140444.83959-5-jasvinder.singh@intel.com> References: <20170929140444.83959-5-jasvinder.singh@intel.com> To: test-report@dpdk.org Cc: Jasvinder Singh Message-Id: <20170929135358.674511B1BA@dpdk.org> Date: Fri, 29 Sep 2017 15:53:58 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw29436 [PATCH v5 4/5] net/softnic: add TM hierarchy related ops X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Sep 2017 13:53:58 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/29436 _coding style issues_ CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'np->level != TM_NODE_LEVEL_PIPE' #328: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:370: + if ((np->level != TM_NODE_LEVEL_PIPE) || + (np->parent_node_id != pipe_node->parent_node_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'np->parent_node_id != pipe_node->parent_node_id' #328: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:370: + if ((np->level != TM_NODE_LEVEL_PIPE) || + (np->parent_node_id != pipe_node->parent_node_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nq->level != TM_NODE_LEVEL_QUEUE' #357: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:399: + if ((nq->level != TM_NODE_LEVEL_QUEUE) || + (nq->parent_node_id != queue_node->parent_node_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nq->parent_node_id != queue_node->parent_node_id' #357: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:399: + if ((nq->level != TM_NODE_LEVEL_QUEUE) || + (nq->parent_node_id != queue_node->parent_node_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'node_id == RTE_TM_NODE_ID_NULL' #393: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:453: + if ((node_id == RTE_TM_NODE_ID_NULL) || + (tm_node_search(dev, node_id) == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'profile->peak.rate == 0' #451: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:955: + if ((profile->peak.rate == 0) || + (profile->peak.rate >= UINT32_MAX)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'profile->peak.rate >= UINT32_MAX' #451: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:955: + if ((profile->peak.rate == 0) || + (profile->peak.rate >= UINT32_MAX)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'profile->peak.size == 0' #460: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:964: + if ((profile->peak.size == 0) || + (profile->peak.size >= UINT32_MAX)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'profile->peak.size >= UINT32_MAX' #460: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:964: + if ((profile->peak.size == 0) || + (profile->peak.size >= UINT32_MAX)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->level != TM_NODE_LEVEL_TC' #568: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1072: + if ((n->level != TM_NODE_LEVEL_TC) || + (n->params.n_shared_shapers == 0) || + (n->params.shared_shaper_id[0] != ss->shared_shaper_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->params.n_shared_shapers == 0' #568: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1072: + if ((n->level != TM_NODE_LEVEL_TC) || + (n->params.n_shared_shapers == 0) || + (n->params.shared_shaper_id[0] != ss->shared_shaper_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->params.shared_shaper_id[0] != ss->shared_shaper_id' #568: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1072: + if ((n->level != TM_NODE_LEVEL_TC) || + (n->params.n_shared_shapers == 0) || + (n->params.shared_shaper_id[0] != ss->shared_shaper_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'min_th > max_th' #776: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1280: + if ((min_th > max_th) || (max_th == 0)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'max_th == 0' #776: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1280: + if ((min_th > max_th) || (max_th == 0)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->shaper_profile_id == RTE_TM_SHAPER_PROFILE_ID_NONE' #899: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1403: + if ((params->shaper_profile_id == RTE_TM_SHAPER_PROFILE_ID_NONE) || + (sp == NULL) || + (sp->params.peak.rate > p->params.soft.tm.rate)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'sp == NULL' #899: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1403: + if ((params->shaper_profile_id == RTE_TM_SHAPER_PROFILE_ID_NONE) || + (sp == NULL) || + (sp->params.peak.rate > p->params.soft.tm.rate)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'sp->params.peak.rate > p->params.soft.tm.rate' #899: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1403: + if ((params->shaper_profile_id == RTE_TM_SHAPER_PROFILE_ID_NONE) || + (sp == NULL) || + (sp->params.peak.rate > p->params.soft.tm.rate)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '~STATS_MASK_DEFAULT' #925: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1429: + if (params->stats_mask & (~STATS_MASK_DEFAULT)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->shaper_profile_id == RTE_TM_SHAPER_PROFILE_ID_NONE' #972: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1476: + if ((params->shaper_profile_id == RTE_TM_SHAPER_PROFILE_ID_NONE) || + (!tm_shaper_profile_search(dev, params->shaper_profile_id))) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '~STATS_MASK_DEFAULT' #997: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1501: + if (params->stats_mask & (~STATS_MASK_DEFAULT)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->shaper_profile_id == RTE_TM_SHAPER_PROFILE_ID_NONE' #1036: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1540: + if ((params->shaper_profile_id == RTE_TM_SHAPER_PROFILE_ID_NONE) || + (!tm_shaper_profile_search(dev, params->shaper_profile_id))) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->nonleaf.wfq_weight_mode != NULL' #1062: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1566: + if ((params->nonleaf.wfq_weight_mode != NULL) && + (params->nonleaf.wfq_weight_mode[0] != 0) && + (params->nonleaf.wfq_weight_mode[1] != 0) && + (params->nonleaf.wfq_weight_mode[2] != 0) && + (params->nonleaf.wfq_weight_mode[3] != 0)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->nonleaf.wfq_weight_mode[0] != 0' #1062: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1566: + if ((params->nonleaf.wfq_weight_mode != NULL) && + (params->nonleaf.wfq_weight_mode[0] != 0) && + (params->nonleaf.wfq_weight_mode[1] != 0) && + (params->nonleaf.wfq_weight_mode[2] != 0) && + (params->nonleaf.wfq_weight_mode[3] != 0)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->nonleaf.wfq_weight_mode[1] != 0' #1062: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1566: + if ((params->nonleaf.wfq_weight_mode != NULL) && + (params->nonleaf.wfq_weight_mode[0] != 0) && + (params->nonleaf.wfq_weight_mode[1] != 0) && + (params->nonleaf.wfq_weight_mode[2] != 0) && + (params->nonleaf.wfq_weight_mode[3] != 0)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->nonleaf.wfq_weight_mode[2] != 0' #1062: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1566: + if ((params->nonleaf.wfq_weight_mode != NULL) && + (params->nonleaf.wfq_weight_mode[0] != 0) && + (params->nonleaf.wfq_weight_mode[1] != 0) && + (params->nonleaf.wfq_weight_mode[2] != 0) && + (params->nonleaf.wfq_weight_mode[3] != 0)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->nonleaf.wfq_weight_mode[3] != 0' #1062: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1566: + if ((params->nonleaf.wfq_weight_mode != NULL) && + (params->nonleaf.wfq_weight_mode[0] != 0) && + (params->nonleaf.wfq_weight_mode[1] != 0) && + (params->nonleaf.wfq_weight_mode[2] != 0) && + (params->nonleaf.wfq_weight_mode[3] != 0)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '~STATS_MASK_DEFAULT' #1074: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1578: + if (params->stats_mask & (~STATS_MASK_DEFAULT)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->shaper_profile_id == RTE_TM_SHAPER_PROFILE_ID_NONE' #1113: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1617: + if ((params->shaper_profile_id == RTE_TM_SHAPER_PROFILE_ID_NONE) || + (!tm_shaper_profile_search(dev, params->shaper_profile_id))) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->n_shared_shapers == 1' #1129: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1633: + if ((params->n_shared_shapers == 1) && + ((params->shared_shaper_id == NULL) || + (!tm_shared_shaper_search(dev, params->shared_shaper_id[0])))) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->shared_shaper_id == NULL' #1129: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1633: + if ((params->n_shared_shapers == 1) && + ((params->shared_shaper_id == NULL) || + (!tm_shared_shaper_search(dev, params->shared_shaper_id[0])))) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '~STATS_MASK_DEFAULT' #1147: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1651: + if (params->stats_mask & (~STATS_MASK_DEFAULT)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'wred_profile_id == RTE_TM_WRED_PROFILE_ID_NONE' #1216: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1720: + if ((wred_profile_id == RTE_TM_WRED_PROFILE_ID_NONE) || + (wp == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'wp == NULL' #1216: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1720: + if ((wred_profile_id == RTE_TM_WRED_PROFILE_ID_NONE) || + (wp == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '~STATS_MASK_QUEUE' #1234: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1738: + if (params->stats_mask & (~STATS_MASK_QUEUE)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'weight == 0' #1307: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1811: + if ((weight == 0) || (weight >= UINT8_MAX)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'weight >= UINT8_MAX' #1307: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1811: + if ((weight == 0) || (weight >= UINT8_MAX)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'level_id != RTE_TM_NODE_LEVEL_ID_ANY' #1321: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1825: + if ((level_id != RTE_TM_NODE_LEVEL_ID_ANY) && (level_id != level)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'level_id != level' #1321: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1825: + if ((level_id != RTE_TM_NODE_LEVEL_ID_ANY) && (level_id != level)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->level == TM_NODE_LEVEL_QUEUE' #1443: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1947: + if ((n->level == TM_NODE_LEVEL_QUEUE) && + (params->leaf.cman == RTE_TM_CMAN_WRED)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'params->leaf.cman == RTE_TM_CMAN_WRED' #1443: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:1947: + if ((n->level == TM_NODE_LEVEL_QUEUE) && + (params->leaf.cman == RTE_TM_CMAN_WRED)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nt->level != TM_NODE_LEVEL_TC' #1566: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2070: + if ((nt->level != TM_NODE_LEVEL_TC) || + (nt->parent_node_id != np->node_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nt->parent_node_id != np->node_id' #1566: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2070: + if ((nt->level != TM_NODE_LEVEL_TC) || + (nt->parent_node_id != np->node_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nq->level != TM_NODE_LEVEL_QUEUE' #1577: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2081: + if ((nq->level != TM_NODE_LEVEL_QUEUE) || + (nq->parent_node_id != nt->node_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nq->parent_node_id != nt->node_id' #1577: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2081: + if ((nq->level != TM_NODE_LEVEL_QUEUE) || + (nq->parent_node_id != nt->node_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'np->level != TM_NODE_LEVEL_PIPE' #1699: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2203: + if ((np->level != TM_NODE_LEVEL_PIPE) || + (np->parent_node_id != ns->node_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'np->parent_node_id != ns->node_id' #1699: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2203: + if ((np->level != TM_NODE_LEVEL_PIPE) || + (np->parent_node_id != ns->node_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nq->level != TM_NODE_LEVEL_QUEUE' #1732: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2236: + if ((nq->level != TM_NODE_LEVEL_QUEUE) || + (nq->parent_node->priority != tc_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nq->parent_node->priority != tc_id' #1732: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2236: + if ((nq->level != TM_NODE_LEVEL_QUEUE) || + (nq->parent_node->priority != tc_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->level != TM_NODE_LEVEL_TC' #1790: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2294: + if ((n->level != TM_NODE_LEVEL_TC) || + (n->parent_node->parent_node_id != + subport_node->node_id) || + (n->priority != tc_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->parent_node->parent_node_id != subport_node->node_id' #1790: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2294: + if ((n->level != TM_NODE_LEVEL_TC) || + (n->parent_node->parent_node_id != + subport_node->node_id) || + (n->priority != tc_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n->priority != tc_id' #1790: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2294: + if ((n->level != TM_NODE_LEVEL_TC) || + (n->parent_node->parent_node_id != + subport_node->node_id) || + (n->priority != tc_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nr->n_children == 0' #1824: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2328: + if ((nr->n_children == 0) || (nr->n_children > TM_MAX_SUBPORTS)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nr->n_children > TM_MAX_SUBPORTS' #1824: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2328: + if ((nr->n_children == 0) || (nr->n_children > TM_MAX_SUBPORTS)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nt->level != TM_NODE_LEVEL_TC' #1881: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2385: + if ((nt->level != TM_NODE_LEVEL_TC) || + (nt->parent_node_id != np->node_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nt->parent_node_id != np->node_id' #1881: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2385: + if ((nt->level != TM_NODE_LEVEL_TC) || + (nt->parent_node_id != np->node_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nt->level != TM_NODE_LEVEL_TC' #1930: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2434: + if ((nt->level != TM_NODE_LEVEL_TC) || + (nt->parent_node->parent_node_id != + ns->node_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nt->parent_node->parent_node_id != ns->node_id' #1930: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2434: + if ((nt->level != TM_NODE_LEVEL_TC) || + (nt->parent_node->parent_node_id != + ns->node_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'subport_ss == NULL' #1938: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2442: + if ((subport_ss == NULL) && (tc_ss == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tc_ss == NULL' #1938: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2442: + if ((subport_ss == NULL) && (tc_ss == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'subport_ss == NULL' #1941: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2445: + if (((subport_ss == NULL) && (tc_ss != NULL)) || + ((subport_ss != NULL) && (tc_ss == NULL)) || + (subport_ss->shared_shaper_id != + tc_ss->shared_shaper_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tc_ss != NULL' #1941: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2445: + if (((subport_ss == NULL) && (tc_ss != NULL)) || + ((subport_ss != NULL) && (tc_ss == NULL)) || + (subport_ss->shared_shaper_id != + tc_ss->shared_shaper_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'subport_ss != NULL' #1941: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2445: + if (((subport_ss == NULL) && (tc_ss != NULL)) || + ((subport_ss != NULL) && (tc_ss == NULL)) || + (subport_ss->shared_shaper_id != + tc_ss->shared_shaper_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tc_ss == NULL' #1941: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2445: + if (((subport_ss == NULL) && (tc_ss != NULL)) || + ((subport_ss != NULL) && (tc_ss == NULL)) || + (subport_ss->shared_shaper_id != + tc_ss->shared_shaper_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'subport_ss->shared_shaper_id != tc_ss->shared_shaper_id' #1941: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2445: + if (((subport_ss == NULL) && (tc_ss != NULL)) || + ((subport_ss != NULL) && (tc_ss == NULL)) || + (subport_ss->shared_shaper_id != + tc_ss->shared_shaper_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nt->level != TM_NODE_LEVEL_TC' #1959: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2463: + if ((nt->level != TM_NODE_LEVEL_TC) || + (nt->priority != nt_any->priority) || + (nt->parent_node->parent_node_id != + nt_any->parent_node->parent_node_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nt->priority != nt_any->priority' #1959: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2463: + if ((nt->level != TM_NODE_LEVEL_TC) || + (nt->priority != nt_any->priority) || + (nt->parent_node->parent_node_id != + nt_any->parent_node->parent_node_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nt->parent_node->parent_node_id != nt_any->parent_node->parent_node_id' #1959: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2463: + if ((nt->level != TM_NODE_LEVEL_TC) || + (nt->priority != nt_any->priority) || + (nt->parent_node->parent_node_id != + nt_any->parent_node->parent_node_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ss->n_users == 0' #1968: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2472: + if ((ss->n_users == 0) || (ss->n_users != n_users)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ss->n_users != n_users' #1968: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2472: + if ((ss->n_users == 0) || (ss->n_users != n_users)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nq->wred_profile == NULL' #2023: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2527: + if ((nq->wred_profile == NULL) || + (nq->wred_profile->wred_profile_id != + w[id]->wred_profile_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nq->wred_profile->wred_profile_id != w[id]->wred_profile_id' #2023: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2527: + if ((nq->wred_profile == NULL) || + (nq->wred_profile->wred_profile_id != + w[id]->wred_profile_id)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dev->data->dev_started == 0' #2242: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2746: + if ((dev->data->dev_started == 0) && (tm_used(dev) == 0)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'weight == 0' #2275: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2779: + if ((weight == 0) || (weight >= UINT8_MAX)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'weight >= UINT8_MAX' #2275: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2779: + if ((weight == 0) || (weight >= UINT8_MAX)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dev->data->dev_started == 0' #2469: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:2973: + if ((dev->data->dev_started == 0) && (tm_used(dev) == 0)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dev->data->dev_started == 0' #2851: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:3355: + if ((dev->data->dev_started == 0) && (tm_used(dev) == 0)) total: 0 errors, 0 warnings, 76 checks, 2900 lines checked