From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 36A571B200; Fri, 29 Sep 2017 17:52:35 +0200 (CEST)
In-Reply-To: <1506700252-34949-6-git-send-email-beilei.xing@intel.com>
References: <1506700252-34949-6-git-send-email-beilei.xing@intel.com>
To: test-report@dpdk.org
Cc: Beilei Xing <beilei.xing@intel.com>
Message-Id: <20170929155235.36A571B200@dpdk.org>
Date: Fri, 29 Sep 2017 17:52:35 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw29443 [PATCH v7 5/8] net/i40e:
	finish integration FDIR with generic flow API
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Sep 2017 15:52:35 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29443

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#225: FILE: drivers/net/i40e/i40e_fdir.c:989:
+		*ether_type = rte_cpu_to_be_16(ETHER_TYPE_IPv4);

CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv6>
#252: FILE: drivers/net/i40e/i40e_fdir.c:1016:
+		*ether_type = rte_cpu_to_be_16(ETHER_TYPE_IPv6);

CHECK:CAMELCASE: Avoid CamelCase: <I40E_FDIR_IPv6_DEFAULT_VTC_FLOW>
#254: FILE: drivers/net/i40e/i40e_fdir.c:1018:
+			rte_cpu_to_be_32(I40E_FDIR_IPv6_DEFAULT_VTC_FLOW |

CHECK:CAMELCASE: Avoid CamelCase: <I40E_FDIR_IPv6_TC_OFFSET>
#256: FILE: drivers/net/i40e/i40e_fdir.c:1020:
+					  I40E_FDIR_IPv6_TC_OFFSET));

CHECK:CAMELCASE: Avoid CamelCase: <I40E_FDIR_IPv6_PAYLOAD_LEN>
#258: FILE: drivers/net/i40e/i40e_fdir.c:1022:
+			rte_cpu_to_be_16(I40E_FDIR_IPv6_PAYLOAD_LEN);

CHECK:CAMELCASE: Avoid CamelCase: <I40E_FDIR_IPv6_DEFAULT_HOP_LIMITS>
#264: FILE: drivers/net/i40e/i40e_fdir.c:1028:
+					I40E_FDIR_IPv6_DEFAULT_HOP_LIMITS;

CHECK:BRACES: braces {} should be used on all arms of this statement
#498: FILE: drivers/net/i40e/i40e_fdir.c:1383:
+	if (hw->mac.type == I40E_MAC_X722) {
[...]
+	} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#504: FILE: drivers/net/i40e/i40e_fdir.c:1389:
+	} else

CHECK:BRACES: braces {} should be used on all arms of this statement
#659: FILE: drivers/net/i40e/i40e_fdir.c:1688:
+	if (fdir_action->behavior == I40E_FDIR_REJECT)
[...]
+	else if (fdir_action->behavior == I40E_FDIR_ACCEPT)
[...]
+	else if (fdir_action->behavior == I40E_FDIR_PASSTHRU)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#665: FILE: drivers/net/i40e/i40e_fdir.c:1694:
+	else {

total: 0 errors, 0 warnings, 10 checks, 891 lines checked