automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw29447 [PATCH v1 1/6] bbdev: librte_bbdev library
       [not found] <1506735475-77078-1-git-send-email-amr.mokhtar@intel.com>
@ 2017-09-30  1:38 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-09-30  1:38 UTC (permalink / raw)
  To: test-report; +Cc: Amr Mokhtar

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29447

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#179: FILE: lib/librte_bbdev/rte_bbdev.c:59:
+#define VALID_DEV_OR_RET_ERR(dev, dev_id) do { \
+	if (dev == NULL) { \
+		rte_bbdev_log(ERR, "device %u is invalid", dev_id); \
+		return -ENODEV; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#187: FILE: lib/librte_bbdev/rte_bbdev.c:67:
+#define VALID_DEV_OPS_OR_RET_ERR(dev, dev_id) do { \
+	if (dev->dev_ops == NULL) { \
+		rte_bbdev_log(ERR, "NULL dev_ops structure in device %u", \
+				dev_id); \
+		return -ENODEV; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#196: FILE: lib/librte_bbdev/rte_bbdev.c:76:
+#define VALID_FUNC_OR_RET_ERR(func, dev_id) do { \
+	if (func == NULL) { \
+		rte_bbdev_log(ERR, "device %u does not support %s", \
+				dev_id, #func); \
+		return -ENOTSUP; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#205: FILE: lib/librte_bbdev/rte_bbdev.c:85:
+#define VALID_QUEUE_OR_RET_ERR(queue_id, dev) do { \
+	if (queue_id >= dev->data->num_queues) { \
+		rte_bbdev_log(ERR, "Invalid queue_id %u for device %u", \
+				queue_id, dev->data->dev_id); \
+		return -ERANGE; \
+	} \
+} while (0)

total: 0 errors, 4 warnings, 2871 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-09-30  1:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1506735475-77078-1-git-send-email-amr.mokhtar@intel.com>
2017-09-30  1:38 ` [dpdk-test-report] |WARNING| pw29447 [PATCH v1 1/6] bbdev: librte_bbdev library checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).