From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Amr Mokhtar <amr.mokhtar@intel.com>
Subject: [dpdk-test-report] |WARNING| pw29449 [PATCH v1 4/6] bbdev: sample app
Date: Sat, 30 Sep 2017 03:38:33 +0200 (CEST) [thread overview]
Message-ID: <20170930013833.B99E81B1F4@dpdk.org> (raw)
In-Reply-To: <1506735475-77078-4-git-send-email-amr.mokhtar@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29449
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#172: FILE: examples/bbdev_app/main.c:76:
+#define BBDEV_ASSERT(a) do { \
+ if (!(a)) { \
+ usage(prgname); \
+ return -1; \
+ } \
+} while (0)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#533: FILE: examples/bbdev_app/main.c:437:
+ port_type, (unsigned) portid);
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#540: FILE: examples/bbdev_app/main.c:444:
+ ret, (unsigned) portid);
WARNING:LONG_LINE: line over 90 characters
#776: FILE: examples/bbdev_app/main.c:680:
+ ops_burst[j]->turbo_enc->output.data;
WARNING:LONG_LINE_COMMENT: line over 90 characters
#777: FILE: examples/bbdev_app/main.c:681:
+ /* input mbufs are no longer needed, release! */
WARNING:LONG_LINE: line over 90 characters
#778: FILE: examples/bbdev_app/main.c:682:
+ rte_pktmbuf_free(ops_burst[j]->turbo_enc->input.data);
WARNING:LONG_LINE: line over 90 characters
#785: FILE: examples/bbdev_app/main.c:689:
+ ops_burst[j]->turbo_dec->hard_output.data;
WARNING:LONG_LINE_COMMENT: line over 90 characters
#786: FILE: examples/bbdev_app/main.c:690:
+ /* input mbufs are no longer needed, release! */
WARNING:LONG_LINE: line over 90 characters
#787: FILE: examples/bbdev_app/main.c:691:
+ rte_pktmbuf_free(ops_burst[j]->turbo_dec->input.data);
WARNING:LONG_LINE_COMMENT: line over 90 characters
#861: FILE: examples/bbdev_app/main.c:765:
+ /* append the size of the ethernet header */
WARNING:LONG_LINE: line over 90 characters
#865: FILE: examples/bbdev_app/main.c:769:
+ void *in_buf = rte_pktmbuf_mtod(pkts_burst[j],
WARNING:LONG_LINE: line over 90 characters
#867: FILE: examples/bbdev_app/main.c:771:
+ void *out_buf = rte_pktmbuf_mtod(bbdev_pkts[j],
WARNING:LONG_LINE: line over 90 characters
#872: FILE: examples/bbdev_app/main.c:776:
+ ops_burst[j]->type = RTE_BBDEV_OP_TURBO_ENC;
WARNING:LONG_LINE: line over 90 characters
#877: FILE: examples/bbdev_app/main.c:781:
+ rte_pktmbuf_pkt_len(bbdev_pkts[j]);
WARNING:LONG_LINE_COMMENT: line over 90 characters
#889: FILE: examples/bbdev_app/main.c:793:
+ /* append the size of the ethernet header */
WARNING:LONG_LINE: line over 90 characters
#893: FILE: examples/bbdev_app/main.c:797:
+ void *in_buf = rte_pktmbuf_mtod(pkts_burst[j],
WARNING:LONG_LINE: line over 90 characters
#895: FILE: examples/bbdev_app/main.c:799:
+ void *out_buf = rte_pktmbuf_mtod(bbdev_pkts[j],
WARNING:LONG_LINE: line over 90 characters
#900: FILE: examples/bbdev_app/main.c:804:
+ ops_burst[j]->type = RTE_BBDEV_OP_TURBO_DEC;
WARNING:LONG_LINE: line over 90 characters
#905: FILE: examples/bbdev_app/main.c:809:
+ rte_pktmbuf_pkt_len(bbdev_pkts[j]);
WARNING:LONG_LINE: line over 90 characters
#910: FILE: examples/bbdev_app/main.c:814:
+ ops_burst[j]->turbo_dec->hard_output.data =
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#929: FILE: examples/bbdev_app/main.c:833:
+print_lcore_stats(unsigned lcore_id)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#944: FILE: examples/bbdev_app/main.c:848:
+ unsigned l_id;
total: 0 errors, 22 warnings, 1316 lines checked
parent reply other threads:[~2017-09-30 1:38 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1506735475-77078-4-git-send-email-amr.mokhtar@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170930013833.B99E81B1F4@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=amr.mokhtar@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).