From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id B99E81B1F4; Sat, 30 Sep 2017 03:38:33 +0200 (CEST)
In-Reply-To: <1506735475-77078-4-git-send-email-amr.mokhtar@intel.com>
References: <1506735475-77078-4-git-send-email-amr.mokhtar@intel.com>
To: test-report@dpdk.org
Cc: Amr Mokhtar <amr.mokhtar@intel.com>
Message-Id: <20170930013833.B99E81B1F4@dpdk.org>
Date: Sat, 30 Sep 2017 03:38:33 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw29449 [PATCH v1 4/6] bbdev: sample
	app
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Sep 2017 01:38:33 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29449

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#172: FILE: examples/bbdev_app/main.c:76:
+#define BBDEV_ASSERT(a) do { \
+	if (!(a)) { \
+		usage(prgname); \
+		return -1; \
+	} \
+} while (0)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#533: FILE: examples/bbdev_app/main.c:437:
+				port_type, (unsigned) portid);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#540: FILE: examples/bbdev_app/main.c:444:
+					ret, (unsigned) portid);

WARNING:LONG_LINE: line over 90 characters
#776: FILE: examples/bbdev_app/main.c:680:
+							ops_burst[j]->turbo_enc->output.data;

WARNING:LONG_LINE_COMMENT: line over 90 characters
#777: FILE: examples/bbdev_app/main.c:681:
+						/* input mbufs are no longer needed, release! */

WARNING:LONG_LINE: line over 90 characters
#778: FILE: examples/bbdev_app/main.c:682:
+						rte_pktmbuf_free(ops_burst[j]->turbo_enc->input.data);

WARNING:LONG_LINE: line over 90 characters
#785: FILE: examples/bbdev_app/main.c:689:
+							ops_burst[j]->turbo_dec->hard_output.data;

WARNING:LONG_LINE_COMMENT: line over 90 characters
#786: FILE: examples/bbdev_app/main.c:690:
+						/* input mbufs are no longer needed, release! */

WARNING:LONG_LINE: line over 90 characters
#787: FILE: examples/bbdev_app/main.c:691:
+						rte_pktmbuf_free(ops_burst[j]->turbo_dec->input.data);

WARNING:LONG_LINE_COMMENT: line over 90 characters
#861: FILE: examples/bbdev_app/main.c:765:
+						/* append the size of the ethernet header */

WARNING:LONG_LINE: line over 90 characters
#865: FILE: examples/bbdev_app/main.c:769:
+						void *in_buf = rte_pktmbuf_mtod(pkts_burst[j],

WARNING:LONG_LINE: line over 90 characters
#867: FILE: examples/bbdev_app/main.c:771:
+						void *out_buf = rte_pktmbuf_mtod(bbdev_pkts[j],

WARNING:LONG_LINE: line over 90 characters
#872: FILE: examples/bbdev_app/main.c:776:
+						ops_burst[j]->type = RTE_BBDEV_OP_TURBO_ENC;

WARNING:LONG_LINE: line over 90 characters
#877: FILE: examples/bbdev_app/main.c:781:
+								rte_pktmbuf_pkt_len(bbdev_pkts[j]);

WARNING:LONG_LINE_COMMENT: line over 90 characters
#889: FILE: examples/bbdev_app/main.c:793:
+						/* append the size of the ethernet header */

WARNING:LONG_LINE: line over 90 characters
#893: FILE: examples/bbdev_app/main.c:797:
+						void *in_buf = rte_pktmbuf_mtod(pkts_burst[j],

WARNING:LONG_LINE: line over 90 characters
#895: FILE: examples/bbdev_app/main.c:799:
+						void *out_buf = rte_pktmbuf_mtod(bbdev_pkts[j],

WARNING:LONG_LINE: line over 90 characters
#900: FILE: examples/bbdev_app/main.c:804:
+						ops_burst[j]->type = RTE_BBDEV_OP_TURBO_DEC;

WARNING:LONG_LINE: line over 90 characters
#905: FILE: examples/bbdev_app/main.c:809:
+								rte_pktmbuf_pkt_len(bbdev_pkts[j]);

WARNING:LONG_LINE: line over 90 characters
#910: FILE: examples/bbdev_app/main.c:814:
+						ops_burst[j]->turbo_dec->hard_output.data =

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#929: FILE: examples/bbdev_app/main.c:833:
+print_lcore_stats(unsigned lcore_id)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#944: FILE: examples/bbdev_app/main.c:848:
+	unsigned l_id;

total: 0 errors, 22 warnings, 1316 lines checked