automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Amr Mokhtar <amr.mokhtar@intel.com>
Subject: [dpdk-test-report] |WARNING| pw29450 [PATCH v1 3/6] bbdev: test applications
Date: Sat, 30 Sep 2017 03:38:42 +0200 (CEST)	[thread overview]
Message-ID: <20170930013842.846BD1B19D@dpdk.org> (raw)
In-Reply-To: <1506735475-77078-3-git-send-email-amr.mokhtar@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29450

_coding style issues_


WARNING:MISSING_BREAK: Possible switch case/default not preceded by break or fallthrough comment
#375: FILE: app/test-bbdev/main.c:254:
+		default:

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#493: FILE: app/test-bbdev/main.h:49:
+#define TEST_ASSERT(cond, msg, ...) do {  \
+		if (!(cond)) {  \
+			printf("TestCase %s() line %d failed: " \
+				msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+			return TEST_FAILED;  \
+		} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#502: FILE: app/test-bbdev/main.h:58:
+#define TEST_ASSERT_BUFFERS_ARE_EQUAL(a, b, len, msg, ...) do { \
+	if (memcmp((a), (b), len)) { \
+		printf("TestCase %s() line %d failed: " \
+			msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+		rte_memdump(stdout, "Buffer A", (a), len); \
+		rte_memdump(stdout, "Buffer B", (b), len); \
+		return TEST_FAILED; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#512: FILE: app/test-bbdev/main.h:68:
+#define TEST_ASSERT_SUCCESS(val, msg, ...) do { \
+		typeof(val) _val = (val); \
+		if (!(_val == 0)) { \
+			printf("TestCase %s() line %d failed (err %d): " \
+				msg "
", __func__, __LINE__, _val, \
+				##__VA_ARGS__); \
+			return TEST_FAILED; \
+		} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#525: FILE: app/test-bbdev/main.h:81:
+#define TEST_ASSERT_NOT_NULL(val, msg, ...) do { \
+		if ((val) == NULL) { \
+			printf("TestCase %s() line %d failed (null): " \
+				msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+			return TEST_FAILED;  \
+		} \
+} while (0)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2295: FILE: app/test-bbdev/test_bbdev_perf.c:151:
+			(unsigned)RTE_MBUF_DEFAULT_BUF_SIZE), socket_id);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2315: FILE: app/test-bbdev/test_bbdev_perf.c:171:
+			RTE_MAX((unsigned)(ad->nb_queues * num_ops + 1),

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2317: FILE: app/test-bbdev/test_bbdev_perf.c:173:
+			(unsigned)(1.5 * rte_lcore_count() * OPS_CACHE_SIZE + 1)),

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#3217: FILE: app/test-bbdev/test_bbdev_perf.c:1073:
+	unsigned i;

WARNING:TYPO_SPELLING: 'paramaters' may be misspelled - perhaps 'parameters'?
#4800: FILE: app/test-bbdev/test_bbdev_vector.h:92:
+/* fills test vector paramaters based on test file */

total: 0 errors, 10 warnings, 4884 lines checked

           reply	other threads:[~2017-09-30  1:38 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1506735475-77078-3-git-send-email-amr.mokhtar@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170930013842.846BD1B19D@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=amr.mokhtar@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).