From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Akhil Goyal <akhil.goyal@nxp.com>
Subject: [dpdk-test-report] |WARNING| pw29536 [PATCH v2 01/12] lib/rte_security: add security library
Date: Tue, 3 Oct 2017 15:17:35 +0200 (CEST) [thread overview]
Message-ID: <20171003131735.B44C91B3AD@dpdk.org> (raw)
In-Reply-To: <20171003131413.23846-2-akhil.goyal@nxp.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29536
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#171: FILE: lib/librte_security/rte_security.c:68:
+#define RTE_SEC_VALID_ID_OR_ERR_RET(id, retval) do { \
+ if (!rte_security_is_valid_id(id)) { \
+ RTE_PMD_DEBUG_TRACE("Invalid sec_id=%d
", id); \
+ return retval; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#178: FILE: lib/librte_security/rte_security.c:75:
+#define RTE_SEC_VALID_ID_OR_RET(id) do { \
+ if (!rte_security_is_valid_id(id)) { \
+ RTE_PMD_DEBUG_TRACE("Invalid sec_id=%d
", id); \
+ return; \
+ } \
+} while (0)
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#510: FILE: lib/librte_security/rte_security.h:126:
+ /**< Extended Sequence Numbers (ESN)
+ *
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#517: FILE: lib/librte_security/rte_security.h:133:
+ /**< UDP encapsulation
+ *
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#525: FILE: lib/librte_security/rte_security.h:141:
+ /**< Copy DSCP bits
+ *
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#535: FILE: lib/librte_security/rte_security.h:151:
+ /**< Copy IPv6 Flow Label
+ *
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#543: FILE: lib/librte_security/rte_security.h:159:
+ /**< Copy IPv4 Don't Fragment bit
+ *
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#551: FILE: lib/librte_security/rte_security.h:167:
+ /**< Decrement inner packet Time To Live (TTL) field
+ *
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#560: FILE: lib/librte_security/rte_security.h:176:
+ /**< HW constructs/removes trailer of packets
+ *
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#616: FILE: lib/librte_security/rte_security.h:232:
+ * during transmission */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#619: FILE: lib/librte_security/rte_security.h:235:
+ * transmission */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#622: FILE: lib/librte_security/rte_security.h:238:
+ * on a lookaside accelerator */
total: 0 errors, 12 warnings, 1018 lines checked
parent reply other threads:[~2017-10-03 13:17 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20171003131413.23846-2-akhil.goyal@nxp.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003131735.B44C91B3AD@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=akhil.goyal@nxp.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).