From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id B44C91B3AD; Tue,  3 Oct 2017 15:17:35 +0200 (CEST)
In-Reply-To: <20171003131413.23846-2-akhil.goyal@nxp.com>
References: <20171003131413.23846-2-akhil.goyal@nxp.com>
To: test-report@dpdk.org
Cc: Akhil Goyal <akhil.goyal@nxp.com>
Message-Id: <20171003131735.B44C91B3AD@dpdk.org>
Date: Tue,  3 Oct 2017 15:17:35 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw29536 [PATCH v2 01/12]
	lib/rte_security: add security library
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Oct 2017 13:17:35 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29536

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#171: FILE: lib/librte_security/rte_security.c:68:
+#define RTE_SEC_VALID_ID_OR_ERR_RET(id, retval) do { \
+	if (!rte_security_is_valid_id(id)) { \
+		RTE_PMD_DEBUG_TRACE("Invalid sec_id=%d
", id); \
+		return retval; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#178: FILE: lib/librte_security/rte_security.c:75:
+#define RTE_SEC_VALID_ID_OR_RET(id) do { \
+	if (!rte_security_is_valid_id(id)) { \
+		RTE_PMD_DEBUG_TRACE("Invalid sec_id=%d
", id); \
+		return; \
+	} \
+} while (0)

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#510: FILE: lib/librte_security/rte_security.h:126:
+	/**< Extended Sequence Numbers (ESN)
+	  *

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#517: FILE: lib/librte_security/rte_security.h:133:
+	/**< UDP encapsulation
+	  *

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#525: FILE: lib/librte_security/rte_security.h:141:
+	/**< Copy DSCP bits
+	  *

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#535: FILE: lib/librte_security/rte_security.h:151:
+	/**< Copy IPv6 Flow Label
+	  *

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#543: FILE: lib/librte_security/rte_security.h:159:
+	/**< Copy IPv4 Don't Fragment bit
+	  *

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#551: FILE: lib/librte_security/rte_security.h:167:
+	/**< Decrement inner packet Time To Live (TTL) field
+	  *

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#560: FILE: lib/librte_security/rte_security.h:176:
+	/**< HW constructs/removes trailer of packets
+	  *

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#616: FILE: lib/librte_security/rte_security.h:232:
+	 * during transmission */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#619: FILE: lib/librte_security/rte_security.h:235:
+	 * transmission */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#622: FILE: lib/librte_security/rte_security.h:238:
+	 * on a lookaside accelerator */

total: 0 errors, 12 warnings, 1018 lines checked