From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 14B131B3E1; Tue,  3 Oct 2017 15:17:48 +0200 (CEST)
In-Reply-To: <20171003131413.23846-11-akhil.goyal@nxp.com>
References: <20171003131413.23846-11-akhil.goyal@nxp.com>
To: test-report@dpdk.org
Cc: Akhil Goyal <akhil.goyal@nxp.com>
Message-Id: <20171003131748.14B131B3E1@dpdk.org>
Date: Tue,  3 Oct 2017 15:17:48 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw29545 [PATCH v2 10/12] net/ixgbe:
	enable inline ipsec
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Oct 2017 13:17:48 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29545

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse '__reg' - possible side-effects?
#291: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:48:
+#define IXGBE_WAIT_RW(__reg, __rw)					\
+{									\
+	int cnt = 100;							\
+	IXGBE_WRITE_REG(hw, (__reg), reg);				\
+	while (((IXGBE_READ_REG(hw, (__reg))) & (__rw)) && (cnt--))	\
+		rte_delay_us(1);					\
+}

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#303: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:60:
+#define CMP_IP(a, b) (\
+	(a).ipv6[0] == (b).ipv6[0] && \
+	(a).ipv6[1] == (b).ipv6[1] && \
+	(a).ipv6[2] == (b).ipv6[2] && \
+	(a).ipv6[3] == (b).ipv6[3])

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#303: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:60:
+#define CMP_IP(a, b) (\
+	(a).ipv6[0] == (b).ipv6[0] && \
+	(a).ipv6[1] == (b).ipv6[1] && \
+	(a).ipv6[2] == (b).ipv6[2] && \
+	(a).ipv6[3] == (b).ipv6[3])

CHECK:CAMELCASE: Avoid CamelCase: <IPv6>
#431: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:188:
+		if (ic_session->dst_ip.type == IPv6)

CHECK:CAMELCASE: Avoid CamelCase: <IPv4>
#438: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:195:
+		if (priv->rx_ip_tbl[ip_index].ip.type == IPv4) {

total: 0 errors, 0 warnings, 5 checks, 1234 lines checked