From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Subject: [dpdk-test-report] |WARNING| pw29703 [PATCH v2 12/30] net/mlx5: add reference counter on DPDK Tx queues
Date: Thu, 5 Oct 2017 14:52:09 +0200 (CEST) [thread overview]
Message-ID: <20171005125209.268631B2BF@dpdk.org> (raw)
In-Reply-To: <02443b4938aa8ffeada37efca7c25535a44ce8e0.1507207731.git.nelio.laranjeiro@6wind.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29703
_coding style issues_
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#240: FILE: drivers/net/mlx5/mlx5_rxtx.h:350:
+struct mlx5_txq_ctrl *mlx5_priv_txq_new(struct priv *, uint16_t,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#240: FILE: drivers/net/mlx5/mlx5_rxtx.h:350:
+struct mlx5_txq_ctrl *mlx5_priv_txq_new(struct priv *, uint16_t,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#240: FILE: drivers/net/mlx5/mlx5_rxtx.h:350:
+struct mlx5_txq_ctrl *mlx5_priv_txq_new(struct priv *, uint16_t,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'unsigned int' should also have an identifier name
#240: FILE: drivers/net/mlx5/mlx5_rxtx.h:350:
+struct mlx5_txq_ctrl *mlx5_priv_txq_new(struct priv *, uint16_t,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct rte_eth_txconf *' should also have an identifier name
#240: FILE: drivers/net/mlx5/mlx5_rxtx.h:350:
+struct mlx5_txq_ctrl *mlx5_priv_txq_new(struct priv *, uint16_t,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#243: FILE: drivers/net/mlx5/mlx5_rxtx.h:353:
+struct mlx5_txq_ctrl *mlx5_priv_txq_get(struct priv *, uint16_t);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#243: FILE: drivers/net/mlx5/mlx5_rxtx.h:353:
+struct mlx5_txq_ctrl *mlx5_priv_txq_get(struct priv *, uint16_t);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#244: FILE: drivers/net/mlx5/mlx5_rxtx.h:354:
+int mlx5_priv_txq_release(struct priv *, uint16_t);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#244: FILE: drivers/net/mlx5/mlx5_rxtx.h:354:
+int mlx5_priv_txq_release(struct priv *, uint16_t);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#245: FILE: drivers/net/mlx5/mlx5_rxtx.h:355:
+int mlx5_priv_txq_releasable(struct priv *, uint16_t);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#245: FILE: drivers/net/mlx5/mlx5_rxtx.h:355:
+int mlx5_priv_txq_releasable(struct priv *, uint16_t);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#246: FILE: drivers/net/mlx5/mlx5_rxtx.h:356:
+int mlx5_priv_txq_verify(struct priv *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct mlx5_txq_ctrl *' should also have an identifier name
#247: FILE: drivers/net/mlx5/mlx5_rxtx.h:357:
+void txq_alloc_elts(struct mlx5_txq_ctrl *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_mempool *' should also have an identifier name
#256: FILE: drivers/net/mlx5/mlx5_rxtx.h:385:
+void mlx5_mp2mr_iter(struct rte_mempool *, void *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#256: FILE: drivers/net/mlx5/mlx5_rxtx.h:385:
+void mlx5_mp2mr_iter(struct rte_mempool *, void *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct mlx5_txq_data *' should also have an identifier name
#257: FILE: drivers/net/mlx5/mlx5_rxtx.h:386:
+uint32_t priv_txq_mp2mr_reg(struct priv *priv, struct mlx5_txq_data *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_mempool *' should also have an identifier name
#257: FILE: drivers/net/mlx5/mlx5_rxtx.h:386:
+uint32_t priv_txq_mp2mr_reg(struct priv *priv, struct mlx5_txq_data *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'unsigned int' should also have an identifier name
#257: FILE: drivers/net/mlx5/mlx5_rxtx.h:386:
+uint32_t priv_txq_mp2mr_reg(struct priv *priv, struct mlx5_txq_data *,
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'priv->txqs_n >= priv->txqs_inline'
#684: FILE: drivers/net/mlx5/mlx5_txq.c:584:
+ if (priv->txq_inline && (priv->txqs_n >= priv->txqs_inline)) {
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EBUSY)
#838: FILE: drivers/net/mlx5/mlx5_txq.c:738:
+ return EBUSY;
total: 0 errors, 19 warnings, 1 checks, 804 lines checked
parent reply other threads:[~2017-10-05 12:52 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <02443b4938aa8ffeada37efca7c25535a44ce8e0.1507207731.git.nelio.laranjeiro@6wind.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005125209.268631B2BF@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).