From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 268631B2BF; Thu, 5 Oct 2017 14:52:09 +0200 (CEST) In-Reply-To: <02443b4938aa8ffeada37efca7c25535a44ce8e0.1507207731.git.nelio.laranjeiro@6wind.com> References: <02443b4938aa8ffeada37efca7c25535a44ce8e0.1507207731.git.nelio.laranjeiro@6wind.com> To: test-report@dpdk.org Cc: =?utf-8?q?N=C3=A9lio_Laranjeiro?= Message-Id: <20171005125209.268631B2BF@dpdk.org> Date: Thu, 5 Oct 2017 14:52:09 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw29703 [PATCH v2 12/30] net/mlx5: add reference counter on DPDK Tx queues X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 12:52:09 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/29703 _coding style issues_ WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name #240: FILE: drivers/net/mlx5/mlx5_rxtx.h:350: +struct mlx5_txq_ctrl *mlx5_priv_txq_new(struct priv *, uint16_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name #240: FILE: drivers/net/mlx5/mlx5_rxtx.h:350: +struct mlx5_txq_ctrl *mlx5_priv_txq_new(struct priv *, uint16_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name #240: FILE: drivers/net/mlx5/mlx5_rxtx.h:350: +struct mlx5_txq_ctrl *mlx5_priv_txq_new(struct priv *, uint16_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'unsigned int' should also have an identifier name #240: FILE: drivers/net/mlx5/mlx5_rxtx.h:350: +struct mlx5_txq_ctrl *mlx5_priv_txq_new(struct priv *, uint16_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct rte_eth_txconf *' should also have an identifier name #240: FILE: drivers/net/mlx5/mlx5_rxtx.h:350: +struct mlx5_txq_ctrl *mlx5_priv_txq_new(struct priv *, uint16_t, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name #243: FILE: drivers/net/mlx5/mlx5_rxtx.h:353: +struct mlx5_txq_ctrl *mlx5_priv_txq_get(struct priv *, uint16_t); WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name #243: FILE: drivers/net/mlx5/mlx5_rxtx.h:353: +struct mlx5_txq_ctrl *mlx5_priv_txq_get(struct priv *, uint16_t); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name #244: FILE: drivers/net/mlx5/mlx5_rxtx.h:354: +int mlx5_priv_txq_release(struct priv *, uint16_t); WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name #244: FILE: drivers/net/mlx5/mlx5_rxtx.h:354: +int mlx5_priv_txq_release(struct priv *, uint16_t); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name #245: FILE: drivers/net/mlx5/mlx5_rxtx.h:355: +int mlx5_priv_txq_releasable(struct priv *, uint16_t); WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name #245: FILE: drivers/net/mlx5/mlx5_rxtx.h:355: +int mlx5_priv_txq_releasable(struct priv *, uint16_t); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name #246: FILE: drivers/net/mlx5/mlx5_rxtx.h:356: +int mlx5_priv_txq_verify(struct priv *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct mlx5_txq_ctrl *' should also have an identifier name #247: FILE: drivers/net/mlx5/mlx5_rxtx.h:357: +void txq_alloc_elts(struct mlx5_txq_ctrl *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_mempool *' should also have an identifier name #256: FILE: drivers/net/mlx5/mlx5_rxtx.h:385: +void mlx5_mp2mr_iter(struct rte_mempool *, void *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name #256: FILE: drivers/net/mlx5/mlx5_rxtx.h:385: +void mlx5_mp2mr_iter(struct rte_mempool *, void *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct mlx5_txq_data *' should also have an identifier name #257: FILE: drivers/net/mlx5/mlx5_rxtx.h:386: +uint32_t priv_txq_mp2mr_reg(struct priv *priv, struct mlx5_txq_data *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_mempool *' should also have an identifier name #257: FILE: drivers/net/mlx5/mlx5_rxtx.h:386: +uint32_t priv_txq_mp2mr_reg(struct priv *priv, struct mlx5_txq_data *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'unsigned int' should also have an identifier name #257: FILE: drivers/net/mlx5/mlx5_rxtx.h:386: +uint32_t priv_txq_mp2mr_reg(struct priv *priv, struct mlx5_txq_data *, CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'priv->txqs_n >= priv->txqs_inline' #684: FILE: drivers/net/mlx5/mlx5_txq.c:584: + if (priv->txq_inline && (priv->txqs_n >= priv->txqs_inline)) { WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EBUSY) #838: FILE: drivers/net/mlx5/mlx5_txq.c:738: + return EBUSY; total: 0 errors, 19 warnings, 1 checks, 804 lines checked