automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw29725 [PATCH V2 3/5] ethdev: add new api for traffic metering and policing
Date: Thu,  5 Oct 2017 15:10:55 +0200 (CEST)	[thread overview]
Message-ID: <20171005131055.0CF721B212@dpdk.org> (raw)
In-Reply-To: <1507208974-180500-4-git-send-email-cristian.dumitrescu@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29725

_coding style issues_


WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#81: FILE: MAINTAINERS:264:
+M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#82: FILE: MAINTAINERS:265:
+F: lib/librte_ether/rte_mtr*

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#211: FILE: lib/librte_ether/rte_mtr.c:61:
+			ENOSYS,

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#214: FILE: lib/librte_ether/rte_mtr.c:64:
+			rte_strerror(ENOSYS));

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#221: FILE: lib/librte_ether/rte_mtr.c:71:
+#define RTE_MTR_FUNC(port_id, func)			\
+({							\
+	const struct rte_mtr_ops *ops =			\
+		rte_mtr_ops_get(port_id, error);		\
+	if (ops == NULL)					\
+		return -rte_errno;			\
+							\
+	if (ops->func == NULL)				\
+		return -rte_mtr_error_set(error,		\
+			ENOSYS,				\
+			RTE_MTR_ERROR_TYPE_UNSPECIFIED,	\
+			NULL,				\
+			rte_strerror(ENOSYS));		\
+							\
+	ops->func;					\
+})

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#230: FILE: lib/librte_ether/rte_mtr.c:80:
+			ENOSYS,				\

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#233: FILE: lib/librte_ether/rte_mtr.c:83:
+			rte_strerror(ENOSYS));		\

total: 0 errors, 7 warnings, 1225 lines checked

           reply	other threads:[~2017-10-05 13:10 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1507208974-180500-4-git-send-email-cristian.dumitrescu@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171005131055.0CF721B212@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=cristian.dumitrescu@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).