From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 4E7351B269; Fri,  6 Oct 2017 20:14:53 +0200 (CEST)
In-Reply-To: <20171006181151.4758-2-akhil.goyal@nxp.com>
References: <20171006181151.4758-2-akhil.goyal@nxp.com>
To: test-report@dpdk.org
Cc: Akhil Goyal <akhil.goyal@nxp.com>
Message-Id: <20171006181453.4E7351B269@dpdk.org>
Date: Fri,  6 Oct 2017 20:14:53 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw29834 [PATCH v3 01/12]
	lib/rte_security: add security library
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Oct 2017 18:14:53 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29834

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#172: FILE: lib/librte_security/rte_security.c:68:
+#define RTE_SEC_VALID_ID_OR_ERR_RET(id, retval) do { \
+	if (!rte_security_is_valid_id(id)) { \
+		RTE_PMD_DEBUG_TRACE("Invalid sec_id=%d
", id); \
+		return retval; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#179: FILE: lib/librte_security/rte_security.c:75:
+#define RTE_SEC_VALID_ID_OR_RET(id) do { \
+	if (!rte_security_is_valid_id(id)) { \
+		RTE_PMD_DEBUG_TRACE("Invalid sec_id=%d
", id); \
+		return; \
+	} \
+} while (0)

total: 0 errors, 2 warnings, 1028 lines checked