From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id EA8591B1AB; Sun,  8 Oct 2017 14:45:32 +0200 (CEST)
In-Reply-To: <20171008124430.1866-3-santosh.shukla@caviumnetworks.com>
References: <20171008124430.1866-3-santosh.shukla@caviumnetworks.com>
To: test-report@dpdk.org
Cc: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Message-Id: <20171008124532.EA8591B1AB@dpdk.org>
Date: Sun,  8 Oct 2017 14:45:32 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw29895 [PATCH v2 02/26]
	net/octeontx/base: add octeontx io operations
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Oct 2017 12:45:33 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29895

_coding style issues_


WARNING:BAD_SIGN_OFF: Non-standard signature: Co-authored-by:
#21: 
Co-authored-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>

ERROR:SPACING: spaces required around that ':' (ctx:ExV)
#89: FILE: drivers/net/octeontx/base/octeontx_io.h:56:
+			:[x0]"=r"(val0), [x1]"=r"(val1) \
 			^

ERROR:SPACING: spaces required around that ':' (ctx:ExV)
#90: FILE: drivers/net/octeontx/base/octeontx_io.h:57:
+			:[p1]"r"(addr)			\
 			^

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'addr' - possible side-effects?
#102: FILE: drivers/net/octeontx/base/octeontx_io.h:69:
+#define octeontx_load_pair(val0, val1, addr)		\
+do {							\
+	val0 = rte_read64(addr);			\
+	val1 = rte_read64(((uint8_t *)addr) + 8);	\
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'addr' - possible side-effects?
#108: FILE: drivers/net/octeontx/base/octeontx_io.h:75:
+#define octeontx_store_pair(val0, val1, addr)		\
+do {							\
+	rte_write64(val0, addr);			\
+	rte_write64(val1, (((uint8_t *)addr) + 8));	\
+} while (0)

total: 2 errors, 1 warnings, 2 checks, 156 lines checked