From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Subject: [dpdk-test-report] |WARNING| pw29984 [PATCH v3 28/30] net/mlx5: handle RSS hash configuration in RSS flow
Date: Mon, 9 Oct 2017 16:52:23 +0200 (CEST) [thread overview]
Message-ID: <20171009145223.53D4E1B1C2@dpdk.org> (raw)
In-Reply-To: <b781b5bcba1d6317755e44a717a2e74fcf5363a4.1507560012.git.nelio.laranjeiro@6wind.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29984
_coding style issues_
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#253: FILE: drivers/net/mlx5/mlx5_flow.c:552:
+ return EINVAL;
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == parser->layer'
#554: FILE: drivers/net/mlx5/mlx5_flow.c:933:
+ if ((i == parser->layer) ||
+ (!parser->queue[i].ibv_attr))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '!parser->queue[i].ibv_attr'
#554: FILE: drivers/net/mlx5/mlx5_flow.c:933:
+ if ((i == parser->layer) ||
+ (!parser->queue[i].ibv_attr))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == HASH_RXQ_UDPV4'
#607: FILE: drivers/net/mlx5/mlx5_flow.c:986:
+ if ((i == HASH_RXQ_UDPV4) || (i == HASH_RXQ_TCPV4) ||
+ (i == HASH_RXQ_UDPV6) || (i == HASH_RXQ_TCPV6)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == HASH_RXQ_TCPV4'
#607: FILE: drivers/net/mlx5/mlx5_flow.c:986:
+ if ((i == HASH_RXQ_UDPV4) || (i == HASH_RXQ_TCPV4) ||
+ (i == HASH_RXQ_UDPV6) || (i == HASH_RXQ_TCPV6)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == HASH_RXQ_UDPV6'
#607: FILE: drivers/net/mlx5/mlx5_flow.c:986:
+ if ((i == HASH_RXQ_UDPV4) || (i == HASH_RXQ_TCPV4) ||
+ (i == HASH_RXQ_UDPV6) || (i == HASH_RXQ_TCPV6)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == HASH_RXQ_TCPV6'
#607: FILE: drivers/net/mlx5/mlx5_flow.c:986:
+ if ((i == HASH_RXQ_UDPV4) || (i == HASH_RXQ_TCPV4) ||
+ (i == HASH_RXQ_UDPV6) || (i == HASH_RXQ_TCPV6)) {
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#687: FILE: drivers/net/mlx5/mlx5_flow.c:1066:
+ return ENOMEM;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#699: FILE: drivers/net/mlx5/mlx5_flow.c:1078:
+ return ENOMEM;
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i != HASH_RXQ_ETH'
#709: FILE: drivers/net/mlx5/mlx5_flow.c:1088:
+ if (!(parser->rss_conf.rss_hf &
+ hash_rxq_init[i].dpdk_rss_hf) &&
+ (i != HASH_RXQ_ETH))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hash_rxq_init[parser->layer].ip_version ==
hash_rxq_init[i].ip_version'
#804: FILE: drivers/net/mlx5/mlx5_flow.c:1183:
+ if (parser->layer == HASH_RXQ_ETH ||
+ (hash_rxq_init[parser->layer].ip_version ==
+ hash_rxq_init[i].ip_version) ||
+ (hash_rxq_init[i].ip_version == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hash_rxq_init[i].ip_version == 0'
#804: FILE: drivers/net/mlx5/mlx5_flow.c:1183:
+ if (parser->layer == HASH_RXQ_ETH ||
+ (hash_rxq_init[parser->layer].ip_version ==
+ hash_rxq_init[i].ip_version) ||
+ (hash_rxq_init[i].ip_version == 0)) {
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#1382: FILE: drivers/net/mlx5/mlx5_flow.c:1661:
+ return ENOMEM;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#1840: FILE: drivers/net/mlx5/mlx5_flow.c:2277:
+ return EINVAL;
total: 0 errors, 5 warnings, 9 checks, 1767 lines checked
parent reply other threads:[~2017-10-09 14:52 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <b781b5bcba1d6317755e44a717a2e74fcf5363a4.1507560012.git.nelio.laranjeiro@6wind.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171009145223.53D4E1B1C2@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).