From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 53D4E1B1C2; Mon,  9 Oct 2017 16:52:23 +0200 (CEST)
In-Reply-To: <b781b5bcba1d6317755e44a717a2e74fcf5363a4.1507560012.git.nelio.laranjeiro@6wind.com>
References: <b781b5bcba1d6317755e44a717a2e74fcf5363a4.1507560012.git.nelio.laranjeiro@6wind.com>
To: test-report@dpdk.org
Cc: =?utf-8?q?N=C3=A9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>
Message-Id: <20171009145223.53D4E1B1C2@dpdk.org>
Date: Mon,  9 Oct 2017 16:52:23 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw29984 [PATCH v3 28/30] net/mlx5:
	handle RSS hash configuration in RSS flow
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Oct 2017 14:52:23 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29984

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#253: FILE: drivers/net/mlx5/mlx5_flow.c:552:
+		return EINVAL;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == parser->layer'
#554: FILE: drivers/net/mlx5/mlx5_flow.c:933:
+			if ((i == parser->layer) ||
+			     (!parser->queue[i].ibv_attr))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '!parser->queue[i].ibv_attr'
#554: FILE: drivers/net/mlx5/mlx5_flow.c:933:
+			if ((i == parser->layer) ||
+			     (!parser->queue[i].ibv_attr))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == HASH_RXQ_UDPV4'
#607: FILE: drivers/net/mlx5/mlx5_flow.c:986:
+		if ((i == HASH_RXQ_UDPV4) || (i == HASH_RXQ_TCPV4) ||
+		    (i == HASH_RXQ_UDPV6) || (i == HASH_RXQ_TCPV6)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == HASH_RXQ_TCPV4'
#607: FILE: drivers/net/mlx5/mlx5_flow.c:986:
+		if ((i == HASH_RXQ_UDPV4) || (i == HASH_RXQ_TCPV4) ||
+		    (i == HASH_RXQ_UDPV6) || (i == HASH_RXQ_TCPV6)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == HASH_RXQ_UDPV6'
#607: FILE: drivers/net/mlx5/mlx5_flow.c:986:
+		if ((i == HASH_RXQ_UDPV4) || (i == HASH_RXQ_TCPV4) ||
+		    (i == HASH_RXQ_UDPV6) || (i == HASH_RXQ_TCPV6)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == HASH_RXQ_TCPV6'
#607: FILE: drivers/net/mlx5/mlx5_flow.c:986:
+		if ((i == HASH_RXQ_UDPV4) || (i == HASH_RXQ_TCPV4) ||
+		    (i == HASH_RXQ_UDPV6) || (i == HASH_RXQ_TCPV6)) {

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#687: FILE: drivers/net/mlx5/mlx5_flow.c:1066:
+			return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#699: FILE: drivers/net/mlx5/mlx5_flow.c:1078:
+			return ENOMEM;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i != HASH_RXQ_ETH'
#709: FILE: drivers/net/mlx5/mlx5_flow.c:1088:
+			if (!(parser->rss_conf.rss_hf &
+			      hash_rxq_init[i].dpdk_rss_hf) &&
+			    (i != HASH_RXQ_ETH))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hash_rxq_init[parser->layer].ip_version ==
 		     hash_rxq_init[i].ip_version'
#804: FILE: drivers/net/mlx5/mlx5_flow.c:1183:
+		if (parser->layer == HASH_RXQ_ETH ||
+		    (hash_rxq_init[parser->layer].ip_version ==
+		     hash_rxq_init[i].ip_version) ||
+		    (hash_rxq_init[i].ip_version == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hash_rxq_init[i].ip_version == 0'
#804: FILE: drivers/net/mlx5/mlx5_flow.c:1183:
+		if (parser->layer == HASH_RXQ_ETH ||
+		    (hash_rxq_init[parser->layer].ip_version ==
+		     hash_rxq_init[i].ip_version) ||
+		    (hash_rxq_init[i].ip_version == 0)) {

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#1382: FILE: drivers/net/mlx5/mlx5_flow.c:1661:
+			return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#1840: FILE: drivers/net/mlx5/mlx5_flow.c:2277:
+		return EINVAL;

total: 0 errors, 5 warnings, 9 checks, 1767 lines checked