From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 9BD271B333; Tue, 10 Oct 2017 22:21:15 +0200 (CEST)
In-Reply-To: <1507666818-3784-1-git-send-email-matan@mellanox.com>
References: <1507666818-3784-1-git-send-email-matan@mellanox.com>
To: test-report@dpdk.org
Cc: Matan Azrad <matan@mellanox.com>
Message-Id: <20171010202115.9BD271B333@dpdk.org>
Date: Tue, 10 Oct 2017 22:21:15 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw30082 [PATCH v2] ethdev: add return
	value to stats get dev op
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Oct 2017 20:21:15 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/30082

_coding style issues_


CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#572: FILE: drivers/net/enic/enic.h:290:
+extern int enic_dev_stats_get(struct enic *enic,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_eth_dev *' should also have an identifier name
#901: FILE: drivers/net/mlx5/mlx5.h:239:
+int mlx5_stats_get(struct rte_eth_dev *, struct rte_eth_stats *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_eth_stats *' should also have an identifier name
#901: FILE: drivers/net/mlx5/mlx5.h:239:
+int mlx5_stats_get(struct rte_eth_dev *, struct rte_eth_stats *);

total: 0 errors, 2 warnings, 975 lines checked