From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 938F12B9A; Thu, 12 Oct 2017 10:18:44 +0200 (CEST)
In-Reply-To: <efd19ecd4006ca3366bfcc134b980393e31c688e.1507795823.git.gaetan.rivet@6wind.com>
References: <efd19ecd4006ca3366bfcc134b980393e31c688e.1507795823.git.gaetan.rivet@6wind.com>
To: test-report@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
Message-Id: <20171012081844.938F12B9A@dpdk.org>
Date: Thu, 12 Oct 2017 10:18:44 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw30182 [PATCH v4 10/16] pci: avoid
	inlining functions
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Oct 2017 08:18:44 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/30182

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#142: FILE: lib/librte_pci/rte_pci.c:57:
+#define GET_PCIADDR_FIELD(in, fd, lim, dlm)                     \
+do {                                                            \
+	unsigned long val;                                      \
+	char *end;                                              \
+	errno = 0;                                              \
+	val = strtoul((in), &end, 16);                          \
+	if (errno != 0 || end[0] != (dlm) || val > (lim))       \
+		return -EINVAL;                                 \
+	(fd) = (typeof (fd))val;                                \
+	(in) = end + 1;                                         \
+} while(0)

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#150: FILE: lib/librte_pci/rte_pci.c:65:
+	(fd) = (typeof (fd))val;                                \

ERROR:SPACING: space required before the open parenthesis '('
#152: FILE: lib/librte_pci/rte_pci.c:67:
+} while(0)

total: 1 errors, 2 warnings, 183 lines checked