From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 0F3BE1B610; Fri, 13 Oct 2017 07:58:03 +0200 (CEST) In-Reply-To: References: To: test-report@dpdk.org Cc: "Zhao, Bing" Message-Id: <20171013055803.0F3BE1B610@dpdk.org> Date: Fri, 13 Oct 2017 07:58:03 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw30333 [PATCH] ring: guarantee ordering of cons/prod loading when doing enqueue/dequeue X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 05:58:03 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/30333 _coding style issues_ ERROR:DIFF_IN_COMMIT_MSG: Avoid using diff content in the commit message - patch(1) might not work #67: @@ -719,6 +727,7 @@ test_refcnt_iter(unsigned int lcore, unsigned int iter, WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #68:             i != n && (m = rte_pktmbuf_alloc(refcnt_pool)) != NULL; ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files #224: FILE: lib/librte_mbuf/rte_mbuf.c ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?) #229: FILE: lib/librte_mbuf/rte_mbuf.c:242: unsigned dump_len) ERROR:TRAILING_WHITESPACE: trailing whitespace #236: FILE: lib/librte_mbuf/rte_mbuf.c:247: +              m, (uint64_t)m->buf_physaddr, (unsigned)m->buf_len, $ WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #236: FILE: lib/librte_mbuf/rte_mbuf.c:247: +              m, (uint64_t)m->buf_physaddr, (unsigned)m->buf_len, ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files #243: FILE: lib/librte_ring/rte_ring.h WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0) #269: FILE: lib/librte_ring/rte_ring.h:537: +               if (*new_head > prod_tail) //|| r->cons.head > r->prod.tail) +                       rte_panic("bizhao %u %#x %#x %#x %#x %#x ", ERROR:TRAILING_WHITESPACE: trailing whitespace #270: FILE: lib/librte_ring/rte_ring.h:538: +                       rte_panic("bizhao %u %#x %#x %#x %#x %#x ", $ ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files #277: FILE: test/test/test_mbuf.c ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #287: FILE: test/test/test_mbuf.c:75: +#define REFCNT_MAX_ITER         32 ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #292: FILE: test/test/test_mbuf.c:78: +#define REFCNT_MAX_REF          512 ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #293: FILE: test/test/test_mbuf.c:79: +#define REFCNT_MBUF_NUM         1 WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0) #304: FILE: test/test/test_mbuf.c:691:         while (refcnt_stop_slaves == 0) { +               ava = rte_ring_dequeue_bulk(refcnt_mbuf_ring, &mp ,1, NULL); ERROR:SPACING: space prohibited before that ',' (ctx:WxV) #306: FILE: test/test/test_mbuf.c:692: +               ava = rte_ring_dequeue_bulk(refcnt_mbuf_ring, &mp ,1, NULL); ^ ERROR:SPACING: space required after that ',' (ctx:WxV) #306: FILE: test/test/test_mbuf.c:692: +               ava = rte_ring_dequeue_bulk(refcnt_mbuf_ring, &mp ,1, NULL); ^ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0) #307: FILE: test/test/test_mbuf.c:693: +               if (ava > 0) { +                       if (ava > 10) { WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0) #308: FILE: test/test/test_mbuf.c:694: +                       if (ava > 10) { +                               rte_panic("OMG %u %u ", ERROR:TRAILING_WHITESPACE: trailing whitespace #309: FILE: test/test/test_mbuf.c:695: +                               rte_panic("OMG %u %u ", $ ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) total: 14 errors, 6 warnings, 72 lines checked