From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 23B331B614; Fri, 13 Oct 2017 08:23:07 +0200 (CEST)
In-Reply-To: <188971FCDA171749BED5DA74ABF3E6F03C0E2252@SHSMSX104.ccr.corp.intel.com>
References: <188971FCDA171749BED5DA74ABF3E6F03C0E2252@SHSMSX104.ccr.corp.intel.com>
To: test-report@dpdk.org
Cc: "Pei, Yulong" <yulong.pei@intel.com>
Message-Id: <20171013062307.23B331B614@dpdk.org>
Date: Fri, 13 Oct 2017 08:23:07 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw30334 [PATCH v7 1/3] app/test-pmd:
	add CLI for TM capability and stats
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Oct 2017 06:23:07 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/30334

_coding style issues_


WARNING:BAD_SIGN_OFF: email address 'Yulong Pei  <yulong.pei@intel.com>' might be better as 'Yulong Pei <yulong.pei@intel.com>'
#19: 
Tested-by: Yulong Pei  <yulong.pei@intel.com>

WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#25: 
Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Pei, Yulong <yulong.pei@intel.com>

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#210: FILE: app/test-pmd/cmdline_tm.c:46:
+static void
+print_err_msg(struct rte_tm_error *error) {

ERROR:TRAILING_WHITESPACE: trailing whitespace
#414: FILE: app/test-pmd/cmdline_tm.c:250:
+/* *** Port TM Hierarchical Level Capability *** */ struct $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#540: FILE: app/test-pmd/cmdline_tm.c:376:
+/* *** Port TM Hierarchy Node Capability *** */ struct $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#649: FILE: app/test-pmd/cmdline_tm.c:485:
+/* *** Show Port TM Node Statistics *** */ struct $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#663: FILE: app/test-pmd/cmdline_tm.c:499:
+^I^Istruct cmd_show_port_tm_node_stats_result, show, "show"); $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#666: FILE: app/test-pmd/cmdline_tm.c:502:
+^I^Istruct cmd_show_port_tm_node_stats_result, port, "port"); $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#669: FILE: app/test-pmd/cmdline_tm.c:505:
+^I^Istruct cmd_show_port_tm_node_stats_result, tm, "tm"); $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#672: FILE: app/test-pmd/cmdline_tm.c:508:
+^I^Istruct cmd_show_port_tm_node_stats_result, node, "node"); $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#675: FILE: app/test-pmd/cmdline_tm.c:511:
+^I^Istruct cmd_show_port_tm_node_stats_result, stats, "stats"); $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#780: FILE: app/test-pmd/cmdline_tm.c:616:
+^I^Istruct cmd_show_port_tm_node_type_result, show, "show"); $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#783: FILE: app/test-pmd/cmdline_tm.c:619:
+^I^Istruct cmd_show_port_tm_node_type_result, port, "port"); $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#786: FILE: app/test-pmd/cmdline_tm.c:622:
+^I^Istruct cmd_show_port_tm_node_type_result, tm, "tm"); $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#789: FILE: app/test-pmd/cmdline_tm.c:625:
+^I^Istruct cmd_show_port_tm_node_type_result, node, "node"); $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#792: FILE: app/test-pmd/cmdline_tm.c:628:
+^I^Istruct cmd_show_port_tm_node_type_result, type, "type"); $

total: 14 errors, 2 warnings, 724 lines checked