From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 81E771B3D0; Sun, 15 Oct 2017 00:22:03 +0200 (CEST) In-Reply-To: <20171014221734.15511-11-akhil.goyal@nxp.com> References: <20171014221734.15511-11-akhil.goyal@nxp.com> To: test-report@dpdk.org Cc: Akhil Goyal Message-Id: <20171014222203.81E771B3D0@dpdk.org> Date: Sun, 15 Oct 2017 00:22:03 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw30414 [PATCH v4 10/12] net/ixgbe: enable inline ipsec X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Oct 2017 22:22:03 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/30414 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects? #77: FILE: drivers/net/ixgbe/base/ixgbe_osdep.h:164: +#define IXGBE_WRITE_REG_THEN_POLL_MASK(hw, reg, val, mask, poll_ms) \ +{ \ + uint32_t cnt = poll_ms; \ + IXGBE_WRITE_REG(hw, (reg), (val)); \ + while (((IXGBE_READ_REG(hw, (reg))) & (mask)) && (cnt--)) \ + rte_delay_ms(1); \ +} CHECK:MACRO_ARG_REUSE: Macro argument reuse 'reg' - possible side-effects? #77: FILE: drivers/net/ixgbe/base/ixgbe_osdep.h:164: +#define IXGBE_WRITE_REG_THEN_POLL_MASK(hw, reg, val, mask, poll_ms) \ +{ \ + uint32_t cnt = poll_ms; \ + IXGBE_WRITE_REG(hw, (reg), (val)); \ + while (((IXGBE_READ_REG(hw, (reg))) & (mask)) && (cnt--)) \ + rte_delay_ms(1); \ +} CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects? #328: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:62: +#define CMP_IP(a, b) (\ + (a).ipv6[0] == (b).ipv6[0] && \ + (a).ipv6[1] == (b).ipv6[1] && \ + (a).ipv6[2] == (b).ipv6[2] && \ + (a).ipv6[3] == (b).ipv6[3]) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects? #328: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:62: +#define CMP_IP(a, b) (\ + (a).ipv6[0] == (b).ipv6[0] && \ + (a).ipv6[1] == (b).ipv6[1] && \ + (a).ipv6[2] == (b).ipv6[2] && \ + (a).ipv6[3] == (b).ipv6[3]) CHECK:CAMELCASE: Avoid CamelCase: #456: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:190: + if (ic_session->dst_ip.type == IPv6) CHECK:CAMELCASE: Avoid CamelCase: #463: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:197: + if (priv->rx_ip_tbl[ip_index].ip.type == IPv4) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'txq->tx_rs_thresh >= RTE_PMD_IXGBE_TX_MAX_BURST' #1272: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:2398: + if (((txq->txq_flags & IXGBE_SIMPLE_FLAGS) == IXGBE_SIMPLE_FLAGS) && + (txq->tx_rs_thresh >= RTE_PMD_IXGBE_TX_MAX_BURST) && + !(dev->data->dev_conf.txmode.enable_sec)) { total: 0 errors, 0 warnings, 7 checks, 1317 lines checked