From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 4A5451B6E1; Wed, 18 Oct 2017 04:15:48 +0200 (CEST)
In-Reply-To: <1508292886-31405-3-git-send-email-amr.mokhtar@intel.com>
References: <1508292886-31405-3-git-send-email-amr.mokhtar@intel.com>
To: test-report@dpdk.org
Cc: Amr Mokhtar <amr.mokhtar@intel.com>
Message-Id: <20171018021548.4A5451B6E1@dpdk.org>
Date: Wed, 18 Oct 2017 04:15:48 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw30500 [PATCH v2 3/5] bbdev: test
	applications
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Oct 2017 02:15:48 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/30500

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#506: FILE: app/test-bbdev/main.h:49:
+#define TEST_ASSERT(cond, msg, ...) do {  \
+		if (!(cond)) {  \
+			printf("TestCase %s() line %d failed: " \
+				msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+			return TEST_FAILED;  \
+		} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#515: FILE: app/test-bbdev/main.h:58:
+#define TEST_ASSERT_BUFFERS_ARE_EQUAL(a, b, len, msg, ...) do { \
+	if (memcmp((a), (b), len)) { \
+		printf("TestCase %s() line %d failed: " \
+			msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+		rte_memdump(stdout, "Buffer A", (a), len); \
+		rte_memdump(stdout, "Buffer B", (b), len); \
+		return TEST_FAILED; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#525: FILE: app/test-bbdev/main.h:68:
+#define TEST_ASSERT_SUCCESS(val, msg, ...) do { \
+		typeof(val) _val = (val); \
+		if (!(_val == 0)) { \
+			printf("TestCase %s() line %d failed (err %d): " \
+				msg "
", __func__, __LINE__, _val, \
+				##__VA_ARGS__); \
+			return TEST_FAILED; \
+		} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#538: FILE: app/test-bbdev/main.h:81:
+#define TEST_ASSERT_NOT_NULL(val, msg, ...) do { \
+		if ((val) == NULL) { \
+			printf("TestCase %s() line %d failed (null): " \
+				msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+			return TEST_FAILED;  \
+		} \
+} while (0)

WARNING:TYPO_SPELLING: 'INITALIZED' may be misspelled - perhaps 'INITIALIZED'?
#1600: FILE: app/test-bbdev/test_bbdev.c:855:
+	TEST_ASSERT(dev1->state == RTE_BBDEV_INITALIZED,

WARNING:TYPO_SPELLING: 'INITALIZED' may be misspelled - perhaps 'INITIALIZED'?
#1602: FILE: app/test-bbdev/test_bbdev.c:857:
+			"invalid state %d (0 - RTE_BBDEV_UNUSED, 1 - RTE_BBDEV_INITALIZED",

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'vector->entries[DATA_INPUT].segments[i].addr'
#4872: FILE: app/test-bbdev/test_bbdev_vector.c:619:
+		if (vector->entries[DATA_INPUT].
+				segments[i].addr == NULL)

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'vector->entries[DATA_HARD_OUTPUT].segments[i].addr'
#4881: FILE: app/test-bbdev/test_bbdev_vector.c:628:
+		if (vector->entries[DATA_HARD_OUTPUT].
+				segments[i].addr == NULL)

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'vector->entries[DATA_SOFT_OUTPUT].segments[i].addr'
#4891: FILE: app/test-bbdev/test_bbdev_vector.c:638:
+		if (vector->entries[DATA_SOFT_OUTPUT].
+				segments[i].addr == NULL)

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'vector->entries[DATA_INPUT].segments[i].addr'
#4969: FILE: app/test-bbdev/test_bbdev_vector.c:716:
+		if (vector->entries[DATA_INPUT].
+				segments[i].addr == NULL)

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'vector->entries[DATA_HARD_OUTPUT].segments[i].addr'
#4978: FILE: app/test-bbdev/test_bbdev_vector.c:725:
+		if (vector->entries[DATA_HARD_OUTPUT].
+				segments[i].addr == NULL)

WARNING:TYPO_SPELLING: 'paramaters' may be misspelled - perhaps 'parameters'?
#5235: FILE: app/test-bbdev/test_bbdev_vector.h:92:
+/* fills test vector paramaters based on test file */

total: 0 errors, 12 warnings, 5304 lines checked