From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jingjing Wu <jingjing.wu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw30625 [PATCH RFC 2/9] net/avf: initilization of avf PMD
Date: Fri, 20 Oct 2017 10:36:33 +0200 (CEST) [thread overview]
Message-ID: <20171020083633.494BF1B1F0@dpdk.org> (raw)
In-Reply-To: <1508488012-82704-3-git-send-email-jingjing.wu@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/30625
_coding style issues_
WARNING:TYPO_SPELLING: 'initilization' may be misspelled - perhaps 'initialization'?
#5:
Subject: [dpdk-dev] [PATCH RFC 2/9] net/avf: initilization of avf PMD
WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon
#645: FILE: drivers/net/avf/avf_ethdev.c:254:
+ hw->back = AVF_DEV_PRIVATE_TO_ADAPTER(eth_dev->data->dev_private);;
CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#778: FILE: drivers/net/avf/avf_ethdev.c:387:
+ snprintf(z_name, sizeof(z_name), "avf_dma_%"PRIu64, rte_rand());
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#778: FILE: drivers/net/avf/avf_ethdev.c:387:
+ snprintf(z_name, sizeof(z_name), "avf_dma_%"PRIu64, rte_rand());
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#789: FILE: drivers/net/avf/avf_ethdev.c:398:
+ "memzone %s allocated with physical address: %"PRIu64,
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#803: FILE: drivers/net/avf/avf_ethdev.c:412:
+ "memzone %s to be freed with physical address: %"PRIu64,
WARNING:RETURN_VOID: void function return statements are not generally useful
#866: FILE: drivers/net/avf/avf_ethdev.c:475:
+ return;
+}
CHECK:BRACES: Unbalanced braces around else statement
#1081: FILE: drivers/net/avf/avf_vchnl.c:209:
+ } else
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vf->virtchnl_version.major < VIRTCHNL_VERSION_MAJOR_START'
#1132: FILE: drivers/net/avf/avf_vchnl.c:260:
+ if ((vf->virtchnl_version.major < VIRTCHNL_VERSION_MAJOR_START) ||
+ ((vf->virtchnl_version.major == VIRTCHNL_VERSION_MAJOR_START) &&
+ (vf->virtchnl_version.minor < VIRTCHNL_VERSION_MINOR_START))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vf->virtchnl_version.major == VIRTCHNL_VERSION_MAJOR_START'
#1132: FILE: drivers/net/avf/avf_vchnl.c:260:
+ if ((vf->virtchnl_version.major < VIRTCHNL_VERSION_MAJOR_START) ||
+ ((vf->virtchnl_version.major == VIRTCHNL_VERSION_MAJOR_START) &&
+ (vf->virtchnl_version.minor < VIRTCHNL_VERSION_MINOR_START))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vf->virtchnl_version.minor < VIRTCHNL_VERSION_MINOR_START'
#1132: FILE: drivers/net/avf/avf_vchnl.c:260:
+ if ((vf->virtchnl_version.major < VIRTCHNL_VERSION_MAJOR_START) ||
+ ((vf->virtchnl_version.major == VIRTCHNL_VERSION_MAJOR_START) &&
+ (vf->virtchnl_version.minor < VIRTCHNL_VERSION_MINOR_START))) {
CHECK:BRACES: braces {} should be used on all arms of this statement
#1132: FILE: drivers/net/avf/avf_vchnl.c:260:
+ if ((vf->virtchnl_version.major < VIRTCHNL_VERSION_MAJOR_START) ||
[...]
+ } else if ((vf->virtchnl_version.major > VIRTCHNL_VERSION_MAJOR) ||
[...]
+ } else
[...]
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1149: FILE: drivers/net/avf/avf_vchnl.c:277:
+ return -1;
+ } else
CHECK:BRACES: Unbalanced braces around else statement
#1149: FILE: drivers/net/avf/avf_vchnl.c:277:
+ } else
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1169: FILE: drivers/net/avf/avf_vchnl.c:297:
+ /* TODO: basic offload capabilities, need to
+ * add advanced/optional offload capabilities
total: 0 errors, 5 warnings, 1153 lines checked
parent reply other threads:[~2017-10-20 8:36 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1508488012-82704-3-git-send-email-jingjing.wu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020083633.494BF1B1F0@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).