From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 494BF1B1F0; Fri, 20 Oct 2017 10:36:33 +0200 (CEST)
In-Reply-To: <1508488012-82704-3-git-send-email-jingjing.wu@intel.com>
References: <1508488012-82704-3-git-send-email-jingjing.wu@intel.com>
To: test-report@dpdk.org
Cc: Jingjing Wu <jingjing.wu@intel.com>
Message-Id: <20171020083633.494BF1B1F0@dpdk.org>
Date: Fri, 20 Oct 2017 10:36:33 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw30625 [PATCH RFC 2/9] net/avf:
	initilization of avf PMD
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Oct 2017 08:36:33 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/30625

_coding style issues_


WARNING:TYPO_SPELLING: 'initilization' may be misspelled - perhaps 'initialization'?
#5: 
Subject: [dpdk-dev] [PATCH RFC 2/9] net/avf: initilization of avf PMD

WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon
#645: FILE: drivers/net/avf/avf_ethdev.c:254:
+	hw->back = AVF_DEV_PRIVATE_TO_ADAPTER(eth_dev->data->dev_private);;

CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#778: FILE: drivers/net/avf/avf_ethdev.c:387:
+	snprintf(z_name, sizeof(z_name), "avf_dma_%"PRIu64, rte_rand());

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#778: FILE: drivers/net/avf/avf_ethdev.c:387:
+	snprintf(z_name, sizeof(z_name), "avf_dma_%"PRIu64, rte_rand());

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#789: FILE: drivers/net/avf/avf_ethdev.c:398:
+		"memzone %s allocated with physical address: %"PRIu64,

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#803: FILE: drivers/net/avf/avf_ethdev.c:412:
+		"memzone %s to be freed with physical address: %"PRIu64,

WARNING:RETURN_VOID: void function return statements are not generally useful
#866: FILE: drivers/net/avf/avf_ethdev.c:475:
+	return;
+}

CHECK:BRACES: Unbalanced braces around else statement
#1081: FILE: drivers/net/avf/avf_vchnl.c:209:
+				} else

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vf->virtchnl_version.major < VIRTCHNL_VERSION_MAJOR_START'
#1132: FILE: drivers/net/avf/avf_vchnl.c:260:
+	if ((vf->virtchnl_version.major < VIRTCHNL_VERSION_MAJOR_START) ||
+	    ((vf->virtchnl_version.major == VIRTCHNL_VERSION_MAJOR_START) &&
+	     (vf->virtchnl_version.minor < VIRTCHNL_VERSION_MINOR_START))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vf->virtchnl_version.major == VIRTCHNL_VERSION_MAJOR_START'
#1132: FILE: drivers/net/avf/avf_vchnl.c:260:
+	if ((vf->virtchnl_version.major < VIRTCHNL_VERSION_MAJOR_START) ||
+	    ((vf->virtchnl_version.major == VIRTCHNL_VERSION_MAJOR_START) &&
+	     (vf->virtchnl_version.minor < VIRTCHNL_VERSION_MINOR_START))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vf->virtchnl_version.minor < VIRTCHNL_VERSION_MINOR_START'
#1132: FILE: drivers/net/avf/avf_vchnl.c:260:
+	if ((vf->virtchnl_version.major < VIRTCHNL_VERSION_MAJOR_START) ||
+	    ((vf->virtchnl_version.major == VIRTCHNL_VERSION_MAJOR_START) &&
+	     (vf->virtchnl_version.minor < VIRTCHNL_VERSION_MINOR_START))) {

CHECK:BRACES: braces {} should be used on all arms of this statement
#1132: FILE: drivers/net/avf/avf_vchnl.c:260:
+	if ((vf->virtchnl_version.major < VIRTCHNL_VERSION_MAJOR_START) ||
[...]
+	} else if ((vf->virtchnl_version.major > VIRTCHNL_VERSION_MAJOR) ||
[...]
+	} else
[...]

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1149: FILE: drivers/net/avf/avf_vchnl.c:277:
+		return -1;
+	} else

CHECK:BRACES: Unbalanced braces around else statement
#1149: FILE: drivers/net/avf/avf_vchnl.c:277:
+	} else

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1169: FILE: drivers/net/avf/avf_vchnl.c:297:
+	/* TODO: basic offload capabilities, need to
+	  * add advanced/optional offload capabilities

total: 0 errors, 5 warnings, 1153 lines checked