From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 4D4801B28B; Fri, 20 Oct 2017 18:01:14 +0200 (CEST) In-Reply-To: <1508488012-82704-2-git-send-email-jingjing.wu@intel.com> References: <1508488012-82704-2-git-send-email-jingjing.wu@intel.com> To: test-report@dpdk.org Cc: Jingjing Wu Message-Id: <20171020160114.4D4801B28B@dpdk.org> Date: Fri, 20 Oct 2017 18:01:14 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw30652 [PATCH RFC 1/9] net/avf/base: add base code for avf PMD X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Oct 2017 16:01:14 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/30652 _coding style issues_ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #114: FILE: drivers/net/avf/base/avf_adminq.c:2: +/******************************************************************************* + CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->aq.num_asq_entries == 0' #489: FILE: drivers/net/avf/base/avf_adminq.c:377: + if ((hw->aq.num_asq_entries == 0) || + (hw->aq.asq_buf_size == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->aq.asq_buf_size == 0' #489: FILE: drivers/net/avf/base/avf_adminq.c:377: + if ((hw->aq.num_asq_entries == 0) || + (hw->aq.asq_buf_size == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->aq.num_arq_entries == 0' #548: FILE: drivers/net/avf/base/avf_adminq.c:436: + if ((hw->aq.num_arq_entries == 0) || + (hw->aq.arq_buf_size == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->aq.arq_buf_size == 0' #548: FILE: drivers/net/avf/base/avf_adminq.c:436: + if ((hw->aq.num_arq_entries == 0) || + (hw->aq.arq_buf_size == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->aq.num_arq_entries == 0' #667: FILE: drivers/net/avf/base/avf_adminq.c:555: + if ((hw->aq.num_arq_entries == 0) || + (hw->aq.num_asq_entries == 0) || + (hw->aq.arq_buf_size == 0) || + (hw->aq.asq_buf_size == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->aq.num_asq_entries == 0' #667: FILE: drivers/net/avf/base/avf_adminq.c:555: + if ((hw->aq.num_arq_entries == 0) || + (hw->aq.num_asq_entries == 0) || + (hw->aq.arq_buf_size == 0) || + (hw->aq.asq_buf_size == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->aq.arq_buf_size == 0' #667: FILE: drivers/net/avf/base/avf_adminq.c:555: + if ((hw->aq.num_arq_entries == 0) || + (hw->aq.num_asq_entries == 0) || + (hw->aq.arq_buf_size == 0) || + (hw->aq.asq_buf_size == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->aq.asq_buf_size == 0' #667: FILE: drivers/net/avf/base/avf_adminq.c:555: + if ((hw->aq.num_arq_entries == 0) || + (hw->aq.num_asq_entries == 0) || + (hw->aq.arq_buf_size == 0) || + (hw->aq.asq_buf_size == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around hw->aq.asq #738: FILE: drivers/net/avf/base/avf_adminq.c:626: + struct avf_adminq_ring *asq = &(hw->aq.asq); CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #785: FILE: drivers/net/avf/base/avf_adminq.c:673: + +} CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around hw->aq.asq.r.asq_bi[hw->aq.asq.next_to_use] #899: FILE: drivers/net/avf/base/avf_adminq.c:787: + dma_buff = &(hw->aq.asq.r.asq_bi[hw->aq.asq.next_to_use]); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '!cmd_completed' #976: FILE: drivers/net/avf/base/avf_adminq.c:864: + if ((!cmd_completed) && + (!details->async && !details->postpone)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'e->msg_len != 0' #1074: FILE: drivers/net/avf/base/avf_adminq.c:962: + if (e->msg_buf != NULL && (e->msg_len != 0)) WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #1122: FILE: drivers/net/avf/base/avf_adminq.h:2: +/******************************************************************************* + WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else #1261: FILE: drivers/net/avf/base/avf_adminq.h:141: + -ENOSYS, /* AVF_AQ_RC_ENOSYS */ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #1297: FILE: drivers/net/avf/base/avf_adminq_cmd.h:2: +/******************************************************************************* + CHECK:MACRO_ARG_REUSE: Macro argument reuse 'n' - possible side-effects? #1634: FILE: drivers/net/avf/base/avf_adminq_cmd.h:339: +#define AVF_CHECK_STRUCT_LEN(n, X) enum avf_static_assert_enum_##X \ + { avf_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) } CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #1635: FILE: drivers/net/avf/base/avf_adminq_cmd.h:340: + { avf_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) } ^ WARNING:TYPO_SPELLING: 'capabilites' may be misspelled - perhaps 'capabilities'? #1709: FILE: drivers/net/avf/base/avf_adminq_cmd.h:414: +struct avf_aqc_list_capabilites { WARNING:TYPO_SPELLING: 'capabilites' may be misspelled - perhaps 'capabilities'? #1719: FILE: drivers/net/avf/base/avf_adminq_cmd.h:424: +AVF_CHECK_CMD_LENGTH(avf_aqc_list_capabilites); WARNING:TYPO_SPELLING: 'addres' may be misspelled - perhaps 'address'? #3481: FILE: drivers/net/avf/base/avf_adminq_cmd.h:2186: + u8 dev_addres; WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #4110: FILE: drivers/net/avf/base/avf_alloc.h:2: +/******************************************************************************* + WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #4181: FILE: drivers/net/avf/base/avf_common.c:2: +/******************************************************************************* + WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'avf_set_mac_type', this function's name, in a string #4230: FILE: drivers/net/avf/base/avf_common.c:51: + DEBUGFUNC("avf_set_mac_type "); WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'avf_set_mac_type', this function's name, in a string #4248: FILE: drivers/net/avf/base/avf_common.c:69: + DEBUGOUT2("avf_set_mac_type found mac: %d, returns: %d ", CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'desc == NULL' #4477: FILE: drivers/net/avf/base/avf_common.c:298: + if ((!(mask & hw->debug_mask)) || (desc == NULL)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'buffer != NULL' #4498: FILE: drivers/net/avf/base/avf_common.c:319: + if ((buffer != NULL) && (aq_desc->datalen != 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'aq_desc->datalen != 0' #4498: FILE: drivers/net/avf/base/avf_common.c:319: + if ((buffer != NULL) && (aq_desc->datalen != 0)) { CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #4506: FILE: drivers/net/avf/base/avf_common.c:327: + i, buf[i], buf[i+1], buf[i+2], buf[i+3], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #4506: FILE: drivers/net/avf/base/avf_common.c:327: + i, buf[i], buf[i+1], buf[i+2], buf[i+3], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #4506: FILE: drivers/net/avf/base/avf_common.c:327: + i, buf[i], buf[i+1], buf[i+2], buf[i+3], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #4507: FILE: drivers/net/avf/base/avf_common.c:328: + buf[i+4], buf[i+5], buf[i+6], buf[i+7], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #4507: FILE: drivers/net/avf/base/avf_common.c:328: + buf[i+4], buf[i+5], buf[i+6], buf[i+7], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #4507: FILE: drivers/net/avf/base/avf_common.c:328: + buf[i+4], buf[i+5], buf[i+6], buf[i+7], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #4507: FILE: drivers/net/avf/base/avf_common.c:328: + buf[i+4], buf[i+5], buf[i+6], buf[i+7], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #4508: FILE: drivers/net/avf/base/avf_common.c:329: + buf[i+8], buf[i+9], buf[i+10], buf[i+11], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #4508: FILE: drivers/net/avf/base/avf_common.c:329: + buf[i+8], buf[i+9], buf[i+10], buf[i+11], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #4508: FILE: drivers/net/avf/base/avf_common.c:329: + buf[i+8], buf[i+9], buf[i+10], buf[i+11], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #4508: FILE: drivers/net/avf/base/avf_common.c:329: + buf[i+8], buf[i+9], buf[i+10], buf[i+11], ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #4509: FILE: drivers/net/avf/base/avf_common.c:330: + buf[i+12], buf[i+13], buf[i+14], buf[i+15]); ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #4509: FILE: drivers/net/avf/base/avf_common.c:330: + buf[i+12], buf[i+13], buf[i+14], buf[i+15]); ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #4509: FILE: drivers/net/avf/base/avf_common.c:330: + buf[i+12], buf[i+13], buf[i+14], buf[i+15]); ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #4509: FILE: drivers/net/avf/base/avf_common.c:330: + buf[i+12], buf[i+13], buf[i+14], buf[i+15]); ^ WARNING:TYPO_SPELLING: 'addres' may be misspelled - perhaps 'address'? #5274: FILE: drivers/net/avf/base/avf_common.c:1095: + cmd->dev_addres = dev_addr; WARNING:TYPO_SPELLING: 'addres' may be misspelled - perhaps 'address'? #5308: FILE: drivers/net/avf/base/avf_common.c:1129: + cmd->dev_addres = dev_addr; WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #5584: FILE: drivers/net/avf/base/avf_common.c:1405: +/** +* avf_aq_clear_all_wol_filters CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == dev_cnt' #5838: FILE: drivers/net/avf/base/avf_common.c:1659: + if (dev_cnt && (i == dev_cnt)) { WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #6030: FILE: drivers/net/avf/base/avf_devids.h:2: +/******************************************************************************* + WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #6079: FILE: drivers/net/avf/base/avf_hmc.h:2: +/******************************************************************************* + CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects? #6206: FILE: drivers/net/avf/base/avf_hmc.h:129: +#define AVF_SET_PF_SD_ENTRY(hw, pa, sd_index, type) \ +{ \ + u32 val1, val2, val3; \ + val1 = (u32)(AVF_HI_DWORD(pa)); \ + val2 = (u32)(pa) | (AVF_HMC_MAX_BP_COUNT << \ + AVF_PFHMC_SDDATALOW_PMSDBPCOUNT_SHIFT) | \ + ((((type) == AVF_SD_TYPE_PAGED) ? 0 : 1) << \ + AVF_PFHMC_SDDATALOW_PMSDTYPE_SHIFT) | \ + BIT(AVF_PFHMC_SDDATALOW_PMSDVALID_SHIFT); \ + val3 = (sd_index) | BIT_ULL(AVF_PFHMC_SDCMD_PMSDWR_SHIFT); \ + wr32((hw), AVF_PFHMC_SDDATAHIGH, val1); \ + wr32((hw), AVF_PFHMC_SDDATALOW, val2); \ + wr32((hw), AVF_PFHMC_SDCMD, val3); \ +} CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pa' - possible side-effects? #6206: FILE: drivers/net/avf/base/avf_hmc.h:129: +#define AVF_SET_PF_SD_ENTRY(hw, pa, sd_index, type) \ +{ \ + u32 val1, val2, val3; \ + val1 = (u32)(AVF_HI_DWORD(pa)); \ + val2 = (u32)(pa) | (AVF_HMC_MAX_BP_COUNT << \ + AVF_PFHMC_SDDATALOW_PMSDBPCOUNT_SHIFT) | \ + ((((type) == AVF_SD_TYPE_PAGED) ? 0 : 1) << \ + AVF_PFHMC_SDDATALOW_PMSDTYPE_SHIFT) | \ + BIT(AVF_PFHMC_SDDATALOW_PMSDVALID_SHIFT); \ + val3 = (sd_index) | BIT_ULL(AVF_PFHMC_SDCMD_PMSDWR_SHIFT); \ + wr32((hw), AVF_PFHMC_SDDATAHIGH, val1); \ + wr32((hw), AVF_PFHMC_SDDATALOW, val2); \ + wr32((hw), AVF_PFHMC_SDCMD, val3); \ +} CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects? #6227: FILE: drivers/net/avf/base/avf_hmc.h:150: +#define AVF_CLEAR_PF_SD_ENTRY(hw, sd_index, type) \ +{ \ + u32 val2, val3; \ + val2 = (AVF_HMC_MAX_BP_COUNT << \ + AVF_PFHMC_SDDATALOW_PMSDBPCOUNT_SHIFT) | \ + ((((type) == AVF_SD_TYPE_PAGED) ? 0 : 1) << \ + AVF_PFHMC_SDDATALOW_PMSDTYPE_SHIFT); \ + val3 = (sd_index) | BIT_ULL(AVF_PFHMC_SDCMD_PMSDWR_SHIFT); \ + wr32((hw), AVF_PFHMC_SDDATAHIGH, 0); \ + wr32((hw), AVF_PFHMC_SDDATALOW, val2); \ + wr32((hw), AVF_PFHMC_SDCMD, val3); \ +} CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hmc_info' - possible side-effects? #6263: FILE: drivers/net/avf/base/avf_hmc.h:186: +#define AVF_FIND_SD_INDEX_LIMIT(hmc_info, type, index, cnt, sd_idx, sd_limit)\ +{ \ + u64 fpm_addr, fpm_limit; \ + fpm_addr = (hmc_info)->hmc_obj[(type)].base + \ + (hmc_info)->hmc_obj[(type)].size * (index); \ + fpm_limit = fpm_addr + (hmc_info)->hmc_obj[(type)].size * (cnt);\ + *(sd_idx) = (u32)(fpm_addr / AVF_HMC_DIRECT_BP_SIZE); \ + *(sd_limit) = (u32)((fpm_limit - 1) / AVF_HMC_DIRECT_BP_SIZE); \ + /* add one more to the limit to correct our range */ \ + *(sd_limit) += 1; \ +} CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sd_limit' - possible side-effects? #6263: FILE: drivers/net/avf/base/avf_hmc.h:186: +#define AVF_FIND_SD_INDEX_LIMIT(hmc_info, type, index, cnt, sd_idx, sd_limit)\ +{ \ + u64 fpm_addr, fpm_limit; \ + fpm_addr = (hmc_info)->hmc_obj[(type)].base + \ + (hmc_info)->hmc_obj[(type)].size * (index); \ + fpm_limit = fpm_addr + (hmc_info)->hmc_obj[(type)].size * (cnt);\ + *(sd_idx) = (u32)(fpm_addr / AVF_HMC_DIRECT_BP_SIZE); \ + *(sd_limit) = (u32)((fpm_limit - 1) / AVF_HMC_DIRECT_BP_SIZE); \ + /* add one more to the limit to correct our range */ \ + *(sd_limit) += 1; \ +} CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hmc_info' - possible side-effects? #6287: FILE: drivers/net/avf/base/avf_hmc.h:210: +#define AVF_FIND_PD_INDEX_LIMIT(hmc_info, type, idx, cnt, pd_index, pd_limit)\ +{ \ + u64 fpm_adr, fpm_limit; \ + fpm_adr = (hmc_info)->hmc_obj[(type)].base + \ + (hmc_info)->hmc_obj[(type)].size * (idx); \ + fpm_limit = fpm_adr + (hmc_info)->hmc_obj[(type)].size * (cnt); \ + *(pd_index) = (u32)(fpm_adr / AVF_HMC_PAGED_BP_SIZE); \ + *(pd_limit) = (u32)((fpm_limit - 1) / AVF_HMC_PAGED_BP_SIZE); \ + /* add one more to the limit to correct our range */ \ + *(pd_limit) += 1; \ +} CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pd_limit' - possible side-effects? #6287: FILE: drivers/net/avf/base/avf_hmc.h:210: +#define AVF_FIND_PD_INDEX_LIMIT(hmc_info, type, idx, cnt, pd_index, pd_limit)\ +{ \ + u64 fpm_adr, fpm_limit; \ + fpm_adr = (hmc_info)->hmc_obj[(type)].base + \ + (hmc_info)->hmc_obj[(type)].size * (idx); \ + fpm_limit = fpm_adr + (hmc_info)->hmc_obj[(type)].size * (cnt); \ + *(pd_index) = (u32)(fpm_adr / AVF_HMC_PAGED_BP_SIZE); \ + *(pd_limit) = (u32)((fpm_limit - 1) / AVF_HMC_PAGED_BP_SIZE); \ + /* add one more to the limit to correct our range */ \ + *(pd_limit) += 1; \ +} WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #6330: FILE: drivers/net/avf/base/avf_lan_hmc.h:2: +/******************************************************************************* + WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #6404: FILE: drivers/net/avf/base/avf_lan_hmc.h:76: +/* Tx queue context data +* WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #6536: FILE: drivers/net/avf/base/avf_osdep.h:2: +/****************************************************************************** + ERROR:SPACING: space required after that ',' (ctx:VxV) #6631: FILE: drivers/net/avf/base/avf_osdep.h:97: +#define min(a,b) RTE_MIN(a,b) ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #6631: FILE: drivers/net/avf/base/avf_osdep.h:97: +#define min(a,b) RTE_MIN(a,b) ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #6632: FILE: drivers/net/avf/base/avf_osdep.h:98: +#define max(a,b) RTE_MAX(a,b) ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #6632: FILE: drivers/net/avf/base/avf_osdep.h:98: +#define max(a,b) RTE_MAX(a,b) ^ ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #6634: FILE: drivers/net/avf/base/avf_osdep.h:100: +#define FIELD_SIZEOF(t, f) (sizeof(((t*)0)->f)) ERROR:SPACING: space required before the open parenthesis '(' #6635: FILE: drivers/net/avf/base/avf_osdep.h:101: +#define ASSERT(x) if(!(x)) rte_panic("AVF: x") ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #6635: FILE: drivers/net/avf/base/avf_osdep.h:101: +#define ASSERT(x) if(!(x)) rte_panic("AVF: x") CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #6659: FILE: drivers/net/avf/base/avf_osdep.h:125: +#define avf_msec_delay(x) rte_delay_us(1000*(x)) ^ WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(arr) #6686: FILE: drivers/net/avf/base/avf_osdep.h:152: +#define ARRAY_SIZE(arr) (sizeof(arr)/sizeof(arr[0])) CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #6686: FILE: drivers/net/avf/base/avf_osdep.h:152: +#define ARRAY_SIZE(arr) (sizeof(arr)/sizeof(arr[0])) ^ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'arr' - possible side-effects? #6686: FILE: drivers/net/avf/base/avf_osdep.h:152: +#define ARRAY_SIZE(arr) (sizeof(arr)/sizeof(arr[0])) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'h' - possible side-effects? #6688: FILE: drivers/net/avf/base/avf_osdep.h:154: +#define avf_debug(h, m, s, ...) \ +do { \ + if (((m) & (h)->debug_mask)) \ + PMD_DRV_LOG_RAW(DEBUG, "avf %02x.%x " s, \ + (h)->bus.device, (h)->bus.func, \ + ##__VA_ARGS__); \ +} while (0) WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #6734: FILE: drivers/net/avf/base/avf_prototype.h:2: +/******************************************************************************* + WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #6946: FILE: drivers/net/avf/base/avf_register.h:2: +/******************************************************************************* + WARNING:LONG_LINE_COMMENT: line over 90 characters #6982: FILE: drivers/net/avf/base/avf_register.h:38: +#define AVFMSIX_PBA1(_i) (0x00002000 + ((_i) * 4)) /* _i=0...19 */ /* Reset: VFLR */ WARNING:LONG_LINE_COMMENT: line over 90 characters #6986: FILE: drivers/net/avf/base/avf_register.h:42: +#define AVFMSIX_TADD1(_i) (0x00002100 + ((_i) * 16)) /* _i=0...639 */ /* Reset: VFLR */ WARNING:LONG_LINE_COMMENT: line over 90 characters #6992: FILE: drivers/net/avf/base/avf_register.h:48: +#define AVFMSIX_TMSG1(_i) (0x00002108 + ((_i) * 16)) /* _i=0...639 */ /* Reset: VFLR */ WARNING:LONG_LINE_COMMENT: line over 90 characters #6996: FILE: drivers/net/avf/base/avf_register.h:52: +#define AVFMSIX_TUADD1(_i) (0x00002104 + ((_i) * 16)) /* _i=0...639 */ /* Reset: VFLR */ WARNING:LONG_LINE: line over 90 characters #6999: FILE: drivers/net/avf/base/avf_register.h:55: +#define AVFMSIX_TUADD1_MSIXTUADD_MASK AVF_MASK(0xFFFFFFFF, AVFMSIX_TUADD1_MSIXTUADD_SHIFT) WARNING:LONG_LINE_COMMENT: line over 90 characters #7000: FILE: drivers/net/avf/base/avf_register.h:56: +#define AVFMSIX_TVCTRL1(_i) (0x0000210C + ((_i) * 16)) /* _i=0...639 */ /* Reset: VFLR */ WARNING:LONG_LINE: line over 90 characters #7055: FILE: drivers/net/avf/base/avf_register.h:111: +#define AVFINT_DYN_CTL01_INTENA_MASK AVF_MASK(0x1, AVFINT_DYN_CTL01_INTENA_SHIFT) WARNING:LONG_LINE: line over 90 characters #7057: FILE: drivers/net/avf/base/avf_register.h:113: +#define AVFINT_DYN_CTL01_CLEARPBA_MASK AVF_MASK(0x1, AVFINT_DYN_CTL01_CLEARPBA_SHIFT) WARNING:LONG_LINE: line over 90 characters #7059: FILE: drivers/net/avf/base/avf_register.h:115: +#define AVFINT_DYN_CTL01_SWINT_TRIG_MASK AVF_MASK(0x1, AVFINT_DYN_CTL01_SWINT_TRIG_SHIFT) WARNING:LONG_LINE: line over 90 characters #7061: FILE: drivers/net/avf/base/avf_register.h:117: +#define AVFINT_DYN_CTL01_ITR_INDX_MASK AVF_MASK(0x3, AVFINT_DYN_CTL01_ITR_INDX_SHIFT) WARNING:LONG_LINE: line over 90 characters #7063: FILE: drivers/net/avf/base/avf_register.h:119: +#define AVFINT_DYN_CTL01_INTERVAL_MASK AVF_MASK(0xFFF, AVFINT_DYN_CTL01_INTERVAL_SHIFT) WARNING:LONG_LINE: line over 90 characters #7065: FILE: drivers/net/avf/base/avf_register.h:121: +#define AVFINT_DYN_CTL01_SW_ITR_INDX_ENA_MASK AVF_MASK(0x1, AVFINT_DYN_CTL01_SW_ITR_INDX_ENA_SHIFT) WARNING:LONG_LINE: line over 90 characters #7067: FILE: drivers/net/avf/base/avf_register.h:123: +#define AVFINT_DYN_CTL01_SW_ITR_INDX_MASK AVF_MASK(0x3, AVFINT_DYN_CTL01_SW_ITR_INDX_SHIFT) WARNING:LONG_LINE: line over 90 characters #7069: FILE: drivers/net/avf/base/avf_register.h:125: +#define AVFINT_DYN_CTL01_INTENA_MSK_MASK AVF_MASK(0x1, AVFINT_DYN_CTL01_INTENA_MSK_SHIFT) WARNING:LONG_LINE_COMMENT: line over 90 characters #7070: FILE: drivers/net/avf/base/avf_register.h:126: +#define AVFINT_DYN_CTLN1(_INTVF) (0x00003800 + ((_INTVF) * 4)) /* _i=0...15 */ /* Reset: VFR */ WARNING:LONG_LINE: line over 90 characters #7073: FILE: drivers/net/avf/base/avf_register.h:129: +#define AVFINT_DYN_CTLN1_INTENA_MASK AVF_MASK(0x1, AVFINT_DYN_CTLN1_INTENA_SHIFT) WARNING:LONG_LINE: line over 90 characters #7075: FILE: drivers/net/avf/base/avf_register.h:131: +#define AVFINT_DYN_CTLN1_CLEARPBA_MASK AVF_MASK(0x1, AVFINT_DYN_CTLN1_CLEARPBA_SHIFT) WARNING:LONG_LINE: line over 90 characters #7077: FILE: drivers/net/avf/base/avf_register.h:133: +#define AVFINT_DYN_CTLN1_SWINT_TRIG_MASK AVF_MASK(0x1, AVFINT_DYN_CTLN1_SWINT_TRIG_SHIFT) WARNING:LONG_LINE: line over 90 characters #7079: FILE: drivers/net/avf/base/avf_register.h:135: +#define AVFINT_DYN_CTLN1_ITR_INDX_MASK AVF_MASK(0x3, AVFINT_DYN_CTLN1_ITR_INDX_SHIFT) WARNING:LONG_LINE: line over 90 characters #7081: FILE: drivers/net/avf/base/avf_register.h:137: +#define AVFINT_DYN_CTLN1_INTERVAL_MASK AVF_MASK(0xFFF, AVFINT_DYN_CTLN1_INTERVAL_SHIFT) WARNING:LONG_LINE: line over 90 characters #7083: FILE: drivers/net/avf/base/avf_register.h:139: +#define AVFINT_DYN_CTLN1_SW_ITR_INDX_ENA_MASK AVF_MASK(0x1, AVFINT_DYN_CTLN1_SW_ITR_INDX_ENA_SHIFT) WARNING:LONG_LINE: line over 90 characters #7085: FILE: drivers/net/avf/base/avf_register.h:141: +#define AVFINT_DYN_CTLN1_SW_ITR_INDX_MASK AVF_MASK(0x3, AVFINT_DYN_CTLN1_SW_ITR_INDX_SHIFT) WARNING:LONG_LINE: line over 90 characters #7087: FILE: drivers/net/avf/base/avf_register.h:143: +#define AVFINT_DYN_CTLN1_INTENA_MSK_MASK AVF_MASK(0x1, AVFINT_DYN_CTLN1_INTENA_MSK_SHIFT) WARNING:LONG_LINE: line over 90 characters #7090: FILE: drivers/net/avf/base/avf_register.h:146: +#define AVFINT_ICR0_ENA1_LINK_STAT_CHANGE_MASK AVF_MASK(0x1, AVFINT_ICR0_ENA1_LINK_STAT_CHANGE_SHIFT) WARNING:LONG_LINE: line over 90 characters #7092: FILE: drivers/net/avf/base/avf_register.h:148: +#define AVFINT_ICR0_ENA1_ADMINQ_MASK AVF_MASK(0x1, AVFINT_ICR0_ENA1_ADMINQ_SHIFT) WARNING:LONG_LINE: line over 90 characters #7107: FILE: drivers/net/avf/base/avf_register.h:163: +#define AVFINT_ICR01_LINK_STAT_CHANGE_MASK AVF_MASK(0x1, AVFINT_ICR01_LINK_STAT_CHANGE_SHIFT) WARNING:LONG_LINE_COMMENT: line over 90 characters #7112: FILE: drivers/net/avf/base/avf_register.h:168: +#define AVFINT_ITR01(_i) (0x00004C00 + ((_i) * 4)) /* _i=0...2 */ /* Reset: VFR */ WARNING:LONG_LINE_COMMENT: line over 90 characters #7116: FILE: drivers/net/avf/base/avf_register.h:172: +#define AVFINT_ITRN1(_i, _INTVF) (0x00002800 + ((_i) * 64 + (_INTVF) * 4)) /* _i=0...2, _INTVF=0...15 */ /* Reset: VFR */ WARNING:LONG_LINE: line over 90 characters #7122: FILE: drivers/net/avf/base/avf_register.h:178: +#define AVFINT_STAT_CTL01_OTHER_ITR_INDX_MASK AVF_MASK(0x3, AVFINT_STAT_CTL01_OTHER_ITR_INDX_SHIFT) WARNING:LONG_LINE_COMMENT: line over 90 characters #7123: FILE: drivers/net/avf/base/avf_register.h:179: +#define AVF_QRX_TAIL1(_Q) (0x00002000 + ((_Q) * 4)) /* _i=0...15 */ /* Reset: CORER */ WARNING:LONG_LINE_COMMENT: line over 90 characters #7127: FILE: drivers/net/avf/base/avf_register.h:183: +#define AVF_QTX_TAIL1(_Q) (0x00000000 + ((_Q) * 4)) /* _i=0...15 */ /* Reset: PFR */ WARNING:LONG_LINE_COMMENT: line over 90 characters #7134: FILE: drivers/net/avf/base/avf_register.h:190: +#define AVFMSIX_TADD(_i) (0x00000000 + ((_i) * 16)) /* _i=0...16 */ /* Reset: VFLR */ WARNING:LONG_LINE_COMMENT: line over 90 characters #7140: FILE: drivers/net/avf/base/avf_register.h:196: +#define AVFMSIX_TMSG(_i) (0x00000008 + ((_i) * 16)) /* _i=0...16 */ /* Reset: VFLR */ WARNING:LONG_LINE_COMMENT: line over 90 characters #7144: FILE: drivers/net/avf/base/avf_register.h:200: +#define AVFMSIX_TUADD(_i) (0x00000004 + ((_i) * 16)) /* _i=0...16 */ /* Reset: VFLR */ WARNING:LONG_LINE_COMMENT: line over 90 characters #7148: FILE: drivers/net/avf/base/avf_register.h:204: +#define AVFMSIX_TVCTRL(_i) (0x0000000C + ((_i) * 16)) /* _i=0...16 */ /* Reset: VFLR */ WARNING:LONG_LINE: line over 90 characters #7161: FILE: drivers/net/avf/base/avf_register.h:217: +#define AVFCM_PE_ERRINFO_ERROR_VALID_MASK AVF_MASK(0x1, AVFCM_PE_ERRINFO_ERROR_VALID_SHIFT) WARNING:LONG_LINE: line over 90 characters #7163: FILE: drivers/net/avf/base/avf_register.h:219: +#define AVFCM_PE_ERRINFO_ERROR_INST_MASK AVF_MASK(0x7, AVFCM_PE_ERRINFO_ERROR_INST_SHIFT) WARNING:LONG_LINE: line over 90 characters #7165: FILE: drivers/net/avf/base/avf_register.h:221: +#define AVFCM_PE_ERRINFO_DBL_ERROR_CNT_MASK AVF_MASK(0xFF, AVFCM_PE_ERRINFO_DBL_ERROR_CNT_SHIFT) WARNING:LONG_LINE: line over 90 characters #7167: FILE: drivers/net/avf/base/avf_register.h:223: +#define AVFCM_PE_ERRINFO_RLU_ERROR_CNT_MASK AVF_MASK(0xFF, AVFCM_PE_ERRINFO_RLU_ERROR_CNT_SHIFT) WARNING:LONG_LINE: line over 90 characters #7169: FILE: drivers/net/avf/base/avf_register.h:225: +#define AVFCM_PE_ERRINFO_RLS_ERROR_CNT_MASK AVF_MASK(0xFF, AVFCM_PE_ERRINFO_RLS_ERROR_CNT_SHIFT) WARNING:LONG_LINE_COMMENT: line over 90 characters #7170: FILE: drivers/net/avf/base/avf_register.h:226: +#define AVFQF_HENA(_i) (0x0000C400 + ((_i) * 4)) /* _i=0...1 */ /* Reset: CORER */ WARNING:LONG_LINE_COMMENT: line over 90 characters #7174: FILE: drivers/net/avf/base/avf_register.h:230: +#define AVFQF_HKEY(_i) (0x0000CC00 + ((_i) * 4)) /* _i=0...12 */ /* Reset: CORER */ WARNING:LONG_LINE_COMMENT: line over 90 characters #7194: FILE: drivers/net/avf/base/avf_register.h:250: +#define AVFQF_HREGION(_i) (0x0000D400 + ((_i) * 4)) /* _i=0...7 */ /* Reset: CORER */ WARNING:LONG_LINE: line over 90 characters #7197: FILE: drivers/net/avf/base/avf_register.h:253: +#define AVFQF_HREGION_OVERRIDE_ENA_0_MASK AVF_MASK(0x1, AVFQF_HREGION_OVERRIDE_ENA_0_SHIFT) WARNING:LONG_LINE: line over 90 characters #7201: FILE: drivers/net/avf/base/avf_register.h:257: +#define AVFQF_HREGION_OVERRIDE_ENA_1_MASK AVF_MASK(0x1, AVFQF_HREGION_OVERRIDE_ENA_1_SHIFT) WARNING:LONG_LINE: line over 90 characters #7205: FILE: drivers/net/avf/base/avf_register.h:261: +#define AVFQF_HREGION_OVERRIDE_ENA_2_MASK AVF_MASK(0x1, AVFQF_HREGION_OVERRIDE_ENA_2_SHIFT) WARNING:LONG_LINE: line over 90 characters #7209: FILE: drivers/net/avf/base/avf_register.h:265: +#define AVFQF_HREGION_OVERRIDE_ENA_3_MASK AVF_MASK(0x1, AVFQF_HREGION_OVERRIDE_ENA_3_SHIFT) WARNING:LONG_LINE: line over 90 characters #7213: FILE: drivers/net/avf/base/avf_register.h:269: +#define AVFQF_HREGION_OVERRIDE_ENA_4_MASK AVF_MASK(0x1, AVFQF_HREGION_OVERRIDE_ENA_4_SHIFT) WARNING:LONG_LINE: line over 90 characters #7217: FILE: drivers/net/avf/base/avf_register.h:273: +#define AVFQF_HREGION_OVERRIDE_ENA_5_MASK AVF_MASK(0x1, AVFQF_HREGION_OVERRIDE_ENA_5_SHIFT) WARNING:LONG_LINE: line over 90 characters #7221: FILE: drivers/net/avf/base/avf_register.h:277: +#define AVFQF_HREGION_OVERRIDE_ENA_6_MASK AVF_MASK(0x1, AVFQF_HREGION_OVERRIDE_ENA_6_SHIFT) WARNING:LONG_LINE: line over 90 characters #7225: FILE: drivers/net/avf/base/avf_register.h:281: +#define AVFQF_HREGION_OVERRIDE_ENA_7_MASK AVF_MASK(0x1, AVFQF_HREGION_OVERRIDE_ENA_7_SHIFT) WARNING:LONG_LINE: line over 90 characters #7230: FILE: drivers/net/avf/base/avf_register.h:286: +#define AVFINT_DYN_CTL01_WB_ON_ITR_MASK AVF_MASK(0x1, AVFINT_DYN_CTL01_WB_ON_ITR_SHIFT) WARNING:LONG_LINE: line over 90 characters #7232: FILE: drivers/net/avf/base/avf_register.h:288: +#define AVFINT_DYN_CTLN1_WB_ON_ITR_MASK AVF_MASK(0x1, AVFINT_DYN_CTLN1_WB_ON_ITR_SHIFT) WARNING:LONG_LINE: line over 90 characters #7238: FILE: drivers/net/avf/base/avf_register.h:294: +#define AVFPE_CCQPHIGH1_PECCQPHIGH_MASK AVF_MASK(0xFFFFFFFF, AVFPE_CCQPHIGH1_PECCQPHIGH_SHIFT) WARNING:LONG_LINE: line over 90 characters #7241: FILE: drivers/net/avf/base/avf_register.h:297: +#define AVFPE_CCQPLOW1_PECCQPLOW_MASK AVF_MASK(0xFFFFFFFF, AVFPE_CCQPLOW1_PECCQPLOW_SHIFT) WARNING:LONG_LINE: line over 90 characters #7244: FILE: drivers/net/avf/base/avf_register.h:300: +#define AVFPE_CCQPSTATUS1_CCQP_DONE_MASK AVF_MASK(0x1, AVFPE_CCQPSTATUS1_CCQP_DONE_SHIFT) WARNING:LONG_LINE: line over 90 characters #7246: FILE: drivers/net/avf/base/avf_register.h:302: +#define AVFPE_CCQPSTATUS1_HMC_PROFILE_MASK AVF_MASK(0x7, AVFPE_CCQPSTATUS1_HMC_PROFILE_SHIFT) WARNING:LONG_LINE: line over 90 characters #7248: FILE: drivers/net/avf/base/avf_register.h:304: +#define AVFPE_CCQPSTATUS1_RDMA_EN_VFS_MASK AVF_MASK(0x3F, AVFPE_CCQPSTATUS1_RDMA_EN_VFS_SHIFT) WARNING:LONG_LINE: line over 90 characters #7250: FILE: drivers/net/avf/base/avf_register.h:306: +#define AVFPE_CCQPSTATUS1_CCQP_ERR_MASK AVF_MASK(0x1, AVFPE_CCQPSTATUS1_CCQP_ERR_SHIFT) WARNING:LONG_LINE: line over 90 characters #7262: FILE: drivers/net/avf/base/avf_register.h:318: +#define AVFPE_CQPERRCODES1_CQP_MINOR_CODE_MASK AVF_MASK(0xFFFF, AVFPE_CQPERRCODES1_CQP_MINOR_CODE_SHIFT) WARNING:LONG_LINE: line over 90 characters #7264: FILE: drivers/net/avf/base/avf_register.h:320: +#define AVFPE_CQPERRCODES1_CQP_MAJOR_CODE_MASK AVF_MASK(0xFFFF, AVFPE_CQPERRCODES1_CQP_MAJOR_CODE_SHIFT) WARNING:LONG_LINE: line over 90 characters #7272: FILE: drivers/net/avf/base/avf_register.h:328: +#define AVFPE_IPCONFIG01_PEIPID_MASK AVF_MASK(0xFFFF, AVFPE_IPCONFIG01_PEIPID_SHIFT) WARNING:LONG_LINE: line over 90 characters #7274: FILE: drivers/net/avf/base/avf_register.h:330: +#define AVFPE_IPCONFIG01_USEENTIREIDRANGE_MASK AVF_MASK(0x1, AVFPE_IPCONFIG01_USEENTIREIDRANGE_SHIFT) WARNING:LONG_LINE: line over 90 characters #7277: FILE: drivers/net/avf/base/avf_register.h:333: +#define AVFPE_MRTEIDXMASK1_MRTEIDXMASKBITS_MASK AVF_MASK(0x1F, AVFPE_MRTEIDXMASK1_MRTEIDXMASKBITS_SHIFT) WARNING:LONG_LINE: line over 90 characters #7280: FILE: drivers/net/avf/base/avf_register.h:336: +#define AVFPE_RCVUNEXPECTEDERROR1_TCP_RX_UNEXP_ERR_MASK AVF_MASK(0xFFFFFF, AVFPE_RCVUNEXPECTEDERROR1_TCP_RX_UNEXP_ERR_SHIFT) WARNING:LONG_LINE: line over 90 characters #7283: FILE: drivers/net/avf/base/avf_register.h:339: +#define AVFPE_TCPNOWTIMER1_TCP_NOW_MASK AVF_MASK(0xFFFFFFFF, AVFPE_TCPNOWTIMER1_TCP_NOW_SHIFT) WARNING:LONG_LINE: line over 90 characters #7286: FILE: drivers/net/avf/base/avf_register.h:342: +#define AVFPE_WQEALLOC1_PEQPID_MASK AVF_MASK(0x3FFFF, AVFPE_WQEALLOC1_PEQPID_SHIFT) WARNING:LONG_LINE: line over 90 characters #7288: FILE: drivers/net/avf/base/avf_register.h:344: +#define AVFPE_WQEALLOC1_WQE_DESC_INDEX_MASK AVF_MASK(0xFFF, AVFPE_WQEALLOC1_WQE_DESC_INDEX_SHIFT) WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #7298: FILE: drivers/net/avf/base/avf_status.h:2: +/******************************************************************************* + WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #7411: FILE: drivers/net/avf/base/avf_type.h:2: +/******************************************************************************* + WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #7455: FILE: drivers/net/avf/base/avf_type.h:46: +#define UNREFERENCED_1PARAMETER(_p) (_p); ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #7456: FILE: drivers/net/avf/base/avf_type.h:47: +#define UNREFERENCED_2PARAMETER(_p, _q) (_p); (_q); WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #7456: FILE: drivers/net/avf/base/avf_type.h:47: +#define UNREFERENCED_2PARAMETER(_p, _q) (_p); (_q); ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #7457: FILE: drivers/net/avf/base/avf_type.h:48: +#define UNREFERENCED_3PARAMETER(_p, _q, _r) (_p); (_q); (_r); WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #7457: FILE: drivers/net/avf/base/avf_type.h:48: +#define UNREFERENCED_3PARAMETER(_p, _q, _r) (_p); (_q); (_r); ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #7458: FILE: drivers/net/avf/base/avf_type.h:49: +#define UNREFERENCED_4PARAMETER(_p, _q, _r, _s) (_p); (_q); (_r); (_s); WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #7458: FILE: drivers/net/avf/base/avf_type.h:49: +#define UNREFERENCED_4PARAMETER(_p, _q, _r, _s) (_p); (_q); (_r); (_s); ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #7459: FILE: drivers/net/avf/base/avf_type.h:50: +#define UNREFERENCED_5PARAMETER(_p, _q, _r, _s, _t) (_p); (_q); (_r); (_s); (_t); WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #7459: FILE: drivers/net/avf/base/avf_type.h:50: +#define UNREFERENCED_5PARAMETER(_p, _q, _r, _s, _t) (_p); (_q); (_r); (_s); (_t); CHECK:MACRO_ARG_REUSE: Macro argument reuse 'address' - possible side-effects? #7493: FILE: drivers/net/avf/base/avf_type.h:84: +#define AVF_IS_BROADCAST(address) \ + ((((u8 *)(address))[0] == ((u8)0xff)) && \ + (((u8 *)(address))[1] == ((u8)0xff))) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'R' - possible side-effects? #7524: FILE: drivers/net/avf/base/avf_type.h:115: +#define AVF_DESC_UNUSED(R) \ + ((((R)->next_to_clean > (R)->next_to_use) ? 0 : (R)->count) + \ + (R)->next_to_clean - (R)->next_to_use - 1) WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #9407: FILE: drivers/net/avf/base/virtchnl.h:2: +/******************************************************************************* + CHECK:MACRO_ARG_REUSE: Macro argument reuse 'n' - possible side-effects? #9565: FILE: drivers/net/avf/base/virtchnl.h:160: +#define VIRTCHNL_CHECK_STRUCT_LEN(n, X) enum virtchnl_static_assert_enum_##X \ + {virtchnl_static_assert_##X = (n) / ((sizeof(struct X) == (n)) ? 1 : 0)} CHECK:MACRO_ARG_REUSE: Macro argument reuse '_v' - possible side-effects? #9606: FILE: drivers/net/avf/base/virtchnl.h:201: +#define VF_IS_V10(_v) (((_v)->major == 1) && ((_v)->minor == 0)) CHECK:MACRO_ARG_REUSE: Macro argument reuse '_ver' - possible side-effects? #9607: FILE: drivers/net/avf/base/virtchnl.h:202: +#define VF_IS_V11(_ver) (((_ver)->major == 1) && ((_ver)->minor == 1)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'valid_len != msglen' #10172: FILE: drivers/net/avf/base/virtchnl.h:767: + if ((valid_len != msglen) || (err_msg_format)) total: 11 errors, 98 warnings, 51 checks, 10039 lines checked