From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 378AF1B807; Tue, 24 Oct 2017 15:16:57 +0200 (CEST)
In-Reply-To: <20171024131630.16595-3-luca.boccassi@gmail.com>
References: <20171024131630.16595-3-luca.boccassi@gmail.com>
To: test-report@dpdk.org
Cc: Luca Boccassi <luca.boccassi@gmail.com>
Message-Id: <20171024131657.378AF1B807@dpdk.org>
Date: Tue, 24 Oct 2017 15:16:57 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw30795 [PATCH 2/3] net/e1000:
	implement VF reset
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Oct 2017 13:16:57 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/30795

_coding style issues_


WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#59: FILE: drivers/net/e1000/igb_ethdev.c:2990:
+	if (!dev->data->dev_started)
+		 return -EAGAIN;

WARNING:TABSTOP: Statements should start on a tabstop
#60: FILE: drivers/net/e1000/igb_ethdev.c:2991:
+		 return -EAGAIN;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#65: FILE: drivers/net/e1000/igb_ethdev.c:2996:
+	do {
+		 dev->data->dev_started = 0;

WARNING:TABSTOP: Statements should start on a tabstop
#68: FILE: drivers/net/e1000/igb_ethdev.c:2999:
+		 if (dev->data->dev_conf.intr_conf.lsc == 0)

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (17, 26)
#68: FILE: drivers/net/e1000/igb_ethdev.c:2999:
+		 if (dev->data->dev_conf.intr_conf.lsc == 0)
+			  diag = eth_igb_link_update(dev, 0);

WARNING:TABSTOP: Statements should start on a tabstop
#70: FILE: drivers/net/e1000/igb_ethdev.c:3001:
+		 if (diag) {

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (17, 26)
#70: FILE: drivers/net/e1000/igb_ethdev.c:3001:
+		 if (diag) {
+			  PMD_INIT_LOG(INFO, "Igb VF reset: "

WARNING:TABSTOP: Statements should start on a tabstop
#73: FILE: drivers/net/e1000/igb_ethdev.c:3004:
+		 }

WARNING:TABSTOP: Statements should start on a tabstop
#78: FILE: drivers/net/e1000/igb_ethdev.c:3009:
+		 if (diag) {

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (17, 26)
#78: FILE: drivers/net/e1000/igb_ethdev.c:3009:
+		 if (diag) {
+			  PMD_INIT_LOG(ERR, "Igb VF reset: "

WARNING:TABSTOP: Statements should start on a tabstop
#81: FILE: drivers/net/e1000/igb_ethdev.c:3012:
+			  return -EAGAIN;

WARNING:TABSTOP: Statements should start on a tabstop
#82: FILE: drivers/net/e1000/igb_ethdev.c:3013:
+		 }

WARNING:TABSTOP: Statements should start on a tabstop
#84: FILE: drivers/net/e1000/igb_ethdev.c:3015:
+		 if (dev->data->dev_conf.intr_conf.lsc == 0)

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (17, 26)
#84: FILE: drivers/net/e1000/igb_ethdev.c:3015:
+		 if (dev->data->dev_conf.intr_conf.lsc == 0)
+			  diag = eth_igb_link_update(dev, 0);

WARNING:TABSTOP: Statements should start on a tabstop
#86: FILE: drivers/net/e1000/igb_ethdev.c:3017:
+		 if (diag) {

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (17, 26)
#86: FILE: drivers/net/e1000/igb_ethdev.c:3017:
+		 if (diag) {
+			  PMD_INIT_LOG(INFO, "Igb VF reset: "

WARNING:TABSTOP: Statements should start on a tabstop
#89: FILE: drivers/net/e1000/igb_ethdev.c:3020:
+		 }

total: 0 errors, 17 warnings, 0 checks, 77 lines checked