From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id B4FF41B925; Wed, 25 Oct 2017 05:02:18 +0200 (CEST)
In-Reply-To: <20171025030101.43269-1-ferruh.yigit@intel.com>
References: <20171025030101.43269-1-ferruh.yigit@intel.com>
To: test-report@dpdk.org
Cc: Ferruh Yigit <ferruh.yigit@intel.com>
Message-Id: <20171025030218.B4FF41B925@dpdk.org>
Date: Wed, 25 Oct 2017 05:02:18 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw30844 [PATCH v5] ethdev: allow
	returning error on VLAN offload ops
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Oct 2017 03:02:18 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/30844

_coding style issues_


WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_eth_dev *' should also have an identifier name
#573: FILE: drivers/net/mlx5/mlx5.h:251:
+int mlx5_vlan_offload_set(struct rte_eth_dev *, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name
#573: FILE: drivers/net/mlx5/mlx5.h:251:
+int mlx5_vlan_offload_set(struct rte_eth_dev *, int);

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#720: FILE: drivers/net/virtio/virtio_ethdev.c:1967:
+				!vtpci_with_feature(hw, VIRTIO_NET_F_CTRL_VLAN)) {
+

total: 0 errors, 2 warnings, 589 lines checked