From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Akhil Goyal <akhil.goyal@nxp.com>
Subject: [dpdk-test-report] |WARNING| pw30885 [PATCH v6 08/10] net/ixgbe: enable inline ipsec
Date: Wed, 25 Oct 2017 17:12:18 +0200 (CEST) [thread overview]
Message-ID: <20171025151218.9534C1BA03@dpdk.org> (raw)
In-Reply-To: <20171025150727.30364-9-akhil.goyal@nxp.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/30885
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects?
#63: FILE: drivers/net/ixgbe/base/ixgbe_osdep.h:164:
+#define IXGBE_WRITE_REG_THEN_POLL_MASK(hw, reg, val, mask, poll_ms) \
+do { \
+ uint32_t cnt = poll_ms; \
+ IXGBE_WRITE_REG(hw, (reg), (val)); \
+ while (((IXGBE_READ_REG(hw, (reg))) & (mask)) && (cnt--)) \
+ rte_delay_ms(1); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'reg' - possible side-effects?
#63: FILE: drivers/net/ixgbe/base/ixgbe_osdep.h:164:
+#define IXGBE_WRITE_REG_THEN_POLL_MASK(hw, reg, val, mask, poll_ms) \
+do { \
+ uint32_t cnt = poll_ms; \
+ IXGBE_WRITE_REG(hw, (reg), (val)); \
+ while (((IXGBE_READ_REG(hw, (reg))) & (mask)) && (cnt--)) \
+ rte_delay_ms(1); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#292: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:62:
+#define CMP_IP(a, b) (\
+ (a).ipv6[0] == (b).ipv6[0] && \
+ (a).ipv6[1] == (b).ipv6[1] && \
+ (a).ipv6[2] == (b).ipv6[2] && \
+ (a).ipv6[3] == (b).ipv6[3])
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#292: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:62:
+#define CMP_IP(a, b) (\
+ (a).ipv6[0] == (b).ipv6[0] && \
+ (a).ipv6[1] == (b).ipv6[1] && \
+ (a).ipv6[2] == (b).ipv6[2] && \
+ (a).ipv6[3] == (b).ipv6[3])
CHECK:CAMELCASE: Avoid CamelCase: <IPv6>
#420: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:190:
+ if (ic_session->dst_ip.type == IPv6)
CHECK:CAMELCASE: Avoid CamelCase: <IPv4>
#427: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:197:
+ if (priv->rx_ip_tbl[ip_index].ip.type == IPv4) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'txq->tx_rs_thresh >= RTE_PMD_IXGBE_TX_MAX_BURST'
#1234: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:2399:
+ if (((txq->txq_flags & IXGBE_SIMPLE_FLAGS) == IXGBE_SIMPLE_FLAGS) &&
+ (txq->tx_rs_thresh >= RTE_PMD_IXGBE_TX_MAX_BURST) &&
+ !(dev->data->dev_conf.txmode.offloads
+ & DEV_TX_OFFLOAD_SECURITY)) {
total: 0 errors, 0 warnings, 7 checks, 1284 lines checked
parent reply other threads:[~2017-10-25 15:12 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20171025150727.30364-9-akhil.goyal@nxp.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171025151218.9534C1BA03@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=akhil.goyal@nxp.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).