From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
Subject: [dpdk-test-report] |WARNING| pw30927 [PATCH v7 23/25] pci: introduce PCI lib and bus
Date: Thu, 26 Oct 2017 00:42:09 +0200 (CEST) [thread overview]
Message-ID: <20171025224209.C0EB91BA6E@dpdk.org> (raw)
In-Reply-To: <bd35cd0fb8c488e7c3fa007503a6afc7fad83c88.1508970254.git.gaetan.rivet@6wind.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/30927
_coding style issues_
WARNING:LONG_LINE: line over 90 characters
#476: FILE: drivers/bus/pci/bsd/pci.c:157:
+ "skipping
", loc->domain, loc->bus, loc->devid, loc->function);
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#567: FILE: drivers/bus/pci/bsd/pci.c:248:
+ unsigned i, max;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#570: FILE: drivers/bus/pci/bsd/pci.c:251:
+ if (dev == NULL) {
+ return -1;
+ }
WARNING:LONG_LINE: line over 90 characters
#631: FILE: drivers/bus/pci/bsd/pci.c:312:
+ dev->mem_resource[i].addr = (void *)(bar.pbi_base & ~((uint64_t)0xf));
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#641: FILE: drivers/bus/pci/bsd/pci.c:322:
+ }
+ else {
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#680: FILE: drivers/bus/pci/bsd/pci.c:361:
+ unsigned dev_count = 0;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#701: FILE: drivers/bus/pci/bsd/pci.c:382:
+ unsigned i;
ERROR:SPACING: space required before the open parenthesis '('
#713: FILE: drivers/bus/pci/bsd/pci.c:394:
+ } while(conf_io.status == PCI_GETCONF_MORE_DEVS);
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1120: FILE: drivers/bus/pci/include/rte_bus_pci.h:114:
+#define RTE_PCI_DEVICE(vend, dev) \
+ RTE_CLASS_ANY_ID, \
+ (vend), \
+ (dev), \
+ PCI_ANY_ID, \
+ PCI_ANY_ID
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1547: FILE: drivers/bus/pci/linux/pci.c:153:
+ unsigned i = 0;
ERROR:SPACING: spaces required around that '<' (ctx:VxV)
#1609: FILE: drivers/bus/pci/linux/pci.c:215:
+ for (i = 0; i<PCI_MAX_RESOURCE; i++) {
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#1823: FILE: drivers/bus/pci/linux/pci.c:429:
+ splitaddr.function = strchr(splitaddr.devid,'.');
^
WARNING:NAKED_SSCANF: unchecked sscanf return value
#2078: FILE: drivers/bus/pci/linux/pci.c:684:
+ sscanf(ptr, "%04hx-%04hx", &start, &end);
ERROR:CODE_INDENT: code indent should use tabs where possible
#2310: FILE: drivers/bus/pci/linux/pci_init.h:84:
+^I^I struct rte_pci_ioport *p);$
ERROR:GLOBAL_INITIALISERS: do not initialise globals to NULL
#2389: FILE: drivers/bus/pci/linux/pci_uio.c:58:
+void *pci_map_addr = NULL;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2437: FILE: drivers/bus/pci/linux/pci_uio.c:106:
+pci_mknod_uio_dev(const char *sysfs_uio_path, unsigned uio_num)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2442: FILE: drivers/bus/pci/linux/pci_uio.c:111:
+ unsigned major, minor;
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#2446: FILE: drivers/bus/pci/linux/pci_uio.c:115:
+ * of the uio device and read its content */
WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'.
#2468: FILE: drivers/bus/pci/linux/pci_uio.c:137:
+ ret = mknod(filename, S_IFCHR | S_IRUSR | S_IWUSR, dev);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#2495: FILE: drivers/bus/pci/linux/pci_uio.c:164:
+ * or uio:uioX */
WARNING:LONG_LINE: line over 90 characters
#2589: FILE: drivers/bus/pci/linux/pci_uio.c:258:
+ "skipping
", loc->domain, loc->bus, loc->devid, loc->function);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#2729: FILE: drivers/bus/pci/linux/pci_uio.c:398:
+ * uin16_t */
WARNING:LONG_LINE: line over 90 characters
#3036: FILE: drivers/bus/pci/linux/pci_vfio.c:131:
+ VFIO_GET_REGION_ADDR(VFIO_PCI_CONFIG_REGION_INDEX) +
WARNING:LONG_LINE: line over 90 characters
#3053: FILE: drivers/bus/pci/linux/pci_vfio.c:148:
+ VFIO_GET_REGION_ADDR(VFIO_PCI_CONFIG_REGION_INDEX) +
WARNING:LONG_LINE: line over 90 characters
#3062: FILE: drivers/bus/pci/linux/pci_vfio.c:157:
+ VFIO_GET_REGION_ADDR(VFIO_PCI_CONFIG_REGION_INDEX) +
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#3168: FILE: drivers/bus/pci/linux/pci_vfio.c:263:
+ * specified interrupt type, otherwise continue */
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#3174: FILE: drivers/bus/pci/linux/pci_vfio.c:269:
+ return -1;
+ } else
WARNING:LONG_LINE: line over 90 characters
#3407: FILE: drivers/bus/pci/linux/pci_vfio.c:502:
+ "error %i (%s)
", pci_addr, errno, strerror(errno));
total: 7 errors, 21 warnings, 5856 lines checked
parent reply other threads:[~2017-10-25 22:42 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <bd35cd0fb8c488e7c3fa007503a6afc7fad83c88.1508970254.git.gaetan.rivet@6wind.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171025224209.C0EB91BA6E@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).