From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 4C16A1BA84; Thu, 26 Oct 2017 12:08:13 +0200 (CEST)
In-Reply-To: <6c8b14fd39866c1b30b0103bab7bd88a729867e0.1509012196.git.gaetan.rivet@6wind.com>
References: <6c8b14fd39866c1b30b0103bab7bd88a729867e0.1509012196.git.gaetan.rivet@6wind.com>
To: test-report@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
Message-Id: <20171026100813.4C16A1BA84@dpdk.org>
Date: Thu, 26 Oct 2017 12:08:13 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw30950 [PATCH v8 11/25] pci: avoid
	inlining functions
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Oct 2017 10:08:13 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/30950

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#33: FILE: lib/librte_eal/common/eal_common_pci.c:91:
+#define GET_PCIADDR_FIELD(in, fd, lim, dlm)                     \
+do {                                                            \
+	unsigned long val;                                      \
+	char *end;                                              \
+	errno = 0;                                              \
+	val = strtoul((in), &end, 16);                          \
+	if (errno != 0 || end[0] != (dlm) || val > (lim))       \
+		return -EINVAL;                                 \
+	(fd) = (typeof (fd))val;                                \
+	(in) = end + 1;                                         \
+} while(0)

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#41: FILE: lib/librte_eal/common/eal_common_pci.c:99:
+	(fd) = (typeof (fd))val;                                \

ERROR:SPACING: space required before the open parenthesis '('
#43: FILE: lib/librte_eal/common/eal_common_pci.c:101:
+} while(0)

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#84: FILE: lib/librte_eal/common/eal_common_pci.c:142:
+	if ((addr == NULL) || (addr2 == NULL))
+		 return -1;

WARNING:TABSTOP: Statements should start on a tabstop
#85: FILE: lib/librte_eal/common/eal_common_pci.c:143:
+		 return -1;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#92: FILE: lib/librte_eal/common/eal_common_pci.c:150:
+	if (dev_addr > dev_addr2)
+		 return 1;

WARNING:TABSTOP: Statements should start on a tabstop
#93: FILE: lib/librte_eal/common/eal_common_pci.c:151:
+		 return 1;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#94: FILE: lib/librte_eal/common/eal_common_pci.c:152:
+	else if (dev_addr < dev_addr2)
+		 return -1;

WARNING:TABSTOP: Statements should start on a tabstop
#95: FILE: lib/librte_eal/common/eal_common_pci.c:153:
+		 return -1;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#96: FILE: lib/librte_eal/common/eal_common_pci.c:154:
+	else
+		 return 0;

WARNING:TABSTOP: Statements should start on a tabstop
#97: FILE: lib/librte_eal/common/eal_common_pci.c:155:
+		 return 0;

total: 1 errors, 10 warnings, 192 lines checked