From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
Subject: [dpdk-test-report] |WARNING| pw31082 [PATCH 2/6] lib/representor: port representor library to manage broker
Date: Wed, 1 Nov 2017 16:47:53 +0100 (CET) [thread overview]
Message-ID: <20171101154753.2170F1B34D@dpdk.org> (raw)
In-Reply-To: <1509551187-25726-2-git-send-email-mohammad.abdul.awal@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31082
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#173: FILE: lib/librte_representor/rte_port_representor.c:41:
+#define RTE_VERIFY_OR_ERR_RET(val, retval) do { \
+ if (!(val)) { \
+ RTE_PMD_DEBUG_TRACE("verify failed, ret= %d", (retval)); \
+ return retval; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#180: FILE: lib/librte_representor/rte_port_representor.c:48:
+#define RTE_VERIFY_OR_RET(val) do { \
+ if (!(val)) { \
+ RTE_PMD_DEBUG_TRACE("verify failed"); \
+ return; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#249: FILE: lib/librte_representor/rte_port_representor.c:117:
+#define RTE_REPRESENTOR_PORT_VALID_ETHDEV_OR_RET_ERR(ethdev, retval) do { \
+ if (!(ethdev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR_PORT)) { \
+ RTE_PMD_DEBUG_TRACE("port %d is not a representor port", \
+ ethdev->data.port_id); \
+ return retval; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#257: FILE: lib/librte_representor/rte_port_representor.c:125:
+#define RTE_REPRESENTOR_PORT_VALID_OR_RET_ERR(vport, retval) do { \
+ if (!(vport->state == RTE_REPRESENTOR_PORT_VALID)) { \
+ RTE_PMD_DEBUG_TRACE("port %d is not a representor port", \
+ ethdev->data.port_id); \
+ return retval; \
+ } \
+} while (0)
total: 0 errors, 4 warnings, 484 lines checked
parent reply other threads:[~2017-11-01 15:47 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1509551187-25726-2-git-send-email-mohammad.abdul.awal@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101154753.2170F1B34D@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=mohammad.abdul.awal@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).