* [dpdk-test-report] |WARNING| pw31082 [PATCH 2/6] lib/representor: port representor library to manage broker
[not found] <1509551187-25726-2-git-send-email-mohammad.abdul.awal@intel.com>
@ 2017-11-01 15:47 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-11-01 15:47 UTC (permalink / raw)
To: test-report; +Cc: Mohammad Abdul Awal
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31082
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#173: FILE: lib/librte_representor/rte_port_representor.c:41:
+#define RTE_VERIFY_OR_ERR_RET(val, retval) do { \
+ if (!(val)) { \
+ RTE_PMD_DEBUG_TRACE("verify failed, ret= %d", (retval)); \
+ return retval; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#180: FILE: lib/librte_representor/rte_port_representor.c:48:
+#define RTE_VERIFY_OR_RET(val) do { \
+ if (!(val)) { \
+ RTE_PMD_DEBUG_TRACE("verify failed"); \
+ return; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#249: FILE: lib/librte_representor/rte_port_representor.c:117:
+#define RTE_REPRESENTOR_PORT_VALID_ETHDEV_OR_RET_ERR(ethdev, retval) do { \
+ if (!(ethdev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR_PORT)) { \
+ RTE_PMD_DEBUG_TRACE("port %d is not a representor port", \
+ ethdev->data.port_id); \
+ return retval; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#257: FILE: lib/librte_representor/rte_port_representor.c:125:
+#define RTE_REPRESENTOR_PORT_VALID_OR_RET_ERR(vport, retval) do { \
+ if (!(vport->state == RTE_REPRESENTOR_PORT_VALID)) { \
+ RTE_PMD_DEBUG_TRACE("port %d is not a representor port", \
+ ethdev->data.port_id); \
+ return retval; \
+ } \
+} while (0)
total: 0 errors, 4 warnings, 484 lines checked
^ permalink raw reply [flat|nested] only message in thread